| Message ID | 1334336309-5039-1-git-send-email-manoj.iyer@canonical.com |
|---|---|
| State | New |
| Headers | show |
On 04/13/2012 09:58 AM, manoj.iyer@canonical.com wrote: > From: Manoj Iyer <manoj.iyer@canonical.com> > > T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e042 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=E4D53DCA61B5 > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Reported-by: Dennis Chua <dennis.chua@canonical.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > > BugLink: http://bugs.launchpad.net/bugs/980965 > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index d2236c10..5e8c342 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { > { USB_DEVICE(0x0c10, 0x0000) }, > > /* Broadcom BCM20702A0 */ > + { USB_DEVICE(0x0489, 0xe042) }, > { USB_DEVICE(0x0a5c, 0x21e1) }, > { USB_DEVICE(0x0a5c, 0x21e3) }, > { USB_DEVICE(0x0a5c, 0x21e6) }, Manoj, I'm not sure which series you want this applied to but *all* series are now under SRU rules. Please look at: https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat
On 04/13/2012 11:55 AM, Brad Figg wrote: > On 04/13/2012 09:58 AM, manoj.iyer@canonical.com wrote: >> From: Manoj Iyer <manoj.iyer@canonical.com> >> >> T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=0489 ProdID=e042 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM20702A0 >> S: SerialNumber=E4D53DCA61B5 >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Reported-by: Dennis Chua <dennis.chua@canonical.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> >> BugLink: http://bugs.launchpad.net/bugs/980965 >> --- >> drivers/bluetooth/btusb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index d2236c10..5e8c342 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { >> { USB_DEVICE(0x0c10, 0x0000) }, >> >> /* Broadcom BCM20702A0 */ >> + { USB_DEVICE(0x0489, 0xe042) }, >> { USB_DEVICE(0x0a5c, 0x21e1) }, >> { USB_DEVICE(0x0a5c, 0x21e3) }, >> { USB_DEVICE(0x0a5c, 0x21e6) }, > > Manoj, > > I'm not sure which series you want this applied to but *all* series are now > under SRU rules. > > Please look at: > https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat > > Manoj, Part of my confusion was that the subjects didn't indicate [Patch 0/1] [Patch 1/1] as most patches usually do. Also, the actual patch is usually "threaded" with the letter head. Brad
On 04/13/2012 11:55 AM, Brad Figg wrote: > On 04/13/2012 09:58 AM, manoj.iyer@canonical.com wrote: >> From: Manoj Iyer <manoj.iyer@canonical.com> >> >> T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=0489 ProdID=e042 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM20702A0 >> S: SerialNumber=E4D53DCA61B5 >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Reported-by: Dennis Chua <dennis.chua@canonical.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> >> BugLink: http://bugs.launchpad.net/bugs/980965 >> --- >> drivers/bluetooth/btusb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index d2236c10..5e8c342 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { >> { USB_DEVICE(0x0c10, 0x0000) }, >> >> /* Broadcom BCM20702A0 */ >> + { USB_DEVICE(0x0489, 0xe042) }, >> { USB_DEVICE(0x0a5c, 0x21e1) }, >> { USB_DEVICE(0x0a5c, 0x21e3) }, >> { USB_DEVICE(0x0a5c, 0x21e6) }, > > Manoj, > > I'm not sure which series you want this applied to but *all* series are now > under SRU rules. > > Please look at: > https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat > > Manoj, When I submit patches to the mailing list, I put all the patches for a single submission into a common directory. I then run the following script, pointing at that directory: #!/bin/sh git send-email --no-chain-reply-to --thread --suppress-cc all --from "Brad Figg <brad.figg@canonical.com>" --to kernel-team@lists.ubuntu.com $1
On 04/13/2012 02:55 PM, Brad Figg wrote: > On 04/13/2012 09:58 AM, manoj.iyer@canonical.com wrote: >> From: Manoj Iyer <manoj.iyer@canonical.com> >> >> T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=0489 ProdID=e042 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM20702A0 >> S: SerialNumber=E4D53DCA61B5 >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Reported-by: Dennis Chua <dennis.chua@canonical.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> >> BugLink: http://bugs.launchpad.net/bugs/980965 >> --- >> drivers/bluetooth/btusb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index d2236c10..5e8c342 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { >> { USB_DEVICE(0x0c10, 0x0000) }, >> >> /* Broadcom BCM20702A0 */ >> + { USB_DEVICE(0x0489, 0xe042) }, >> { USB_DEVICE(0x0a5c, 0x21e1) }, >> { USB_DEVICE(0x0a5c, 0x21e3) }, >> { USB_DEVICE(0x0a5c, 0x21e6) }, > > Manoj, > > I'm not sure which series you want this applied to but *all* series are now > under SRU rules. > > Please look at: > https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat Looks like this just hit upstream[0], so likely "UBUNTU SAUCE: (upstream)" at the moment. I just checked the ubuntu-precise tree and we'd need this for both Oneiric and Precise. --chris [0] -- https://lkml.org/lkml/2012/4/13/72
On Fri, 2012-04-13 at 11:58 -0500, manoj.iyer@canonical.com wrote: > From: Manoj Iyer <manoj.iyer@canonical.com> > > T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e042 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=E4D53DCA61B5 > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Reported-by: Dennis Chua <dennis.chua@canonical.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > > BugLink: http://bugs.launchpad.net/bugs/980965 Based on Chris' comment, this appears to be for Precise and Oneiric. For future reference, you should add Cc: stable@vger.kernel.org to the commit for patches like these when you submit them upstream. That way it'll get picked up by upstream stable automatically and subsequently get added to our Ubuntu kernels through our normal SRU process. Please be sure to send this to upstream stable when it officially lands in Linus' tree. Given, that this appears to have minimal risk of regression and has been tested, I'll give my Ack with the assumption that it'll be landing upstream relatively soon. Acked-by: Leann Ogasawara <leann.ogasawara@canonical.com> > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index d2236c10..5e8c342 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { > { USB_DEVICE(0x0c10, 0x0000) }, > > /* Broadcom BCM20702A0 */ > + { USB_DEVICE(0x0489, 0xe042) }, > { USB_DEVICE(0x0a5c, 0x21e1) }, > { USB_DEVICE(0x0a5c, 0x21e3) }, > { USB_DEVICE(0x0a5c, 0x21e6) }, > -- > 1.7.9.5 > >
On 04/13/2012 11:55 AM, Brad Figg wrote: > On 04/13/2012 09:58 AM, manoj.iyer@canonical.com wrote: >> From: Manoj Iyer <manoj.iyer@canonical.com> >> >> T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 >> D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 >> P: Vendor=0489 ProdID=e042 Rev=01.12 >> S: Manufacturer=Broadcom Corp >> S: Product=BCM20702A0 >> S: SerialNumber=E4D53DCA61B5 >> C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA >> I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) >> I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) >> I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) >> >> Reported-by: Dennis Chua <dennis.chua@canonical.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> >> Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> >> >> BugLink: http://bugs.launchpad.net/bugs/980965 >> --- >> drivers/bluetooth/btusb.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c >> index d2236c10..5e8c342 100644 >> --- a/drivers/bluetooth/btusb.c >> +++ b/drivers/bluetooth/btusb.c >> @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { >> { USB_DEVICE(0x0c10, 0x0000) }, >> >> /* Broadcom BCM20702A0 */ >> + { USB_DEVICE(0x0489, 0xe042) }, >> { USB_DEVICE(0x0a5c, 0x21e1) }, >> { USB_DEVICE(0x0a5c, 0x21e3) }, >> { USB_DEVICE(0x0a5c, 0x21e6) }, > > Manoj, > > I'm not sure which series you want this applied to but *all* series are now > under SRU rules. > > Please look at: > https://wiki.ubuntu.com/Kernel/Dev/StablePatchFormat > > I agree that the patch itself seems safe.
Applied to Precise master-next and Oneiric master-next. Thanks, Leann On Fri, 2012-04-13 at 11:58 -0500, manoj.iyer@canonical.com wrote: > From: Manoj Iyer <manoj.iyer@canonical.com> > > T: Bus=02 Lev=02 Prnt=02 Port=04 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.00 Cls=ff(vend.) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P: Vendor=0489 ProdID=e042 Rev=01.12 > S: Manufacturer=Broadcom Corp > S: Product=BCM20702A0 > S: SerialNumber=E4D53DCA61B5 > C: #Ifs= 4 Cfg#= 1 Atr=e0 MxPwr=0mA > I: If#= 0 Alt= 0 #EPs= 3 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 1 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=01 Prot=01 Driver=(none) > I: If#= 2 Alt= 0 #EPs= 2 Cls=ff(vend.) Sub=ff Prot=ff Driver=(none) > I: If#= 3 Alt= 0 #EPs= 0 Cls=fe(app. ) Sub=01 Prot=01 Driver=(none) > > Reported-by: Dennis Chua <dennis.chua@canonical.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > Signed-off-by: Johan Hedberg <johan.hedberg@intel.com> > Signed-off-by: Manoj Iyer <manoj.iyer@canonical.com> > > BugLink: http://bugs.launchpad.net/bugs/980965 > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c > index d2236c10..5e8c342 100644 > --- a/drivers/bluetooth/btusb.c > +++ b/drivers/bluetooth/btusb.c > @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { > { USB_DEVICE(0x0c10, 0x0000) }, > > /* Broadcom BCM20702A0 */ > + { USB_DEVICE(0x0489, 0xe042) }, > { USB_DEVICE(0x0a5c, 0x21e1) }, > { USB_DEVICE(0x0a5c, 0x21e3) }, > { USB_DEVICE(0x0a5c, 0x21e6) }, > -- > 1.7.9.5 > >
diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c index d2236c10..5e8c342 100644 --- a/drivers/bluetooth/btusb.c +++ b/drivers/bluetooth/btusb.c @@ -101,6 +101,7 @@ static struct usb_device_id btusb_table[] = { { USB_DEVICE(0x0c10, 0x0000) }, /* Broadcom BCM20702A0 */ + { USB_DEVICE(0x0489, 0xe042) }, { USB_DEVICE(0x0a5c, 0x21e1) }, { USB_DEVICE(0x0a5c, 0x21e3) }, { USB_DEVICE(0x0a5c, 0x21e6) },