diff mbox

Add lcdproc config options, for driver selection

Message ID 1334143890-11880-1-git-send-email-spdawson@gmail.com
State Superseded, archived
Headers show

Commit Message

Simon Dawson April 11, 2012, 11:31 a.m. UTC
Add a configuration menu item to specify a list of lcdproc drivers to
be built. The list defaults to 'all'.

Signed-off-by: Simon Dawson <spdawson@gmail.com>
---
 package/lcdproc/Config.in  |    7 +++++++
 package/lcdproc/lcdproc.mk |    2 +-
 2 files changed, 8 insertions(+), 1 deletions(-)

Comments

Thomas Petazzoni April 11, 2012, 11:40 a.m. UTC | #1
Hello,

Le Wed, 11 Apr 2012 12:31:30 +0100,
spdawson@gmail.com a écrit :

> Add a configuration menu item to specify a list of lcdproc drivers to
> be built. The list defaults to 'all'.

Ok, I told you to wait for others comments on whether we should have
the full list (as you did initially) or this solution. I didn't want to
waste your time on this. Some comments below, though.

> +config BR2_PACKAGE_LCDPROC_DRIVERS
> +	string "List of drivers to build"
> +	default "all"
> +	help
> +	  Specify a comma-separated list of lcdproc drivers to be built
> +	depends on BR2_PACKAGE_LCDPROC

The depends on should be before the help text. It's not mandatory by
the kconfig syntax, but that's the way we use kconfig everywhere in
Buildroot.

Thomas
diff mbox

Patch

diff --git a/package/lcdproc/Config.in b/package/lcdproc/Config.in
index 6c8614d..70a2078 100644
--- a/package/lcdproc/Config.in
+++ b/package/lcdproc/Config.in
@@ -5,3 +5,10 @@  config BR2_PACKAGE_LCDPROC
          LCD display driver daemon and clients
 
          http://lcdproc.org/
+
+config BR2_PACKAGE_LCDPROC_DRIVERS
+	string "List of drivers to build"
+	default "all"
+	help
+	  Specify a comma-separated list of lcdproc drivers to be built
+	depends on BR2_PACKAGE_LCDPROC
diff --git a/package/lcdproc/lcdproc.mk b/package/lcdproc/lcdproc.mk
index e8919e9..745b386 100644
--- a/package/lcdproc/lcdproc.mk
+++ b/package/lcdproc/lcdproc.mk
@@ -7,7 +7,7 @@  LCDPROC_VERSION = 0.5.5
 LCDPROC_SOURCE = lcdproc-$(LCDPROC_VERSION).tar.gz
 LCDPROC_SITE = http://$(BR2_SOURCEFORGE_MIRROR).dl.sourceforge.net/project/lcdproc/lcdproc/$(LCDPROC_VERSION)
 
-LCDPROC_CONF_OPT = --enable-drivers=all
+LCDPROC_CONF_OPT = --enable-drivers=$(BR2_PACKAGE_LCDPROC_DRIVERS)
 
 LCDPROC_DEPENDENCIES = ncurses