| Message ID | 000001cd0c80$4ef18250$ecd486f0$@guo@arm.com |
|---|---|
| State | New |
| Headers | show |
On 03/28/2012 03:15 AM, Terry Guo wrote: > Hello, > > Thanks Paolo Carlini for pointing out that I should put code changes in > Makefile.am. This updated patch addresses this issue. Is it OK to trunk? Sure, thanks. Paolo.
> -----Original Message----- > From: Paolo Carlini [mailto:paolo.carlini@oracle.com] > Sent: Wednesday, March 28, 2012 9:15 AM > To: Terry Guo > Cc: gcc-patches@gcc.gnu.org; libstdc++@gcc.gnu.org; ro@CeBiTec.Uni- > Bielefeld.DE; mikestump@comcast.net; Richard Earnshaw; 'Paolo Bonzini' > Subject: Re: [Ping][PATCH, libstdc++-v3] Enable to cross-test libstdc++ > on simulator > > On 03/28/2012 03:15 AM, Terry Guo wrote: > > Hello, > > > > Thanks Paolo Carlini for pointing out that I should put code changes > in > > Makefile.am. This updated patch addresses this issue. Is it OK to > trunk? > Sure, thanks. > This patch was committed into trunk at March 28. And I just verified that it also works for gcc 4.7 branch and 4.6 branch. So can I back port it to 4.7 and 4.6 branch? BR, Terry
On Apr 6, 2012, at 12:50 AM, Terry Guo wrote: > This patch was committed into trunk at March 28. And I just verified that it > also works for gcc 4.7 branch and 4.6 branch. So can I back port it to 4.7 > and 4.6 branch? Ok. As always please be on the lookout for any problems.
diff --git a/libstdc++-v3/testsuite/Makefile.am b/libstdc++-v3/testsuite/Makefile.am index 166bd16..7094ad5 100644 --- a/libstdc++-v3/testsuite/Makefile.am +++ b/libstdc++-v3/testsuite/Makefile.am @@ -60,6 +60,7 @@ site.exp: Makefile @echo 'set libiconv "$(LIBICONV)"' >>site.tmp @echo 'set baseline_dir "$(baseline_dir)"' >> site.tmp @echo 'set baseline_subdir_switch "$(baseline_subdir_switch)"' >> site.tmp + @echo 'set TEST_GCC_EXEC_PREFIX "$(libdir)/gcc/"' >> site.tmp @echo '## All variables above are generated by configure. Do Not Edit ##' >>site.tmp @test ! -f site.exp || \ sed '1,/^## All variables above are.*##/ d' site.exp >> site.tmp diff --git a/libstdc++-v3/testsuite/Makefile.in b/libstdc++-v3/testsuite/Makefile.in index 8c91fd0..e433bb9 100644 --- a/libstdc++-v3/testsuite/Makefile.in +++ b/libstdc++-v3/testsuite/Makefile.in @@ -505,6 +505,7 @@ site.exp: Makefile @echo 'set libiconv "$(LIBICONV)"' >>site.tmp @echo 'set baseline_dir "$(baseline_dir)"' >> site.tmp @echo 'set baseline_subdir_switch "$(baseline_subdir_switch)"' >> site.tmp + @echo 'set TEST_GCC_EXEC_PREFIX "$(libdir)/gcc/"' >> site.tmp @echo '## All variables above are generated by configure. Do Not Edit ##' >>site.tmp
Hello, Thanks Paolo Carlini for pointing out that I should put code changes in Makefile.am. This updated patch addresses this issue. Is it OK to trunk? BR, Terry 2012-03-26 Terry Guo <terry.guo@arm.com> * testsuite/Makefile.am (TEST_GCC_EXEC_PREFIX): New. * testsuite/Makefile.in: Regenerated. @test ! -f site.exp || \ sed '1,/^## All variables above are.*##/ d' site.exp >> site.tmp