| Message ID | 1333451753-3550-7-git-send-email-pbonzini@redhat.com |
|---|---|
| State | New |
| Headers | show |
On 04/03/2012 06:15 AM, Paolo Bonzini wrote: > Since most property types do not have a parse property now, this was > broken. Fix it by looking at the setter instead. > > Signed-off-by: Paolo Bonzini<pbonzini@redhat.com> Reviewed-by: Anthony Liguori <aliguori@us.ibm.com> Regards, Anthony Liguori > --- > hw/qdev-monitor.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c > index 4783366..0acfc82 100644 > --- a/hw/qdev-monitor.c > +++ b/hw/qdev-monitor.c > @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) > * for removal. This conditional should be removed along with > * it. > */ > - if (!prop->info->parse) { > + if (!prop->info->set) { > continue; /* no way to set it, don't show */ > } > error_printf("%s.%s=%s\n", driver, prop->name, > @@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts) > } > if (info->bus_info) { > for (prop = info->bus_info->props; prop&& prop->name; prop++) { > - if (!prop->info->parse) { > + if (!prop->info->set) { > continue; /* no way to set it, don't show */ > } > error_printf("%s.%s=%s\n", driver, prop->name,
diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c index 4783366..0acfc82 100644 --- a/hw/qdev-monitor.c +++ b/hw/qdev-monitor.c @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts) * for removal. This conditional should be removed along with * it. */ - if (!prop->info->parse) { + if (!prop->info->set) { continue; /* no way to set it, don't show */ } error_printf("%s.%s=%s\n", driver, prop->name, @@ -165,7 +165,7 @@ int qdev_device_help(QemuOpts *opts) } if (info->bus_info) { for (prop = info->bus_info->props; prop && prop->name; prop++) { - if (!prop->info->parse) { + if (!prop->info->set) { continue; /* no way to set it, don't show */ } error_printf("%s.%s=%s\n", driver, prop->name,
Since most property types do not have a parse property now, this was broken. Fix it by looking at the setter instead. Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> --- hw/qdev-monitor.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)