| Message ID | 1332915722-15963-5-git-send-email-ming.m.lin@intel.com |
|---|---|
| State | Not Applicable |
| Delegated to: | David Miller |
| Headers | show |
Hello. On 28-03-2012 10:21, Lin Ming wrote: > Add a new flag ATA_DFLAG_DA to indicate that device supports "Device > Attention". > Acked-by: Aaron Lu<aaron.lu@amd.com> > Signed-off-by: Lin Ming<ming.m.lin@intel.com> [...] > diff --git a/include/linux/ata.h b/include/linux/ata.h > index 32df2b6..6ee41cc 100644 > --- a/include/linux/ata.h > +++ b/include/linux/ata.h > @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) > ((u64) (id)[(n) + 0]) ) > > #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) > +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) We prefix these macros with 'ata_' despite them being applied to IDENTIFY DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example, applies only to IDENTIFY PAKCET DEVICE data. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2012-03-28 at 15:22 +0400, Sergei Shtylyov wrote: > Hello. > > On 28-03-2012 10:21, Lin Ming wrote: > > > Add a new flag ATA_DFLAG_DA to indicate that device supports "Device > > Attention". > > > Acked-by: Aaron Lu<aaron.lu@amd.com> > > Signed-off-by: Lin Ming<ming.m.lin@intel.com> > [...] > > > diff --git a/include/linux/ata.h b/include/linux/ata.h > > index 32df2b6..6ee41cc 100644 > > --- a/include/linux/ata.h > > +++ b/include/linux/ata.h > > @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) > > ((u64) (id)[(n) + 0]) ) > > > > #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) > > +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) > > We prefix these macros with 'ata_' despite them being applied to IDENTIFY > DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example, > applies only to IDENTIFY PAKCET DEVICE data. OK, will change it. > > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello. On 29-03-2012 9:06, Lin Ming wrote: >>> Add a new flag ATA_DFLAG_DA to indicate that device supports "Device >>> Attention". >>> Acked-by: Aaron Lu<aaron.lu@amd.com> >>> Signed-off-by: Lin Ming<ming.m.lin@intel.com> >> [...] >>> diff --git a/include/linux/ata.h b/include/linux/ata.h >>> index 32df2b6..6ee41cc 100644 >>> --- a/include/linux/ata.h >>> +++ b/include/linux/ata.h >>> @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) >>> ((u64) (id)[(n) + 0]) ) >>> >>> #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) >>> +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) >> We prefix these macros with 'ata_' despite them being applied to IDENTIFY >> DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for example, >> applies only to IDENTIFY PAKCET DEVICE data. > OK, will change it. Also, what does the word "detech" mean in the subject? MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Mar 29, 2012 at 7:14 PM, Sergei Shtylyov <sshtylyov@mvista.com> wrote: > Hello. > > > On 29-03-2012 9:06, Lin Ming wrote: > >>>> Add a new flag ATA_DFLAG_DA to indicate that device supports "Device >>>> Attention". > > >>>> Acked-by: Aaron Lu<aaron.lu@amd.com> >>>> Signed-off-by: Lin Ming<ming.m.lin@intel.com> >>> >>> [...] > > >>>> diff --git a/include/linux/ata.h b/include/linux/ata.h >>>> index 32df2b6..6ee41cc 100644 >>>> --- a/include/linux/ata.h >>>> +++ b/include/linux/ata.h >>>> @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) >>>> ((u64) (id)[(n) + 0]) ) >>>> >>>> #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG]& 0x60) == 0x20) >>>> +#define atapi_id_has_da(id) ((id)[77]& (1<< 4)) > > >>> We prefix these macros with 'ata_' despite them being applied to >>> IDENTIFY >>> DEVICE data or IDENTIFY PAKCET DEVICE data. ata_id_cdb_intr(), for >>> example, >>> applies only to IDENTIFY PAKCET DEVICE data. > > >> OK, will change it. > > > Also, what does the word "detech" mean in the subject? Typo! It should be "detect" > > > MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 6742cc4..2a10701 100644 --- a/drivers/ata/libata-core.c +++ b/drivers/ata/libata-core.c @@ -2368,6 +2368,9 @@ int ata_dev_configure(struct ata_device *dev) dma_dir_string = ", DMADIR"; } + if (atapi_id_has_da(dev->id)) + dev->flags |= ATA_DFLAG_DA; + /* print device info to dmesg */ if (ata_msg_drv(ap) && print_info) ata_dev_info(dev, diff --git a/include/linux/ata.h b/include/linux/ata.h index 32df2b6..6ee41cc 100644 --- a/include/linux/ata.h +++ b/include/linux/ata.h @@ -578,6 +578,7 @@ static inline int ata_is_data(u8 prot) ((u64) (id)[(n) + 0]) ) #define ata_id_cdb_intr(id) (((id)[ATA_ID_CONFIG] & 0x60) == 0x20) +#define atapi_id_has_da(id) ((id)[77] & (1 << 4)) static inline bool ata_id_has_hipm(const u16 *id) { diff --git a/include/linux/libata.h b/include/linux/libata.h index 36970c6..3085bdc 100644 --- a/include/linux/libata.h +++ b/include/linux/libata.h @@ -161,6 +161,8 @@ enum { ATA_DFLAG_DETACH = (1 << 24), ATA_DFLAG_DETACHED = (1 << 25), + ATA_DFLAG_DA = (1 << 26), /* device supports Device Attention */ + ATA_DEV_UNKNOWN = 0, /* unknown device */ ATA_DEV_ATA = 1, /* ATA device */ ATA_DEV_ATA_UNSUP = 2, /* ATA device (unsupported) */