| Message ID | 1331577011.2680.2.camel@gnopaine |
|---|---|
| State | New |
| Headers | show |
"William J. Schmidt" <wschmidt@linux.vnet.ibm.com> writes: > Index: gcc/testsuite/gcc.target/powerpc/pr46728-13.c > =================================================================== > --- gcc/testsuite/gcc.target/powerpc/pr46728-13.c (revision 185247) > +++ gcc/testsuite/gcc.target/powerpc/pr46728-13.c (working copy) > @@ -1,4 +1,5 @@ > -/* { dg-do run } */ > +/* { dg-do run { target { powerpc*-*-* } } } */ Why is the target necessary? gcc.target/powerpc is only run on powerpc*-*-* or rs6000-*-*-* anyway (cf. powerpc.exp). > +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ Please omit defaults to dg-skip-if: { "*" } { "" } are unnecessary and make the directive harder to read. Thanks. Rainer
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes: >> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ > > Please omit defaults to dg-skip-if: { "*" } { "" } are unnecessary and > make the directive harder to read. Oh, I forgot: please indicate why you are skipping the test in the comment field, like: /* { dg-skip-if "PR tree-optimization/46728" { powerpc*-*-darwin* } } */ Thanks. Rainer
On Mar 12, 2012, at 11:40 AM, Rainer Orth wrote: > Oh, I forgot: please indicate why you are skipping the test in the > comment field, like: > > /* { dg-skip-if "PR tree-optimization/46728" { powerpc*-*-darwin* } } */ "-mpowerpc-gpopt unsupported" is arguably a better comment, as one can see this, and know that any testcase for darwin that tries to use that option is likely to not work for the same reasons. The PR can be had from the svn log (blame) for the line.
OK, will do. I just copied the style of some other test cases that skipped darwin, assuming that was the preferred syntax. Thanks, Bill On Mon, 2012-03-12 at 19:40 +0100, Rainer Orth wrote: > Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes: > > >> +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ > > > > Please omit defaults to dg-skip-if: { "*" } { "" } are unnecessary and > > make the directive harder to read. > > Oh, I forgot: please indicate why you are skipping the test in the > comment field, like: > > /* { dg-skip-if "PR tree-optimization/46728" { powerpc*-*-darwin* } } */ > > Thanks. > Rainer >
"William J. Schmidt" <wschmidt@linux.vnet.ibm.com> writes: > OK, will do. I just copied the style of some other test cases that > skipped darwin, assuming that was the preferred syntax. No problem, I'll probably make a pass over the whole testsuite to remove that cruft to avoid misleading others. Rainer
Index: gcc/testsuite/gcc.target/powerpc/pr46728-13.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-13.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-13.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-14.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-14.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-14.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-4.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-4.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-4.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do compile } */ +/* { dg-do compile { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-15.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-15.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-15.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-5.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-5.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-5.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do compile } */ +/* { dg-do compile { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-10.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-10.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-10.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-8.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-8.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-8.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do compile } */ +/* { dg-do compile { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h> Index: gcc/testsuite/gcc.target/powerpc/pr46728-11.c =================================================================== --- gcc/testsuite/gcc.target/powerpc/pr46728-11.c (revision 185247) +++ gcc/testsuite/gcc.target/powerpc/pr46728-11.c (working copy) @@ -1,4 +1,5 @@ -/* { dg-do run } */ +/* { dg-do run { target { powerpc*-*-* } } } */ +/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */ /* { dg-options "-O2 -ffast-math -fno-inline -fno-unroll-loops -lm -mpowerpc-gpopt" } */ #include <math.h>