| Message ID | 1330444295-8859-3-git-send-email-stefano.stabellini@eu.citrix.com |
|---|---|
| State | New |
| Headers | show |
On 28/02/12 15:51, Stefano Stabellini wrote: > Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. > > Signed-off-by: Stefano Stabellini<stefano.stabellini@eu.citrix.com> Acked-by: Anthony PERARD <anthony.perard@citrix.com>
On Tue, 28 Feb 2012 15:51:32 +0000 Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote: > Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> Would be nice to explain why, but I suggested this myself so: Acked-by: Luiz Capitulino <lcapitulino@redhat.com> > --- > vl.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/vl.c b/vl.c > index 5b2b84c..341775b 100644 > --- a/vl.c > +++ b/vl.c > @@ -3099,6 +3099,7 @@ int main(int argc, char **argv, char **envp) > break; > case QEMU_OPTION_incoming: > incoming = optarg; > + runstate_set(RUN_STATE_INMIGRATE); > break; > case QEMU_OPTION_nodefaults: > default_serial = 0; > @@ -3596,7 +3597,6 @@ int main(int argc, char **argv, char **envp) > } > > if (incoming) { > - runstate_set(RUN_STATE_INMIGRATE); > int ret = qemu_start_incoming_migration(incoming); > if (ret < 0) { > fprintf(stderr, "Migration failed. Exit code %s(%d), exiting.\n",
On Wed, 7 Mar 2012, Luiz Capitulino wrote: > On Tue, 28 Feb 2012 15:51:32 +0000 > Stefano Stabellini <stefano.stabellini@eu.citrix.com> wrote: > > > Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. > > > > Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > > Would be nice to explain why, but I suggested this myself so: > > Acked-by: Luiz Capitulino <lcapitulino@redhat.com> Thanks! It would be nice if somebody took the time to review patch #1 and #2 too considering that they have been sitting there for a while...
diff --git a/vl.c b/vl.c index 5b2b84c..341775b 100644 --- a/vl.c +++ b/vl.c @@ -3099,6 +3099,7 @@ int main(int argc, char **argv, char **envp) break; case QEMU_OPTION_incoming: incoming = optarg; + runstate_set(RUN_STATE_INMIGRATE); break; case QEMU_OPTION_nodefaults: default_serial = 0; @@ -3596,7 +3597,6 @@ int main(int argc, char **argv, char **envp) } if (incoming) { - runstate_set(RUN_STATE_INMIGRATE); int ret = qemu_start_incoming_migration(incoming); if (ret < 0) { fprintf(stderr, "Migration failed. Exit code %s(%d), exiting.\n",
Set runstate to RUN_STATE_INMIGRATE as soon as we can on resume. Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> --- vl.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)