Message ID | ZvEaHWH0IndyeMvs@shikoro |
---|---|
State | Accepted |
Delegated to: | Wolfram Sang |
Headers | show |
Series | [PULL,REQUEST] i2c-for-6.12-rc1 | expand |
On Mon, 23 Sept 2024 at 00:35, Wolfram Sang <wsa@kernel.org> wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git tags/i2c-for-6.12-rc1 What is it with people this merge window? > The Intel LJCA driver loses "target_addr" parameter in > ljca_i2c_stop() because it was unused. [..] > Still in the iMX/MXC driver a comma ',' has been replaced by a > semicolon ';', while in different drivers the ',' has been > removed from the '{ }' delimiters. Stop describing pointless noise. The pull request - and the resulting merge message - is about USEFUL INFORMATION. The above is just pure noise. You're literally hiding all the useful stuff by overwhelming people with totally uninteresting stuff that matters not at all. I edited things down a bit, but I shouldn't need to wade through this kind of pointless verbiage. I want a useful *summary* of what has happened, and what I'm getting. Not some line-by-line "I changed a character". Is this some broken attempt at AI summary? Because it sure isn't real intelligence. Linus
The pull request you sent on Mon, 23 Sep 2024 09:34:53 +0200:
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git tags/i2c-for-6.12-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4e2c9cd7dce6c7480f236c3ead196ff4e92ed597
Thank you!
Hi Linus, ... > > The Intel LJCA driver loses "target_addr" parameter in > > ljca_i2c_stop() because it was unused. > [..] > > Still in the iMX/MXC driver a comma ',' has been replaced by a > > semicolon ';', while in different drivers the ',' has been > > removed from the '{ }' delimiters. > > Stop describing pointless noise. The pull request - and the resulting > merge message - is about USEFUL INFORMATION. > > The above is just pure noise. You're literally hiding all the useful > stuff by overwhelming people with totally uninteresting stuff that > matters not at all. > > I edited things down a bit, but I shouldn't need to wade through this > kind of pointless verbiage. > > I want a useful *summary* of what has happened, and what I'm getting. > Not some line-by-line "I changed a character". > > Is this some broken attempt at AI summary? Because it sure isn't real > intelligence. No, it's not AI summary, of course. I tried to be as more specific as I could in the description. I'll keep your message in mind for the next time and compare the way you reworded the git description with my version. Thanks, Andi
> Stop describing pointless noise. The pull request - and the resulting > merge message - is about USEFUL INFORMATION. Noted, accepted. We will do better in the future... > Is this some broken attempt at AI summary? Because it sure isn't real > intelligence. ... but this comment is too much. We have a new maintainer here (Andi) trying very hard to get up to speed. And one maintainer who could have known better (me), sending this pull request a little hastly during the short time I had during my holidays. So, the pull request looked like this because we *are* humans, and not because we are not humans.
On Tue, 24 Sept 2024 at 07:24, Wolfram Sang <wsa+renesas@sang-engineering.com> wrote: > > ... but this comment is too much. We have a new maintainer here (Andi) > trying very hard to get up to speed. Ahh. That wasn't obvious, since the email - and the tag - were from you, and I was like "what the heck happened?" Sorry to Andi, but yeah, what I want in the pull (and thus the merge commit message) is a useful summary overview. If it's two commits, and one of them is a typo fix and the other moves code around, then by all means say "fix typo and reorganize code" for that. But when it's 50 commits, and it has major changes to some area, the typo fixes etc aren't worth mentioning individually, and can just go under some general "And the usual misc cleanups" heading. Linus