| Message ID | 20240524061411.341599-7-sunilvl@ventanamicro.com |
|---|---|
| State | New |
| Headers | show |
| Series | Add support for RISC-V ACPI tests | expand |
Hi Sunil, On 24/5/24 08:14, Sunil V L wrote: > Since virt is a common machine name across architectures like ARM64 and > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > RISC-V tables can be added under riscv64 folder in future. > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > --- > tests/data/acpi/virt/{ => aarch64}/APIC | Bin The usual pattern is {target}/{machine}, so instead of: microvm/ pc/ q35/ virt/aarch64/ virt/riscv64/ (which is odd because q35 is the x86 'virt'), I'd rather see: x86/microvm/ x86/pc/ x86/q35/ aarch64/virt/ riscv64/virt/ Anyhow just my 2 cents, up to the ACPI maintainers :) Regards, Phil.
On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > Hi Sunil, > > On 24/5/24 08:14, Sunil V L wrote: > > Since virt is a common machine name across architectures like ARM64 and > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > RISC-V tables can be added under riscv64 folder in future. > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > --- > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > The usual pattern is {target}/{machine}, so instead of: > > microvm/ > pc/ > q35/ > virt/aarch64/ > virt/riscv64/ > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > x86/microvm/ > x86/pc/ > x86/q35/ > aarch64/virt/ > riscv64/virt/ > > Anyhow just my 2 cents, up to the ACPI maintainers :) > Hi Phil, Your suggestion does make sense to me. Let me wait for feedback from ARM/ACPI maintainers. Thanks, Sunil
On Mon, 27 May 2024 20:46:29 +0530 Sunil V L <sunilvl@ventanamicro.com> wrote: > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > Hi Sunil, > > > > On 24/5/24 08:14, Sunil V L wrote: > > > Since virt is a common machine name across architectures like ARM64 and > > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > > RISC-V tables can be added under riscv64 folder in future. > > > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > > --- > > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > > > The usual pattern is {target}/{machine}, so instead of: > > > > microvm/ > > pc/ > > q35/ > > virt/aarch64/ > > virt/riscv64/ > > > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > > > x86/microvm/ > > x86/pc/ > > x86/q35/ > > aarch64/virt/ > > riscv64/virt/ > > > > Anyhow just my 2 cents, up to the ACPI maintainers :) > > > Hi Phil, > > Your suggestion does make sense to me. Let me wait for feedback from > ARM/ACPI maintainers. I'd prefer {target}/{machine} hierarchy like Philippe suggests > Thanks, > Sunil >
On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > On Mon, 27 May 2024 20:46:29 +0530 > Sunil V L <sunilvl@ventanamicro.com> wrote: > > > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > > Hi Sunil, > > > > > > On 24/5/24 08:14, Sunil V L wrote: > > > > Since virt is a common machine name across architectures like ARM64 and > > > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > > > RISC-V tables can be added under riscv64 folder in future. > > > > > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > > > --- > > > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > > > > > The usual pattern is {target}/{machine}, so instead of: > > > > > > microvm/ > > > pc/ > > > q35/ > > > virt/aarch64/ > > > virt/riscv64/ > > > > > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > > > > > x86/microvm/ > > > x86/pc/ > > > x86/q35/ > > > aarch64/virt/ > > > riscv64/virt/ > > > > > > Anyhow just my 2 cents, up to the ACPI maintainers :) > > > > > Hi Phil, > > > > Your suggestion does make sense to me. Let me wait for feedback from > > ARM/ACPI maintainers. > > I'd prefer {target}/{machine} hierarchy like Philippe suggests Agreed. > > Thanks, > > Sunil > >
On Wed, Jun 19, 2024 at 05:20:50AM -0400, Michael S. Tsirkin wrote: > On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > > On Mon, 27 May 2024 20:46:29 +0530 > > Sunil V L <sunilvl@ventanamicro.com> wrote: > > > > > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > > > Hi Sunil, > > > > > > > > On 24/5/24 08:14, Sunil V L wrote: > > > > > Since virt is a common machine name across architectures like ARM64 and > > > > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > > > > RISC-V tables can be added under riscv64 folder in future. > > > > > > > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > > > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > > > > --- > > > > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > > > > > > > The usual pattern is {target}/{machine}, so instead of: > > > > > > > > microvm/ > > > > pc/ > > > > q35/ > > > > virt/aarch64/ > > > > virt/riscv64/ > > > > > > > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > > > > > > > x86/microvm/ > > > > x86/pc/ > > > > x86/q35/ > > > > aarch64/virt/ > > > > riscv64/virt/ > > > > > > > > Anyhow just my 2 cents, up to the ACPI maintainers :) > > > > > > > Hi Phil, > > > > > > Your suggestion does make sense to me. Let me wait for feedback from > > > ARM/ACPI maintainers. > > > > I'd prefer {target}/{machine} hierarchy like Philippe suggests > > Agreed. > Thanks for the confirmation!. Let me send the updated version soon. Moving pc/q35/microvm also under new x86 would need many changes in bios-table-test.c. So, the question is, are you ok to combine x86 changes as well in this series or prefer to it later in separate series? Thanks, Sunil
On Wed, 19 Jun 2024 23:30:35 +0530 Sunil V L <sunilvl@ventanamicro.com> wrote: > On Wed, Jun 19, 2024 at 05:20:50AM -0400, Michael S. Tsirkin wrote: > > On Wed, Jun 19, 2024 at 11:17:43AM +0200, Igor Mammedov wrote: > > > On Mon, 27 May 2024 20:46:29 +0530 > > > Sunil V L <sunilvl@ventanamicro.com> wrote: > > > > > > > On Mon, May 27, 2024 at 12:12:10PM +0200, Philippe Mathieu-Daudé wrote: > > > > > Hi Sunil, > > > > > > > > > > On 24/5/24 08:14, Sunil V L wrote: > > > > > > Since virt is a common machine name across architectures like ARM64 and > > > > > > RISC-V, move existing ARM64 ACPI tables under aarch64 folder so that > > > > > > RISC-V tables can be added under riscv64 folder in future. > > > > > > > > > > > > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com> > > > > > > Reviewed-by: Alistair Francis <alistair.francis@wdc.com> > > > > > > --- > > > > > > tests/data/acpi/virt/{ => aarch64}/APIC | Bin > > > > > > > > > > The usual pattern is {target}/{machine}, so instead of: > > > > > > > > > > microvm/ > > > > > pc/ > > > > > q35/ > > > > > virt/aarch64/ > > > > > virt/riscv64/ > > > > > > > > > > (which is odd because q35 is the x86 'virt'), I'd rather see: > > > > > > > > > > x86/microvm/ > > > > > x86/pc/ > > > > > x86/q35/ > > > > > aarch64/virt/ > > > > > riscv64/virt/ > > > > > > > > > > Anyhow just my 2 cents, up to the ACPI maintainers :) > > > > > > > > > Hi Phil, > > > > > > > > Your suggestion does make sense to me. Let me wait for feedback from > > > > ARM/ACPI maintainers. > > > > > > I'd prefer {target}/{machine} hierarchy like Philippe suggests > > > > Agreed. > > > Thanks for the confirmation!. Let me send the updated version soon. > > Moving pc/q35/microvm also under new x86 would need many changes in > bios-table-test.c. So, the question is, are you ok to combine x86 > changes as well in this series or prefer to it later in separate series? it should be fine ok to include x86 changes here as well. I'd basically split previous patch on path altering part and a 2nd adding .arch = "aarch64" then 3rd doing the same for x86 as for this patch, I'd include all blobs movement here. > > Thanks, > Sunil >
diff --git a/tests/data/acpi/virt/APIC b/tests/data/acpi/virt/aarch64/APIC similarity index 100% rename from tests/data/acpi/virt/APIC rename to tests/data/acpi/virt/aarch64/APIC diff --git a/tests/data/acpi/virt/APIC.acpihmatvirt b/tests/data/acpi/virt/aarch64/APIC.acpihmatvirt similarity index 100% rename from tests/data/acpi/virt/APIC.acpihmatvirt rename to tests/data/acpi/virt/aarch64/APIC.acpihmatvirt diff --git a/tests/data/acpi/virt/APIC.topology b/tests/data/acpi/virt/aarch64/APIC.topology similarity index 100% rename from tests/data/acpi/virt/APIC.topology rename to tests/data/acpi/virt/aarch64/APIC.topology diff --git a/tests/data/acpi/virt/DBG2 b/tests/data/acpi/virt/aarch64/DBG2 similarity index 100% rename from tests/data/acpi/virt/DBG2 rename to tests/data/acpi/virt/aarch64/DBG2 diff --git a/tests/data/acpi/virt/DSDT b/tests/data/acpi/virt/aarch64/DSDT similarity index 100% rename from tests/data/acpi/virt/DSDT rename to tests/data/acpi/virt/aarch64/DSDT diff --git a/tests/data/acpi/virt/DSDT.acpihmatvirt b/tests/data/acpi/virt/aarch64/DSDT.acpihmatvirt similarity index 100% rename from tests/data/acpi/virt/DSDT.acpihmatvirt rename to tests/data/acpi/virt/aarch64/DSDT.acpihmatvirt diff --git a/tests/data/acpi/virt/DSDT.memhp b/tests/data/acpi/virt/aarch64/DSDT.memhp similarity index 100% rename from tests/data/acpi/virt/DSDT.memhp rename to tests/data/acpi/virt/aarch64/DSDT.memhp diff --git a/tests/data/acpi/virt/DSDT.pxb b/tests/data/acpi/virt/aarch64/DSDT.pxb similarity index 100% rename from tests/data/acpi/virt/DSDT.pxb rename to tests/data/acpi/virt/aarch64/DSDT.pxb diff --git a/tests/data/acpi/virt/DSDT.topology b/tests/data/acpi/virt/aarch64/DSDT.topology similarity index 100% rename from tests/data/acpi/virt/DSDT.topology rename to tests/data/acpi/virt/aarch64/DSDT.topology diff --git a/tests/data/acpi/virt/FACP b/tests/data/acpi/virt/aarch64/FACP similarity index 100% rename from tests/data/acpi/virt/FACP rename to tests/data/acpi/virt/aarch64/FACP diff --git a/tests/data/acpi/virt/GTDT b/tests/data/acpi/virt/aarch64/GTDT similarity index 100% rename from tests/data/acpi/virt/GTDT rename to tests/data/acpi/virt/aarch64/GTDT diff --git a/tests/data/acpi/virt/HMAT.acpihmatvirt b/tests/data/acpi/virt/aarch64/HMAT.acpihmatvirt similarity index 100% rename from tests/data/acpi/virt/HMAT.acpihmatvirt rename to tests/data/acpi/virt/aarch64/HMAT.acpihmatvirt diff --git a/tests/data/acpi/virt/IORT b/tests/data/acpi/virt/aarch64/IORT similarity index 100% rename from tests/data/acpi/virt/IORT rename to tests/data/acpi/virt/aarch64/IORT diff --git a/tests/data/acpi/virt/MCFG b/tests/data/acpi/virt/aarch64/MCFG similarity index 100% rename from tests/data/acpi/virt/MCFG rename to tests/data/acpi/virt/aarch64/MCFG diff --git a/tests/data/acpi/virt/NFIT.memhp b/tests/data/acpi/virt/aarch64/NFIT.memhp similarity index 100% rename from tests/data/acpi/virt/NFIT.memhp rename to tests/data/acpi/virt/aarch64/NFIT.memhp diff --git a/tests/data/acpi/virt/PPTT b/tests/data/acpi/virt/aarch64/PPTT similarity index 100% rename from tests/data/acpi/virt/PPTT rename to tests/data/acpi/virt/aarch64/PPTT diff --git a/tests/data/acpi/virt/PPTT.acpihmatvirt b/tests/data/acpi/virt/aarch64/PPTT.acpihmatvirt similarity index 100% rename from tests/data/acpi/virt/PPTT.acpihmatvirt rename to tests/data/acpi/virt/aarch64/PPTT.acpihmatvirt diff --git a/tests/data/acpi/virt/PPTT.topology b/tests/data/acpi/virt/aarch64/PPTT.topology similarity index 100% rename from tests/data/acpi/virt/PPTT.topology rename to tests/data/acpi/virt/aarch64/PPTT.topology diff --git a/tests/data/acpi/virt/SLIT.memhp b/tests/data/acpi/virt/aarch64/SLIT.memhp similarity index 100% rename from tests/data/acpi/virt/SLIT.memhp rename to tests/data/acpi/virt/aarch64/SLIT.memhp diff --git a/tests/data/acpi/virt/SPCR b/tests/data/acpi/virt/aarch64/SPCR similarity index 100% rename from tests/data/acpi/virt/SPCR rename to tests/data/acpi/virt/aarch64/SPCR diff --git a/tests/data/acpi/virt/SRAT.acpihmatvirt b/tests/data/acpi/virt/aarch64/SRAT.acpihmatvirt similarity index 100% rename from tests/data/acpi/virt/SRAT.acpihmatvirt rename to tests/data/acpi/virt/aarch64/SRAT.acpihmatvirt diff --git a/tests/data/acpi/virt/SRAT.memhp b/tests/data/acpi/virt/aarch64/SRAT.memhp similarity index 100% rename from tests/data/acpi/virt/SRAT.memhp rename to tests/data/acpi/virt/aarch64/SRAT.memhp diff --git a/tests/data/acpi/virt/SRAT.numamem b/tests/data/acpi/virt/aarch64/SRAT.numamem similarity index 100% rename from tests/data/acpi/virt/SRAT.numamem rename to tests/data/acpi/virt/aarch64/SRAT.numamem diff --git a/tests/data/acpi/virt/SSDT.memhp b/tests/data/acpi/virt/aarch64/SSDT.memhp similarity index 100% rename from tests/data/acpi/virt/SSDT.memhp rename to tests/data/acpi/virt/aarch64/SSDT.memhp diff --git a/tests/data/acpi/virt/VIOT b/tests/data/acpi/virt/aarch64/VIOT similarity index 100% rename from tests/data/acpi/virt/VIOT rename to tests/data/acpi/virt/aarch64/VIOT