Message ID | 20240510212732.1149519-2-luca.boccassi@gmail.com |
---|---|
State | New |
Headers | show |
Series | None | expand |
Hi Luca, > Note that the webpage in the comment is not published yet, > it will be next week when the next systemd RC is tagged. > The document can be viewed right now on github at: > https://github.com/systemd/systemd/blob/main/docs/ELF_DLOPEN_METADATA.md > > But the note id is not going to change. By defining it we can then > update tools to be able to parse and display it in a user-friendly > manner. > > Signed-off-by: Luca Boccassi <bluca@debian.org> May I suggest rewording the commit message to remove the tentative bits? I'll check back for when the URL goes live and then push that, but it would be nice to have a definitive commit message at that point. Thanks! > --- > elf/elf.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/elf/elf.h b/elf/elf.h > index 1df9b59935..f1b935382f 100644 > --- a/elf/elf.h > +++ b/elf/elf.h > @@ -1340,6 +1340,10 @@ typedef struct > https://systemd.io/ELF_PACKAGE_METADATA/ */ > #define NT_FDO_PACKAGING_METADATA 0xcafe1a7e > > +/* dlopen metadata as defined on > + https://systemd.io/ELF_DLOPEN_METADATA/ */ > +#define NT_FDO_DLOPEN_METADATA 0x407c0c0a > + > /* Note section name of program property. */ > #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property" > > -- > 2.39.2 >
On Tue, 14 May 2024 at 16:48, Arjun Shankar <arjun@redhat.com> wrote: > > Hi Luca, > > > Note that the webpage in the comment is not published yet, > > it will be next week when the next systemd RC is tagged. > > The document can be viewed right now on github at: > > https://github.com/systemd/systemd/blob/main/docs/ELF_DLOPEN_METADATA.md > > > > But the note id is not going to change. By defining it we can then > > update tools to be able to parse and display it in a user-friendly > > manner. > > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > May I suggest rewording the commit message to remove the tentative > bits? I'll check back for when the URL goes live and then push that, > but it would be nice to have a definitive commit message at that > point. > > Thanks! Sure no problem, done in v2. I actually just remembered that we update systemd.io only on the final release, not on RCs, so it's still a couple of weeks away. But the URL is not going to change, it's fixed as it just generates from the github repository's content, so no need to wait. Thanks!
On Wed, 15 May 2024 at 01:12, Luca Boccassi <luca.boccassi@gmail.com> wrote: > > On Tue, 14 May 2024 at 16:48, Arjun Shankar <arjun@redhat.com> wrote: > > > > Hi Luca, > > > > > Note that the webpage in the comment is not published yet, > > > it will be next week when the next systemd RC is tagged. > > > The document can be viewed right now on github at: > > > https://github.com/systemd/systemd/blob/main/docs/ELF_DLOPEN_METADATA.md > > > > > > But the note id is not going to change. By defining it we can then > > > update tools to be able to parse and display it in a user-friendly > > > manner. > > > > > > Signed-off-by: Luca Boccassi <bluca@debian.org> > > > > May I suggest rewording the commit message to remove the tentative > > bits? I'll check back for when the URL goes live and then push that, > > but it would be nice to have a definitive commit message at that > > point. > > > > Thanks! > > Sure no problem, done in v2. I actually just remembered that we update > systemd.io only on the final release, not on RCs, so it's still a > couple of weeks away. But the URL is not going to change, it's fixed > as it just generates from the github repository's content, so no need > to wait. Thanks! Hi Arjun, The page has been published on https://systemd.io/ELF_DLOPEN_METADATA/ v2 has the updated commit message, could it be merged now please? Thanks! https://sourceware.org/pipermail/libc-alpha/2024-May/156717.html
> The page has been published on https://systemd.io/ELF_DLOPEN_METADATA/ > v2 has the updated commit message, could it be merged now please? Thanks! Hi Luca, thanks for following up on this. I've pushed both patches now. Cheers!
On Thu, 30 May 2024 at 11:41, Arjun Shankar <arjun@redhat.com> wrote: > > > The page has been published on https://systemd.io/ELF_DLOPEN_METADATA/ > > v2 has the updated commit message, could it be merged now please? Thanks! > > Hi Luca, thanks for following up on this. I've pushed both patches now. Cheers! Thank you!
diff --git a/elf/elf.h b/elf/elf.h index 1df9b59935..f1b935382f 100644 --- a/elf/elf.h +++ b/elf/elf.h @@ -1340,6 +1340,10 @@ typedef struct https://systemd.io/ELF_PACKAGE_METADATA/ */ #define NT_FDO_PACKAGING_METADATA 0xcafe1a7e +/* dlopen metadata as defined on + https://systemd.io/ELF_DLOPEN_METADATA/ */ +#define NT_FDO_DLOPEN_METADATA 0x407c0c0a + /* Note section name of program property. */ #define NOTE_GNU_PROPERTY_SECTION_NAME ".note.gnu.property"