| Message ID | 1328960705-18699-3-git-send-email-hechtb@gmail.com |
|---|---|
| State | New, archived |
| Headers | show |
Hi Bastian, Thanks for the patch. On Saturday 11 February 2012 12:45:00 Bastian Hecht wrote: > Reorders the calls to make it a bit shorter and match the calling > procedure displayed in the datasheet. Could you point me to the datasheet section in which the order is documented ? > Signed-off-by: Bastian Hecht <hechtb@gmail.com> > --- > changelog: exactly same as patch v1. > > drivers/mtd/nand/sh_flctl.c | 4 +--- > 1 files changed, 1 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c > index 93b1f74..8c97367 100644 > --- a/drivers/mtd/nand/sh_flctl.c > +++ b/drivers/mtd/nand/sh_flctl.c > @@ -525,7 +525,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned > int command, execmd_read_page_sector(mtd, page_addr); > break; > } > - empty_fifo(flctl); > if (flctl->page_size) > set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8) > > | command); > > @@ -547,7 +546,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned > int command, break; > } > > - empty_fifo(flctl); > if (flctl->page_size) { > set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8) > > | NAND_CMD_READ0); > > @@ -560,7 +558,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned > int command, goto read_normal_exit; > > case NAND_CMD_READID: > - empty_fifo(flctl); This case doesn't end up in the read_normal_exit label. The empty_fifo() call will thus be completely removed. Is that intentional ? > set_cmd_regs(mtd, command, command); > set_addr(mtd, 0, 0); > > @@ -654,6 +651,7 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned > int command, > > read_normal_exit: > writel(flctl->read_bytes, FLDTCNTR(flctl)); /* set read size */ > + empty_fifo(flctl); > start_translation(flctl); > read_fiforeg(flctl, flctl->read_bytes, 0); > wait_completion(flctl);
diff --git a/drivers/mtd/nand/sh_flctl.c b/drivers/mtd/nand/sh_flctl.c index 93b1f74..8c97367 100644 --- a/drivers/mtd/nand/sh_flctl.c +++ b/drivers/mtd/nand/sh_flctl.c @@ -525,7 +525,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command, execmd_read_page_sector(mtd, page_addr); break; } - empty_fifo(flctl); if (flctl->page_size) set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8) | command); @@ -547,7 +546,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command, break; } - empty_fifo(flctl); if (flctl->page_size) { set_cmd_regs(mtd, command, (NAND_CMD_READSTART << 8) | NAND_CMD_READ0); @@ -560,7 +558,6 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command, goto read_normal_exit; case NAND_CMD_READID: - empty_fifo(flctl); set_cmd_regs(mtd, command, command); set_addr(mtd, 0, 0); @@ -654,6 +651,7 @@ static void flctl_cmdfunc(struct mtd_info *mtd, unsigned int command, read_normal_exit: writel(flctl->read_bytes, FLDTCNTR(flctl)); /* set read size */ + empty_fifo(flctl); start_translation(flctl); read_fiforeg(flctl, flctl->read_bytes, 0); wait_completion(flctl);
Reorders the calls to make it a bit shorter and match the calling procedure displayed in the datasheet. Signed-off-by: Bastian Hecht <hechtb@gmail.com> --- changelog: exactly same as patch v1. drivers/mtd/nand/sh_flctl.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-)