| Message ID | 20240301-net-v7-0-45823597d4d4@outlook.com |
|---|---|
| Headers | show |
| Series | net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles | expand |
On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > It's hard to get the version number for each FEMAC core and it's unknown > how the version can be used. Remove them until it's really needed. > > While at it, remove SoC compatibles and only use fallback compatible. > > Signed-off-by: Yang Xiwen <forbidden405@outlook.com> > --- > drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c > index 2406263c9dd3..5a088cba7d4e 100644 > --- a/drivers/net/ethernet/hisilicon/hisi_femac.c > +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c > @@ -945,9 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) > #endif > > static const struct of_device_id hisi_femac_match[] = { > - {.compatible = "hisilicon,hisi-femac-v1",}, > - {.compatible = "hisilicon,hisi-femac-v2",}, > - {.compatible = "hisilicon,hi3516cv300-femac",}, > + {.compatible = "hisilicon,hisi-femac",}, This breaks the ABI. I explained at least twice - use SoC compatibles. ONLY. Best regards, Krzysztof
On 3/1/2024 2:48 PM, Krzysztof Kozlowski wrote: > On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> It's hard to get the version number for each FEMAC core and it's unknown >> how the version can be used. Remove them until it's really needed. >> >> While at it, remove SoC compatibles and only use fallback compatible. >> >> Signed-off-by: Yang Xiwen <forbidden405@outlook.com> >> --- >> drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(-) >> >> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c >> index 2406263c9dd3..5a088cba7d4e 100644 >> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c >> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c >> @@ -945,9 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev) >> #endif >> >> static const struct of_device_id hisi_femac_match[] = { >> - {.compatible = "hisilicon,hisi-femac-v1",}, >> - {.compatible = "hisilicon,hisi-femac-v2",}, >> - {.compatible = "hisilicon,hi3516cv300-femac",}, >> + {.compatible = "hisilicon,hisi-femac",}, > > > This breaks the ABI. I explained at least twice - use SoC compatibles. ONLY. Sorry for the misuderstanding. > > Best regards, > Krzysztof >
On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote: > From: Yang Xiwen <forbidden405@outlook.com> > > We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use > and should be removed. > That's not accurate. You don't have for platform IDs, so you basically remove ability to autoload via platform. It's fine for me, but the commit msg is just misleading. Best regards, Krzysztof
On 3/1/2024 2:50 PM, Krzysztof Kozlowski wrote: > On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote: >> From: Yang Xiwen <forbidden405@outlook.com> >> >> We already have MODULE_DEVICE_TABLE(), so this MODULE_ALIAS() has no use >> and should be removed. >> > That's not accurate. You don't have for platform IDs, so you basically > remove ability to autoload via platform. It's fine for me, but the > commit msg is just misleading. I've never heard of any distro making use of this custom alias. A generic OF based module alias is enough. > > > Best regards, > Krzysztof >
Signed-off-by: Yang Xiwen <forbidden405@outlook.com> --- Changes in v7: - dt-bindings: squash a bunch of patches to YAML conversion (Krzysztof Kozlowski) - dt-bindings: drop phy-mode->phy-connection-type conversion (Andrew Lunnm, Krzysztof Kozlowski) - driver: drop SoC compatibles - misc: some minor clean ups - driver: remove MODULE_ALIAS() - Link to v6: https://lore.kernel.org/r/20240228-net-v6-0-6d78d3d598c1@outlook.com Changes in v6: - add missing "not" in commit logs (Andrew) - rework binding changes, split it into several commits (Krzysztof Kozlowski) - Link to v5: https://lore.kernel.org/r/20240223-net-v5-0-43b22d39c013@outlook.com Changes in v5: - hisi-femac-mdio: remove clock completely (Krzysztof Kozlowski) - dt-bindings: mdio: apply comments from Krzysztof Kozlowski Changes in v4: - edit commit log to show why mdio bus clk is optional (Krzysztof Kozlowski) - add clk_bulk_disable_unprepare() during error path (Maxime Chevallier) - remove of_node_put() (Simon Horman) - remove histb-clock.h header in binding example as it's goign to be deprecated. - rearrange patches so binding comes before driver - Link to v3: https://lore.kernel.org/r/20240220-net-v3-0-b68e5b75e765@outlook.com Changes in v3: - rearrange patches to fix bot error. (Rob Herring) - rewrite commit logs (Andrew Lunn) - use clk_bulk_ APIs (Andrew Lunn) - fix uninitialization use of ret (assign to -ENODEV before goto) (Simon Horman) - Link to v2: https://lore.kernel.org/r/20240216-net-v2-0-89bd4b7065c2@outlook.com Changes in v2: - replace email. - hisi-femac: s/BUS/MACIF (Andrew Lunn) - hisi-femac: add "hisilicon,hisi-femac" compatible since the driver seems generic enough for various SoCs - hisi-femac-mdio: convert binding to YAML (Krzysztof Kozlowski) - rewrite commit logs (Krzysztof Kozlowski) - Link to v1: https://lore.kernel.org/r/20240216-net-v1-0-e0ad972cda99@outlook.com --- Yang Xiwen (9): dt-bindings: net: hisilicon-femac-mdio: convert to YAML dt-bindings: net: hisilicon,hisi-femac-mdio: remove clocks net: mdio: hisi-femac: remove clock dt-bindings: net: convert hisi-femac.txt to YAML dt-bindings: net: hisi-femac: add mandatory MDIO bus subnode dt-bindings: net: hisi-femac: add binding for Hi3798MV200 FEMAC core net: hisi_femac: remove unused compatible strings net: hisi_femac: add support for hisi_femac core on Hi3798MV200 net: hisi_femac: remove unused MODULE_ALIAS() .../bindings/net/hisilicon,hisi-femac-mdio.yaml | 39 +++++++ .../bindings/net/hisilicon,hisi-femac.yaml | 120 +++++++++++++++++++++ .../bindings/net/hisilicon-femac-mdio.txt | 22 ---- .../devicetree/bindings/net/hisilicon-femac.txt | 41 ------- drivers/net/ethernet/hisilicon/hisi_femac.c | 78 ++++++++++---- drivers/net/mdio/mdio-hisi-femac.c | 18 +--- 6 files changed, 220 insertions(+), 98 deletions(-) --- base-commit: d206a76d7d2726f3b096037f2079ce0bd3ba329b change-id: 20240216-net-9a208e17c40f Best regards,