Message ID | 20240201161258.1013664-1-andre.draszik@linaro.org |
---|---|
Headers | show |
Series | gs101 oriole: peripheral block 1 (peric1) and i2c12 support | expand |
On 01/02/2024 17:11, André Draszik wrote: > Hi, > > This patch series implements support for the 2nd connectivity > peripheral block on gs101. > This block contains an additional 6 USI, 1 I3C and 1 PWM > interfaces/busses. > > i2cdetect shows all expected devices on the one i2c bus that this patch > series enables. > Everything that's in scope in this series works also without the > clk_ignore_unused kernel command line argument. > > While working on this, I noticed the existing peric0 support for gs101 > has a couple issues. That explains why there are differences compared > to it and a separate patch series has been sent to fix up peric0 > support. > > Cheers, > Andre' > > Changes in v3: > - drop samsung,mode = <USI_V2_NONE> default assignment in patch #6 I am confused. I have "another" v3 with different changelog. Best regards, Krzysztof
Hi Krzysztof, On Wed, 2024-02-07 at 16:23 +0100, Krzysztof Kozlowski wrote: > > Changes in v3: > > - drop samsung,mode = <USI_V2_NONE> default assignment in patch #6 > > I am confused. I have "another" v3 with different changelog. You're right and I forgot to take a note of the other one when I did :-( Should I send these again, with the reroll count updated to v4? Cheers, Andre'
On Thu, 01 Feb 2024 16:11:37 +0000, André Draszik wrote: > There is an extra empty line here which doesn't exist in any of the > other cmu code blocks in this file. > > Drop it to align cmu_top with the rest of the file. > > Applied, thanks! [1/7] clk: samsung: gs-101: drop extra empty line https://git.kernel.org/krzk/linux/c/d16f237bda057b7432f8e42f86d23da2cf088a2e Best regards,
On Thu, 01 Feb 2024 16:11:39 +0000, André Draszik wrote: > CMU_PERIC1 is the clock management unit used for the peric1 block which > is used for additional USI, I3C and PWM interfaces/busses. Add support > for muxes, dividers and gates of cmu_peric1, except for > CLK_GOUT_PERIC1_IP which isn't well described in the datasheet and > which downstream also ignores (similar to cmu_peric0). > > Two clocks have been marked as CLK_IS_CRITICAL for the following > reason: > * disabling them makes it impossible to access any peric1 > registers, (including those two registers). > * disabling gout_peric1_lhm_axi_p_peric1_i_clk sometimes has the > additional effect of making the whole system unresponsive. > > [...] Applied, thanks! [3/7] clk: samsung: gs101: add support for cmu_peric1 https://git.kernel.org/krzk/linux/c/2999e786d7e9596a0057d70098e339d59d7e72f9 Best regards,
On Thu, 01 Feb 2024 16:11:41 +0000, André Draszik wrote: > Enable the cmu-peric1 clock controller. It feeds additional USI, I3C > and PWM interfaces / busses. > > Note that &sysreg_peric1 needs a clock to be able to access its > registers and now that Linux knows about this clock, we need to add it > in this commit as well so as to keep &sysreg_peric1 working, so that > the clock can be enabled as and when needed. > > [...] Applied, thanks! [5/7] arm64: dts: exynos: gs101: enable cmu-peric1 clock controller https://git.kernel.org/krzk/linux/c/7d66d98b5bf376a999df13c65bbc0aac3cc9de02 Best regards,
On Thu, 01 Feb 2024 16:11:42 +0000, André Draszik wrote: > On the gs101-oriole board, i2c bus 12 has various USB-related > controllers attached to it. > > Note the selection of the USI protocol is intentionally left for the > board dts file. > > > [...] Applied, thanks! [6/7] arm64: dts: exynos: gs101: define USI12 with I2C configuration https://git.kernel.org/krzk/linux/c/118261df42496241713cf8190535e9c90e7011f0 Best regards,
On Thu, 01 Feb 2024 16:11:43 +0000, André Draszik wrote: > This bus has three USB-related devices attached to it: > 0x25: Maxim 77759 Type-C port controller > 0x35: Maxim 20339EWB Surge protection IC > 0x36: Maxim 77759 Fuel gauge > 0x57: NXP PCA9468 Battery charger > 0x66: Maxim 77759 PMIC > 0x69: Maxim 77759 Charger > where the Maxim 77759 has multiple i2c slave addresses. > > [...] Applied, thanks! [7/7] arm64: dts: exynos: gs101: enable i2c bus 12 on gs101-oriole https://git.kernel.org/krzk/linux/c/f9555ac036e253ca99a4d6d55e7e9402b77df77d Best regards,