| Message ID | 1327995040-27152-1-git-send-email-leon@leon.nu |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
On Tue, Jan 31, 2012 at 09:30:40AM +0200, Leon Romanovsky wrote: > Document device tree binding for the tegra board with ALC5632 codec > according to datasheet functional block description. If resending please send the documentation in the same patch as you add the binding (unless that patch is complex enough to need splitting). > --- /dev/null > +++ b/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt > @@ -0,0 +1,57 @@ > +NVIDIA Tegra audio complex This should really be more detailed, mentioning the CODEC.
On Tue, Jan 31, 2012 at 13:27, Mark Brown <broonie@opensource.wolfsonmicro.com> wrote: > > On Tue, Jan 31, 2012 at 09:30:40AM +0200, Leon Romanovsky wrote: > > Document device tree binding for the tegra board with ALC5632 codec > > according to datasheet functional block description. > > If resending please send the documentation in the same patch as you add > the binding (unless that patch is complex enough to need splitting). > > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt > > @@ -0,0 +1,57 @@ > > +NVIDIA Tegra audio complex > > This should really be more detailed, mentioning the CODEC. Can it be done in followup patch ? or do I need resend them all ? -- Leon Romanovsky | Independent Linux Consultant www.leon.nu | leon@leon.nu -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, Jan 31, 2012 at 01:51:43PM +0200, Leon Romanovsky wrote: > On Tue, Jan 31, 2012 at 13:27, Mark Brown > > This should really be more detailed, mentioning the CODEC. > Can it be done in followup patch ? or do I need resend them all ? Followup.
Leon Romanovsky wrote at Tuesday, January 31, 2012 12:31 AM: > Document device tree binding for the tegra board with ALC5632 codec > according to datasheet functional block description. > diff --git a/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt > + ALC5632 pins: > + > + * SPK_OUTP > + * SPK_OUTN > + * HP_OUT_L > + * HP_OUT_R > + * AUX_OUT_P > + * AUX_OUT_N Sorry this is picky, but those are AUX_OUTP and AUX_OUTN in the block diagram in the datasheet; only 1 underscore in the name. Hmm, actually the block diagram and "pin assignment" diagram are inconsistent, e.g. AUX_OUTP+AUX_OUTN in the block diagram vs. AUX_OUT+AUX_OUTN in the pin assignment, or PHONE_N (block diagram) vs. PHONEN (pin assignments). Mark, do you care about this level of detail? I think we should use the names in the pin assignments section if we do change this patch, but I guess things are clear enough as it stands, so I'm not excessively bothered. > + * LINE_IN_L > + * LINE_IN_R > + * PHONE_P > + * PHONE_N > + * MIC1_P > + * MIC1_N > + * MIC2_P > + * MIC2_N > + * MICBIAS1
On Tue, Jan 31, 2012 at 09:52:42AM -0800, Stephen Warren wrote: > Hmm, actually the block diagram and "pin assignment" diagram are > inconsistent, e.g. AUX_OUTP+AUX_OUTN in the block diagram vs. > AUX_OUT+AUX_OUTN in the pin assignment, or PHONE_N (block diagram) vs. > PHONEN (pin assignments). > Mark, do you care about this level of detail? I think we should use the > names in the pin assignments section if we do change this patch, but I > guess things are clear enough as it stands, so I'm not excessively > bothered. Not really, especially if the datasheet doesn't agree with itself. This is the sort of thing that can vary between revisions of the datasheet anyway, so long as it's clear we should be fine.
On Tue, Jan 31, 2012 at 09:30:40AM +0200, Leon Romanovsky wrote: > Document device tree binding for the tegra board with ALC5632 codec > according to datasheet functional block description. Applied, thanks.
diff --git a/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt b/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt new file mode 100644 index 0000000..300f2da --- /dev/null +++ b/Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt @@ -0,0 +1,57 @@ +NVIDIA Tegra audio complex + +Required properties: +- compatible : "nvidia,tegra-audio-alc5632" +- nvidia,model : The user-visible name of this sound complex. +- nvidia,audio-routing : A list of the connections between audio components. + Each entry is a pair of strings, the first being the connection's sink, + the second being the connection's source. Valid names for sources and + sinks are the ALC5632's pins: + + ALC5632 pins: + + * SPK_OUTP + * SPK_OUTN + * HP_OUT_L + * HP_OUT_R + * AUX_OUT_P + * AUX_OUT_N + * LINE_IN_L + * LINE_IN_R + * PHONE_P + * PHONE_N + * MIC1_P + * MIC1_N + * MIC2_P + * MIC2_N + * MICBIAS1 + + Board connectors: + + * Headset Stereophone + * Int Spk + * Headset Mic + +- nvidia,i2s-controller : The phandle of the Tegra I2S controller +- nvidia,audio-codec : The phandle of the ALC5632 audio codec + +Example: + +sound { + compatible = "nvidia,tegra-audio-alc5632-paz00", + "nvidia,tegra-audio-alc5632"; + + nvidia,model = "Compal PAZ00"; + + nvidia,audio-routing = + "Int Spk", "SPK_OUTP", + "Int Spk", "SPK_OUTN", + "Headset Mic","MICBIAS1", + "MIC1_N", "Headset Mic", + "MIC1_P", "Headset Mic", + "Headset Stereophone", "HP_OUT_R", + "Headset Stereophone", "HP_OUT_L"; + + nvidia,i2s-controller = <&tegra_i2s1>; + nvidia,audio-codec = <&alc5632>; +};
Document device tree binding for the tegra board with ALC5632 codec according to datasheet functional block description. Signed-off-by: Leon Romanovsky <leon@leon.nu> --- .../bindings/sound/tegra-audio-alc5632.txt | 57 ++++++++++++++++++++ 1 files changed, 57 insertions(+), 0 deletions(-) create mode 100644 Documentation/devicetree/bindings/sound/tegra-audio-alc5632.txt