| Message ID | 58e24ac63a8388bb9de6be0e75cea26a1af99195.1327776641.git.marvin24@gmx.de |
|---|---|
| State | Accepted, archived |
| Headers | show |
Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM: > Add the ADT7461 temperature monitoring IC which is connected via > the DVC controller. > diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts > + adt7461@4c { > + compatible = "adt7461"; Compatible should have a vendor prefix, so "adi,adt7461".
Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren: > Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM: > > Add the ADT7461 temperature monitoring IC which is connected via > > the DVC controller. > > > > diff --git a/arch/arm/boot/dts/tegra-paz00.dts > > b/arch/arm/boot/dts/tegra-paz00.dts > > > > + adt7461@4c { > > + compatible = "adt7461"; > > Compatible should have a vendor prefix, so "adi,adt7461". you are right, that's the problem when just copy-n-paste from seaboard. On the other hand, I wonder why this worked at all, because lm90 does not contain an of_match_table yet. Is there also some "hidden" DT->platfrom_data conversion? grep adi arch/*/boot/dts/ shows the PowerPC people are also using "adi,...". I'll send an update of the series with the correction and Acked-By. Thanks Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Marc Dietrich wrote at Tuesday, January 31, 2012 4:49 AM: > Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren: > > Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM: > > > Add the ADT7461 temperature monitoring IC which is connected via > > > the DVC controller. > > > > > > diff --git a/arch/arm/boot/dts/tegra-paz00.dts > > > b/arch/arm/boot/dts/tegra-paz00.dts > > > > > > + adt7461@4c { > > > + compatible = "adt7461"; > > > > Compatible should have a vendor prefix, so "adi,adt7461". > > you are right, that's the problem when just copy-n-paste from seaboard. On the other > hand, I wonder why this worked at all, because lm90 does not contain an > of_match_table yet. Is there also some "hidden" DT->platfrom_data conversion? I2C drivers can bind in two ways: 1) Direct use of an of_match_table. 2) Use of the i2c_device_id table. In this case, the I2C or OF core strips the vendor prefix (if any) from the compatible value, and checks it against all the entries in i2c_driver.id_table. The latter is how your patch worked.
Hi Stephen, On Tuesday 31 January 2012 09:27:17 Stephen Warren wrote: > Marc Dietrich wrote at Tuesday, January 31, 2012 4:49 AM: > > Am Montag, 30. Januar 2012, 09:26:47 schrieb Stephen Warren: > > > Marc Dietrich wrote at Saturday, January 28, 2012 12:03 PM: > > > > Add the ADT7461 temperature monitoring IC which is connected via > > > > the DVC controller. > > > > > > > > diff --git a/arch/arm/boot/dts/tegra-paz00.dts > > > > b/arch/arm/boot/dts/tegra-paz00.dts > > > > > > > > + adt7461@4c { > > > > + compatible = "adt7461"; > > > > > > Compatible should have a vendor prefix, so "adi,adt7461". > > > > you are right, that's the problem when just copy-n-paste from seaboard. > > On the other hand, I wonder why this worked at all, because lm90 does > > not contain an of_match_table yet. Is there also some "hidden" > > DT->platfrom_data conversion? > I2C drivers can bind in two ways: > > 1) Direct use of an of_match_table. > > 2) Use of the i2c_device_id table. In this case, the I2C or OF core strips > the vendor prefix (if any) from the compatible value, and checks it > against all the entries in i2c_driver.id_table. > > The latter is how your patch worked. ah, thanks for the explanation. Marc -- To unsubscribe from this list: send the line "unsubscribe linux-tegra" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/arm/boot/dts/tegra-paz00.dts b/arch/arm/boot/dts/tegra-paz00.dts index f667343..f03ca40 100644 --- a/arch/arm/boot/dts/tegra-paz00.dts +++ b/arch/arm/boot/dts/tegra-paz00.dts @@ -35,6 +35,11 @@ i2c@7000d000 { clock-frequency = <400000>; + + adt7461@4c { + compatible = "adt7461"; + reg = <0x4c>; + }; }; i2s@70002800 {
Add the ADT7461 temperature monitoring IC which is connected via the DVC controller. Signed-off-by: Marc Dietrich <marvin24@gmx.de> --- arch/arm/boot/dts/tegra-paz00.dts | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)