Message ID | 20231103140051.43174-1-antoniu.miclaus@analog.com |
---|---|
State | Superseded |
Headers | show |
Series | [v5,1/2] dt-bindings: rtc: max31335: add max31335 bindings | expand |
Context | Check | Description |
---|---|---|
robh/checkpatch | success | |
robh/patch-applied | success | |
robh/dtbs-check | warning | build log |
robh/dt-meta-schema | success |
On 03/11/2023 16:00:25+0200, Antoniu Miclaus wrote: > + trickle-resistor-ohms: > + description: > + Selected resistor for trickle charger. Should be specified if trickle > + charger should be enabled. > + enum: [3000, 6000, 11000] > + > +required: > + - compatible > + - reg > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/irq.h> > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@68 { > + compatible = "adi,max31335"; > + reg = <0x68>; > + pinctrl-0 = <&rtc_nint_pins>; > + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>; > + trickle-resistor-ohms = <6000>; This example would need aux-voltage-chargeable to ensure the charger is getting enabled > + adi,tc-diode = "schottky"; > + }; > + }; > +... > -- > 2.42.0 >
On Fri, Nov 03, 2023 at 04:00:26PM +0200, Antoniu Miclaus wrote: > RTC driver for MAX31335 ±2ppm Automotive Real-Time Clock with > Integrated MEMS Resonator. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > --- > MAINTAINERS | 8 + > drivers/rtc/Kconfig | 20 ++ > drivers/rtc/Makefile | 1 + > drivers/rtc/rtc-max31335.c | 700 +++++++++++++++++++++++++++++++++++++ > 4 files changed, 729 insertions(+) > create mode 100644 drivers/rtc/rtc-max31335.c > > diff --git a/MAINTAINERS b/MAINTAINERS > index dd5de540ec0b..bc484cb997ab 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -12823,6 +12823,14 @@ F: Documentation/devicetree/bindings/hwmon/adi,max31827.yaml > F: Documentation/hwmon/max31827.rst > F: drivers/hwmon/max31827.c > > +MAX31335 RTC DRIVER > +M: Antoniu Miclaus <antoniu.miclaus@analog.com> > +L: linux-rtc@vger.kernel.org > +S: Supported > +W: https://ez.analog.com/linux-software-drivers > +F: Documentation/devicetree/bindings/rtc/adi,max31335.yaml > +F: drivers/rtc/rtc-max31335.c > + > MAX6650 HARDWARE MONITOR AND FAN CONTROLLER DRIVER > L: linux-hwmon@vger.kernel.org > S: Orphan > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > index d7502433c78a..360da13fe61b 100644 > --- a/drivers/rtc/Kconfig > +++ b/drivers/rtc/Kconfig > @@ -373,6 +373,26 @@ config RTC_DRV_MAX8997 > This driver can also be built as a module. If so, the module > will be called rtc-max8997. > > +config RTC_DRV_MAX31335 > + tristate "Analog Devices MAX31335" > + depends on I2C > + select REGMAP_I2C > + help > + If you say yes here you get support for the Analog Devices > + MAX31335. > + > + This driver can also be built as a module. If so, the module > + will be called rtc-max31335. > + > +config RTC_DRV_MAX31335_HWMON > + bool "HWMON support for Analog Devices MAX31335" > + depends on RTC_DRV_MAX31335 && HWMON > + depends on !(RTC_DRV_MAX31335=y && HWMON=m) > + default y > + help > + Say Y here if you want to expose temperature sensor data on > + rtc-max31335. CONFIG_RTC_DRV_MAX31335_HWMON is not used in the driver. What is the point of having it ? Guenter
diff --git a/Documentation/devicetree/bindings/rtc/adi,max31335.yaml b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml new file mode 100644 index 000000000000..b82a8aa67428 --- /dev/null +++ b/Documentation/devicetree/bindings/rtc/adi,max31335.yaml @@ -0,0 +1,69 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/rtc/adi,max31335.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Analog Devices MAX31335 RTC + +maintainers: + - Antoniu Miclaus <antoniu.miclaus@analog.com> + +description: + Analog Devices MAX31335 I2C RTC ±2ppm Automotive Real-Time Clock with + Integrated MEMS Resonator. + +allOf: + - $ref: rtc.yaml# + +properties: + compatible: + const: adi,max31335 + + reg: + maxItems: 1 + + interrupts: + maxItems: 1 + + "#clock-cells": + description: + RTC can be used as a clock source through its clock output pin. + const: 0 + + adi,tc-diode: + description: + Select the diode configuration for the trickle charger. + schottky - Schottky diode in series. + standard+schottky - standard diode + Schottky diode in series. + enum: [schottky, standard+schottky] + + trickle-resistor-ohms: + description: + Selected resistor for trickle charger. Should be specified if trickle + charger should be enabled. + enum: [3000, 6000, 11000] + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + #include <dt-bindings/interrupt-controller/irq.h> + i2c { + #address-cells = <1>; + #size-cells = <0>; + + rtc@68 { + compatible = "adi,max31335"; + reg = <0x68>; + pinctrl-0 = <&rtc_nint_pins>; + interrupts-extended = <&gpio1 16 IRQ_TYPE_LEVEL_HIGH>; + trickle-resistor-ohms = <6000>; + adi,tc-diode = "schottky"; + }; + }; +...