Message ID | alpine.DEB.2.01.1201172104410.2895@trent.utfs.org (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show |
> On Tue, 17 Jan 2012 at 20:13, Christian Kujau wrote: > > > > compiling today's git (mainline, a25a2b8) on powerpc32 gives: > > > > CC arch/powerpc/kernel/crash.o > > cc1: warnings being treated as errors > > /usr/local/src/linux-2.6-git/arch/powerpc/kernel/crash.c:49: error: > > ‘cpus_in_crash’ defined but not used > > make[2]: *** [arch/powerpc/kernel/crash.o] Error 1 > > make[1]: *** [arch/powerpc/kernel] Error 2 > > make: *** [sub-make] Error 2 This still happens in 3.3.0-rc1 and is fixed by the patch below. .config is here: http://nerdbynature.de/bits/3.2.0/ Thoughts? Thanks, Christian. > I could not find cpus_in_crash anywhere in the sourcetree, except for > arch/powerpc/kernel/crash.c. Moving the definition into the CONFIG_SMP > ifdef helps on my UP system, of course - not sure about other machines > though: > > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c > index 28be345..abef751 100644 > --- a/arch/powerpc/kernel/crash.c > +++ b/arch/powerpc/kernel/crash.c > @@ -46,7 +46,6 @@ > > /* This keeps a track of which one is the crashing cpu. */ > int crashing_cpu = -1; > -static atomic_t cpus_in_crash; > static int time_to_dump; > > #define CRASH_HANDLER_MAX 3 > @@ -66,6 +65,7 @@ static int handle_fault(struct pt_regs *regs) > > #ifdef CONFIG_SMP > > +static atomic_t cpus_in_crash; > void crash_ipi_callback(struct pt_regs *regs) > { > static cpumask_t cpus_state_saved = CPU_MASK_NONE; > > > Christian. > -- > BOFH excuse #272: > > Netscape has crashed > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ >
On Fri, 2012-01-20 at 16:45 -0800, Christian Kujau wrote: > > On Tue, 17 Jan 2012 at 20:13, Christian Kujau wrote: > > > > > > compiling today's git (mainline, a25a2b8) on powerpc32 gives: > > > > > > CC arch/powerpc/kernel/crash.o > > > cc1: warnings being treated as errors > > > /usr/local/src/linux-2.6-git/arch/powerpc/kernel/crash.c:49: error: > > > ‘cpus_in_crash’ defined but not used > > > make[2]: *** [arch/powerpc/kernel/crash.o] Error 1 > > > make[1]: *** [arch/powerpc/kernel] Error 2 > > > make: *** [sub-make] Error 2 > > This still happens in 3.3.0-rc1 and is fixed by the patch below. > > .config is here: http://nerdbynature.de/bits/3.2.0/ > > Thoughts? Applying now, thanks. Cheers, Ben. > Thanks, > Christian. > > > I could not find cpus_in_crash anywhere in the sourcetree, except for > > arch/powerpc/kernel/crash.c. Moving the definition into the CONFIG_SMP > > ifdef helps on my UP system, of course - not sure about other machines > > though: > > > > diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c > > index 28be345..abef751 100644 > > --- a/arch/powerpc/kernel/crash.c > > +++ b/arch/powerpc/kernel/crash.c > > @@ -46,7 +46,6 @@ > > > > /* This keeps a track of which one is the crashing cpu. */ > > int crashing_cpu = -1; > > -static atomic_t cpus_in_crash; > > static int time_to_dump; > > > > #define CRASH_HANDLER_MAX 3 > > @@ -66,6 +65,7 @@ static int handle_fault(struct pt_regs *regs) > > > > #ifdef CONFIG_SMP > > > > +static atomic_t cpus_in_crash; > > void crash_ipi_callback(struct pt_regs *regs) > > { > > static cpumask_t cpus_state_saved = CPU_MASK_NONE; > > > > > > Christian. > > -- > > BOFH excuse #272: > > > > Netscape has crashed > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ > > >
diff --git a/arch/powerpc/kernel/crash.c b/arch/powerpc/kernel/crash.c index 28be345..abef751 100644 --- a/arch/powerpc/kernel/crash.c +++ b/arch/powerpc/kernel/crash.c @@ -46,7 +46,6 @@ /* This keeps a track of which one is the crashing cpu. */ int crashing_cpu = -1; -static atomic_t cpus_in_crash; static int time_to_dump; #define CRASH_HANDLER_MAX 3 @@ -66,6 +65,7 @@ static int handle_fault(struct pt_regs *regs) #ifdef CONFIG_SMP +static atomic_t cpus_in_crash; void crash_ipi_callback(struct pt_regs *regs) { static cpumask_t cpus_state_saved = CPU_MASK_NONE;