| Message ID | 20230526184707.53781-1-jonringle@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/1] package/mbpoll: new package | expand |
Hello Jon, On Fri, 26 May 2023 14:47:07 -0400 jonringle@gmail.com wrote: > From: Jon Ringle <jringle@gridpoint.com> > > mbpoll is a tool that can be used to test communication > with modbus slave devices > > Signed-off-by: Jon Ringle <jringle@gridpoint.com> Sorry for the long delay in providing feedback to your patch. The good news is that I have applied it, with a few changes (see below). > --- > package/Config.in | 1 + > package/mbpoll/Config.in | 5 +++++ > package/mbpoll/mbpoll.hash | 3 +++ > package/mbpoll/mbpoll.mk | 11 +++++++++++ > 4 files changed, 20 insertions(+) An entry in the DEVELOPERS file was missing... and I forgot about it myself, so I fixed that up in a follow-up commit. > diff --git a/package/mbpoll/Config.in b/package/mbpoll/Config.in > new file mode 100644 > index 0000000000..b0d7be1c4d > --- /dev/null > +++ b/package/mbpoll/Config.in > @@ -0,0 +1,5 @@ > +config BR2_PACKAGE_MBPOLL > + bool "mbpoll" > + select BR2_PACKAGE_LIBMODBUS > + help > + mbpoll utility to test modbus I improved this a little bit: slightly extended description taken from the github homepage, and more importantly, URL of the upstream project, which is required in Buildroot Config.in help text. > diff --git a/package/mbpoll/mbpoll.hash b/package/mbpoll/mbpoll.hash > new file mode 100644 > index 0000000000..d72ebee7b8 > --- /dev/null > +++ b/package/mbpoll/mbpoll.hash > @@ -0,0 +1,3 @@ > +# Locally calculated > +sha256 046fdac2d88eddb71a1091a87d0a4bb23fee39595a929cde50c546dae0fbcd6d mbpoll-1.5.tar.gz > +sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYING > diff --git a/package/mbpoll/mbpoll.mk b/package/mbpoll/mbpoll.mk > new file mode 100644 > index 0000000000..e1a71bed09 > --- /dev/null > +++ b/package/mbpoll/mbpoll.mk > @@ -0,0 +1,11 @@ > +################################################################################ > +# > +# mbpoll > +# > +################################################################################ > + > +MBPOLL_VERSION = 1.5 > +MBPOLL_SITE = $(call github,epsilonrt,mbpoll,v$(MBPOLL_VERSION)) > +MBPOLL_DEPENDENCIES = libmodbus You forgot host-pkgconf in the dependencies, which is needed for mbpoll to find libmodbus. Also, you properly added the hash of COPYING in the hash file, but you forgot MBPOLL_LICENSE and MBPOLL_LICENSE_FILES. As said, I fixed up those minor details when applying. Thanks a lot for your contribution! Thomas
diff --git a/package/Config.in b/package/Config.in index 420ebaa370..cfc7c4ed91 100644 --- a/package/Config.in +++ b/package/Config.in @@ -125,6 +125,7 @@ menu "Debugging, profiling and benchmark" source "package/lttng-babeltrace/Config.in" source "package/lttng-modules/Config.in" source "package/lttng-tools/Config.in" + source "package/mbpoll/Config.in" source "package/mbw/Config.in" source "package/mcelog/Config.in" source "package/memstat/Config.in" diff --git a/package/mbpoll/Config.in b/package/mbpoll/Config.in new file mode 100644 index 0000000000..b0d7be1c4d --- /dev/null +++ b/package/mbpoll/Config.in @@ -0,0 +1,5 @@ +config BR2_PACKAGE_MBPOLL + bool "mbpoll" + select BR2_PACKAGE_LIBMODBUS + help + mbpoll utility to test modbus diff --git a/package/mbpoll/mbpoll.hash b/package/mbpoll/mbpoll.hash new file mode 100644 index 0000000000..d72ebee7b8 --- /dev/null +++ b/package/mbpoll/mbpoll.hash @@ -0,0 +1,3 @@ +# Locally calculated +sha256 046fdac2d88eddb71a1091a87d0a4bb23fee39595a929cde50c546dae0fbcd6d mbpoll-1.5.tar.gz +sha256 3972dc9744f6499f0f9b2dbf76696f2ae7ad8af9b23dde66d6af86c9dfb36986 COPYING diff --git a/package/mbpoll/mbpoll.mk b/package/mbpoll/mbpoll.mk new file mode 100644 index 0000000000..e1a71bed09 --- /dev/null +++ b/package/mbpoll/mbpoll.mk @@ -0,0 +1,11 @@ +################################################################################ +# +# mbpoll +# +################################################################################ + +MBPOLL_VERSION = 1.5 +MBPOLL_SITE = $(call github,epsilonrt,mbpoll,v$(MBPOLL_VERSION)) +MBPOLL_DEPENDENCIES = libmodbus + +$(eval $(cmake-package))