Message ID | CAK=WgbaU6vpiBGSgogYPjQNmrF-U0wk1rSXMX83DdgQa9hw5Mw@mail.gmail.com |
---|---|
State | New |
Headers | show |
Hi Ohad, On Fri, 9 Dec 2011 16:55:27 +0200 Ohad Ben-Cohen <ohad@wizery.com> wrote: > > Can you please add the following remoteproc tree to linux-next ? > > git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git for-next I have added that from today. Thanks for adding your subsystem tree as a participant of linux-next. As you may know, this is not a judgment of your code. The purpose of linux-next is for integration testing and to lower the impact of conflicts between subsystems in the next merge window. You will need to ensure that the patches/commits in your tree/series have been: * submitted under GPL v2 (or later) and include the Contributor's Signed-off-by, * posted to the relevant mailing list, * reviewed by you (or another maintainer of your subsystem tree), * successfully unit tested, and * destined for the current or next Linux merge window. Basically, this should be just what you would send to Linus (or ask him to fetch). It is allowed to be rebased if you deem it necessary.
Hi Arnd, On Mon, Dec 12, 2011 at 1:33 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > On Fri, 9 Dec 2011 16:55:27 +0200 Ohad Ben-Cohen <ohad@wizery.com> wrote: >> >> Can you please add the following remoteproc tree to linux-next ? >> >> git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git for-next > > I have added that from today. Would you like rpmsg/remoteproc to go through arm-soc or do you prefer me to send a pull request directly to Linus ? If you prefer the former (IIRC you told me you might consider it in a random ELCE hallway conversation :) then I'll send you a pull request. I'm happy either way. Thanks! Ohad.
On Wednesday 21 December 2011, Ohad Ben-Cohen wrote: > Hi Arnd, > > On Mon, Dec 12, 2011 at 1:33 AM, Stephen Rothwell <sfr@canb.auug.org.au> wrote: > > On Fri, 9 Dec 2011 16:55:27 +0200 Ohad Ben-Cohen <ohad@wizery.com> wrote: > >> > >> Can you please add the following remoteproc tree to linux-next ? > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git for-next > > > > I have added that from today. > > Would you like rpmsg/remoteproc to go through arm-soc or do you prefer > me to send a pull request directly to Linus ? > > If you prefer the former (IIRC you told me you might consider it in a > random ELCE hallway conversation :) then I'll send you a pull request. > > I'm happy either way. Either way works for me, too. Right now, I would tend to let you send it to Linus directly because I haven't looked at the latest versions of the code for some time. While I generally trust you to do the right thing there, I'm not 100% comfortable to vouch for it in the way that an Ack or pull would imply without doing a more detailed review of the latest code. I know that I promised you that review, but haven't gotten to it, sorry. I've done a 5 minute review now and it absolutely looks good to go in as far as I can tell, so I certainly don't object to you sending it to Linus for 3.3. If you think you need more Acks or if there are other reasons to have it go through arm-soc, please tell me and I'll try harder to find the time for a proper review. Arnd
On Thu, Dec 22, 2011 at 5:22 PM, Arnd Bergmann <arnd@arndb.de> wrote: > Either way works for me, too. Right now, I would tend to let you send it > to Linus directly because I haven't looked at the latest versions of the > code for some time. Directly to Linus it is then. > While I generally trust you to do the right thing > there, I'm not 100% comfortable to vouch for it in the way that an Ack > or pull would imply without doing a more detailed review of the latest > code. Sure, I fully understand. > I know that I promised you that review, but haven't gotten to it, sorry. > I've done a 5 minute review now and it absolutely looks good to go in > as far as I can tell, so I certainly don't object to you sending it > to Linus for 3.3. Thanks. > If you think you need more Acks or if there are other > reasons to have it go through arm-soc, please tell me and I'll try harder > to find the time for a proper review. I do have explicit Acks on the changes to other sub-systems, though ideally I'd be happy to have some explicit Acks on the generic code too. But I hope this should be fine. Let's try to proceed this way and see how it goes (maybe I should just tell Linus that despite the lack of explicit Acks to some of the patches, people do think this is good-to-go). Thanks! Ohad.
Hi Arnd, On Thu, Dec 22, 2011 at 5:22 PM, Arnd Bergmann <arnd@arndb.de> wrote: > If you think you need more Acks or if there are other > reasons to have it go through arm-soc, please tell me and I'll try harder > to find the time for a proper review. Any chance you could carve out some time for reviewing remoteproc and rpmsg [1] ? I hope we could either get your Acks on the patches or even have it go through arm-soc for 3.4. Thanks! Ohad. [1] git://git.kernel.org/pub/scm/linux/kernel/git/ohad/remoteproc.git rpmsg-for-3.3
On Wednesday 01 February 2012, Ohad Ben-Cohen wrote: > On Thu, Dec 22, 2011 at 5:22 PM, Arnd Bergmann <arnd@arndb.de> wrote: > > If you think you need more Acks or if there are other > > reasons to have it go through arm-soc, please tell me and I'll try harder > > to find the time for a proper review. > > Any chance you could carve out some time for reviewing remoteproc and > rpmsg [1] ? I will. > I hope we could either get your Acks on the patches or even have it go > through arm-soc for 3.4. Yes, I think it's best to have it merged through arm-soc, in case Linus is more likely to take it from there than pull from your tree. Arnd
On Wed, Feb 1, 2012 at 6:57 PM, Arnd Bergmann <arnd@arndb.de> wrote: > I will. Thanks. > Yes, I think it's best to have it merged through arm-soc, in case Linus > is more likely to take it from there than pull from your tree. Great, thanks. Ohad.