| Message ID | 1323808612-14976-1-git-send-email-u.kleine-koenig@pengutronix.de |
|---|---|
| State | New |
| Headers | show |
On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-König wrote: > *.dtb files are a build result and so should be ignored. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> > --- Acked-by: Shawn Guo <shawn.guo@linaro.org>
On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-K??nig wrote: > *.dtb files are a build result and so should be ignored. > > Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de> Should this actually be global? It looks like at least powerpc, microblaze and openrisc may generate .dtbs and I don't see any local .gitignore entries for those. Since the dtc tool itself is global (i.e., in an arch-independent scripts dir instead of somewhere arch-specific), it could be argued that other related stuff should be global too. Cheers ---Dave
On Thu, Dec 15, 2011 at 02:47:57PM +0000, Dave Martin wrote: > On Tue, Dec 13, 2011 at 09:36:52PM +0100, Uwe Kleine-K??nig wrote: > > *.dtb files are a build result and so should be ignored. > > > > Signed-off-by: Uwe Kleine-K??nig <u.kleine-koenig@pengutronix.de> > > Should this actually be global? > > It looks like at least powerpc, microblaze and openrisc may generate > .dtbs and I don't see any local .gitignore entries for those. > > Since the dtc tool itself is global (i.e., in an arch-independent > scripts dir instead of somewhere arch-specific), it could be argued that > other related stuff should be global too. hmm, I'm not convinced. The build system puts ARM dtb images only in arch/arm/boot, so IMHO they should only be ignored there. If the other arch don't .gitignore the dtb files they should get a specific entry, too. Having said that, adding a / to my patch would be the right thing to do. (i.e. +/*.dtb ) The other entries could get a slash, too. Maybe a bit over engineered. Best regards Uwe
diff --git a/arch/arm/boot/.gitignore b/arch/arm/boot/.gitignore index ce1c5ff..3c79f85 100644 --- a/arch/arm/boot/.gitignore +++ b/arch/arm/boot/.gitignore @@ -3,3 +3,4 @@ zImage xipImage bootpImage uImage +*.dtb
*.dtb files are a build result and so should be ignored. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> --- arch/arm/boot/.gitignore | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)