| Message ID | 20221128112028.58021-2-angelogioacchino.delregno@collabora.com |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | pwm-mediatek: Convert to schema and fixes | expand |
On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 146e18b5b1f4..f321c6d0fd7c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > pwm: pwm@11006000 { > compatible = "mediatek,mt7622-pwm"; > reg = <0 0x11006000 0 0x1000>; > + #pwm-cells = <2>; 3 should be possible, too. The driver does only support one polarity, so it's not really needed, but would be nice for consistency? Thierry, what's your take here? Other than that: Who would pick this up, I assume it to go via an ARM tree together with the 2nd patch in this series? Best regards Uwe
Hello, On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: > On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 146e18b5b1f4..f321c6d0fd7c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > > pwm: pwm@11006000 { > > compatible = "mediatek,mt7622-pwm"; > > reg = <0 0x11006000 0 0x1000>; > > + #pwm-cells = <2>; > > 3 should be possible, too. The driver does only support one > polarity, so it's not really needed, but would be nice for consistency? > > Thierry, what's your take here? > > Other than that: Who would pick this up, I assume it to go via an ARM > tree together with the 2nd patch in this series? The questions here are still open and both patches unapplied. :-\ Best regards Uwe
On 17/01/2023 22:39, Uwe Kleine-König wrote: > Hello, > > On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: >> On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: >>> Specify #pwm-cells on pwm@11006000 to make it actually usable. >>> >>> Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") >>> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >>> --- >>> arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> index 146e18b5b1f4..f321c6d0fd7c 100644 >>> --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi >>> @@ -435,6 +435,7 @@ uart3: serial@11005000 { >>> pwm: pwm@11006000 { >>> compatible = "mediatek,mt7622-pwm"; >>> reg = <0 0x11006000 0 0x1000>; >>> + #pwm-cells = <2>; >> >> 3 should be possible, too. The driver does only support one >> polarity, so it's not really needed, but would be nice for consistency? >> >> Thierry, what's your take here? >> >> Other than that: Who would pick this up, I assume it to go via an ARM >> tree together with the 2nd patch in this series? The DT patch should go through my tree once all questions are answered and the dt-binding patch got accpeted by PWM maintainer. Regards, Matthias > > The questions here are still open and both patches unapplied. :-\ > > Best regards > Uwe >
On Fri, Dec 02, 2022 at 07:09:32PM +0100, Uwe Kleine-König wrote: > On Mon, Nov 28, 2022 at 12:20:27PM +0100, AngeloGioacchino Del Regno wrote: > > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > index 146e18b5b1f4..f321c6d0fd7c 100644 > > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > > pwm: pwm@11006000 { > > compatible = "mediatek,mt7622-pwm"; > > reg = <0 0x11006000 0 0x1000>; > > + #pwm-cells = <2>; > > 3 should be possible, too. The driver does only support one > polarity, so it's not really needed, but would be nice for consistency? > > Thierry, what's your take here? There's little point in setting this to 3 if the driver doesn't support it. The core should catch misconfiguration, but that's more of a fail- safe and if we can just avoid this from the start by not allowing anyone to specify inversed polarity that seems like a good idea. Thierry
On 28/11/2022 12:20, AngeloGioacchino Del Regno wrote: > Specify #pwm-cells on pwm@11006000 to make it actually usable. > > Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Applied, thanks! > --- > arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > index 146e18b5b1f4..f321c6d0fd7c 100644 > --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi > +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi > @@ -435,6 +435,7 @@ uart3: serial@11005000 { > pwm: pwm@11006000 { > compatible = "mediatek,mt7622-pwm"; > reg = <0 0x11006000 0 0x1000>; > + #pwm-cells = <2>; > interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>; > clocks = <&topckgen CLK_TOP_PWM_SEL>, > <&pericfg CLK_PERI_PWM_PD>,
diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi b/arch/arm64/boot/dts/mediatek/mt7622.dtsi index 146e18b5b1f4..f321c6d0fd7c 100644 --- a/arch/arm64/boot/dts/mediatek/mt7622.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt7622.dtsi @@ -435,6 +435,7 @@ uart3: serial@11005000 { pwm: pwm@11006000 { compatible = "mediatek,mt7622-pwm"; reg = <0 0x11006000 0 0x1000>; + #pwm-cells = <2>; interrupts = <GIC_SPI 77 IRQ_TYPE_LEVEL_LOW>; clocks = <&topckgen CLK_TOP_PWM_SEL>, <&pericfg CLK_PERI_PWM_PD>,
Specify #pwm-cells on pwm@11006000 to make it actually usable. Fixes: ae457b7679c4 ("arm64: dts: mt7622: add SoC and peripheral related device nodes") Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 1 + 1 file changed, 1 insertion(+)