| Message ID | 1321361232-38664-6-git-send-email-chenwj@iis.sinica.edu.tw |
|---|---|
| State | New |
| Headers | show |
Am 15.11.2011 13:47, schrieb Chen Wei-Ren (陳韋任): > From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> > > Remove libqemu_common.a from the comment. > > Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> > --- > Makefile.objs | 7 +++---- > 1 files changed, 3 insertions(+), 4 deletions(-) > > diff --git a/Makefile.objs b/Makefile.objs > index d7a6539..64c5c24 100644 > --- a/Makefile.objs > +++ b/Makefile.objs > @@ -68,10 +68,9 @@ endif > fsdev-obj-$(CONFIG_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y)) > > ###################################################################### > -# libqemu_common.a: Target independent part of system emulation. The > -# long term path is to suppress *all* target specific code in case of > -# system emulation, i.e. a single QEMU executable should support all > -# CPUs and machines. > +# Target independent part of system emulation. The long term path is > +# to suppress *all* target specific code in case of # system emulation, Stefan, could you still fix this up, please? (stray comment sign) Andreas > +# i.e. a single QEMU executable should support all CPUs and machines. > > common-obj-y = $(block-obj-y) blockdev.o > common-obj-y += $(net-obj-y)
On Fri, Dec 9, 2011 at 11:09 AM, Andreas Färber <afaerber@suse.de> wrote: > Am 15.11.2011 13:47, schrieb Chen Wei-Ren (陳韋任): >> From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> >> >> Remove libqemu_common.a from the comment. >> >> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> >> --- >> Makefile.objs | 7 +++---- >> 1 files changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/Makefile.objs b/Makefile.objs >> index d7a6539..64c5c24 100644 >> --- a/Makefile.objs >> +++ b/Makefile.objs >> @@ -68,10 +68,9 @@ endif >> fsdev-obj-$(CONFIG_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y)) >> >> ###################################################################### >> -# libqemu_common.a: Target independent part of system emulation. The >> -# long term path is to suppress *all* target specific code in case of >> -# system emulation, i.e. a single QEMU executable should support all >> -# CPUs and machines. >> +# Target independent part of system emulation. The long term path is >> +# to suppress *all* target specific code in case of # system emulation, > > Stefan, could you still fix this up, please? (stray comment sign) Fixed, though it's the second time today I modified someone's commit before merging it and I'm feeling a little dirty: http://repo.or.cz/w/qemu/stefanha.git/commitdiff/b745d5e0c0eef709eda618020d82a283a7576820 Stefan
On Fri, Dec 9, 2011 at 11:28 AM, Stefan Hajnoczi <stefanha@gmail.com> wrote: > On Fri, Dec 9, 2011 at 11:09 AM, Andreas Färber <afaerber@suse.de> wrote: >> Am 15.11.2011 13:47, schrieb Chen Wei-Ren (陳韋任): >>> From: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> >>> >>> Remove libqemu_common.a from the comment. >>> >>> Signed-off-by: Chen Wei-Ren <chenwj@iis.sinica.edu.tw> >>> --- >>> Makefile.objs | 7 +++---- >>> 1 files changed, 3 insertions(+), 4 deletions(-) >>> >>> diff --git a/Makefile.objs b/Makefile.objs >>> index d7a6539..64c5c24 100644 >>> --- a/Makefile.objs >>> +++ b/Makefile.objs >>> @@ -68,10 +68,9 @@ endif >>> fsdev-obj-$(CONFIG_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y)) >>> >>> ###################################################################### >>> -# libqemu_common.a: Target independent part of system emulation. The >>> -# long term path is to suppress *all* target specific code in case of >>> -# system emulation, i.e. a single QEMU executable should support all >>> -# CPUs and machines. >>> +# Target independent part of system emulation. The long term path is >>> +# to suppress *all* target specific code in case of # system emulation, >> >> Stefan, could you still fix this up, please? (stray comment sign) > > Fixed, though it's the second time today I modified someone's commit > before merging it and I'm feeling a little dirty: > http://repo.or.cz/w/qemu/stefanha.git/commitdiff/b745d5e0c0eef709eda618020d82a283a7576820 Thanks to Peter Maydell for pointing out that I posted the old commit URL instead of the fixed one. Here's the fixed version in the trivial patches -next tree: http://repo.or.cz/w/qemu/stefanha.git/commitdiff/050d99402845d3c5915e3abd8aea7cc772b85b8e Stefan
diff --git a/Makefile.objs b/Makefile.objs index d7a6539..64c5c24 100644 --- a/Makefile.objs +++ b/Makefile.objs @@ -68,10 +68,9 @@ endif fsdev-obj-$(CONFIG_VIRTFS) += $(addprefix fsdev/, $(fsdev-nested-y)) ###################################################################### -# libqemu_common.a: Target independent part of system emulation. The -# long term path is to suppress *all* target specific code in case of -# system emulation, i.e. a single QEMU executable should support all -# CPUs and machines. +# Target independent part of system emulation. The long term path is +# to suppress *all* target specific code in case of # system emulation, +# i.e. a single QEMU executable should support all CPUs and machines. common-obj-y = $(block-obj-y) blockdev.o common-obj-y += $(net-obj-y)