| Message ID | 20111114054144.23410.65704.stgit@suzukikp.in.ibm.com (mailing list archive) |
|---|---|
| State | Superseded |
| Delegated to: | Josh Boyer |
| Headers | show |
On Mon, Nov 14, 2011 at 12:41 AM, Suzuki K. Poulose <suzuki@in.ibm.com> wrote: > The current implementation of CONFIG_RELOCATABLE in BookE is based > on mapping the page aligned kernel load address to KERNELBASE. This > approach however is not enough for platforms, where the TLB page size > is large (e.g, 256M on 44x). So we are renaming the RELOCATABLE used > currently in BookE to DYNAMIC_MEMSTART to reflect the actual method. > > The CONFIG_RELOCATABLE for PPC32(BookE) based on processing of the > dynamic relocations will be introduced in the later in the patch series. > > This change would allow the use of the old method of RELOCATABLE for > platforms which can afford to enforce the page alignment (platforms with > smaller TLB size). I'm OK with the general direction, but this touches a lot of non-4xx code. I'd prefer it if Ben took this directly on whatever final solution is done. > I haven tested this change only on 440x. I don't have an FSL BookE to verify > the changes there. > > Scott, > Could you please test this patch on FSL and let me know the results ? Scott, did you ever get around to testing this? In my opinion, this shouldn't go in without a Tested-by: from someone that tried it on an FSL platform. > Suggested-by: Scott Wood <scottwood@freescale.com> > > Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com> > Cc: Scott Wood <scottwood@freescale.com> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> > Cc: linux ppc dev <linuxppc-dev@lists.ozlabs.org> > --- > > arch/powerpc/Kconfig | 50 ++++++++++++++++--------- > arch/powerpc/configs/44x/iss476-smp_defconfig | 2 + > arch/powerpc/include/asm/kdump.h | 5 ++- > arch/powerpc/include/asm/page.h | 4 +- > arch/powerpc/kernel/crash_dump.c | 4 +- > arch/powerpc/kernel/head_44x.S | 4 ++ > arch/powerpc/kernel/head_fsl_booke.S | 2 + > arch/powerpc/kernel/machine_kexec.c | 2 + > arch/powerpc/kernel/prom_init.c | 2 + > arch/powerpc/mm/44x_mmu.c | 2 + > 10 files changed, 47 insertions(+), 30 deletions(-) > > diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig > index d7c2d1a..8d4f789 100644 > --- a/arch/powerpc/Kconfig > +++ b/arch/powerpc/Kconfig > @@ -363,7 +363,8 @@ config KEXEC > config CRASH_DUMP > bool "Build a kdump crash kernel" > depends on PPC64 || 6xx || FSL_BOOKE > - select RELOCATABLE if PPC64 || FSL_BOOKE > + select RELOCATABLE if PPC64 > + select DYNAMIC_MEMSTART if FSL_BOOKE > help > Build a kernel suitable for use as a kdump capture kernel. > The same kernel binary can be used as production kernel and dump > @@ -841,23 +842,36 @@ config LOWMEM_CAM_NUM > int "Number of CAMs to use to map low memory" if LOWMEM_CAM_NUM_BOOL > default 3 > > -config RELOCATABLE > - bool "Build a relocatable kernel (EXPERIMENTAL)" > +config DYNAMIC_MEMSTART OK, so my one bikeshed comment here. We add DYNAMIC_MEMSTART for 32-bit, and we have RELOCATABLE for 64-bit. Then throughout almost the rest of the patch, all we're doing is duplicating what RELOCATABLE already did (e.g. if ! either thing). It works, but it is kind of ugly. Instead, could we define a helper config variable that can be used in place of that construct? Something like: config NONSTATIC_KERNEL (or whatever) bool default n ... config DYNAMIC_MEMSTART <blah> select NONSTATIC_KERNEL ... config RELOCATABLE <blah> select NONSTATIC_KERNEL Then you can do this kind of thing: default "0x02000000" if PPC_STD_MMU && CRASH_DUMP && !(NONSTATIC_KERNEL) #if defined(CONFIG_CRASH_DUMP) && !(defined(CONFIG_NONSTATIC_KERNEL)) instead of this: default "0x02000000" if PPC_STD_MMU && CRASH_DUMP && !(RELOCATABLE || DYNAMIC_MEMSTART) #if defined(CONFIG_CRASH_DUMP) && !(defined(CONFIG_RELOCATABLE) || \ defined(CONFIG_DYNAMIC_MEMSTART)) while still allowing for differences between RELOCATABLE and DYNAMIC_MEMSTART. Thoughts? josh
On 11/23/2011 10:47 AM, Josh Boyer wrote: > On Mon, Nov 14, 2011 at 12:41 AM, Suzuki K. Poulose <suzuki@in.ibm.com> wrote: >> The current implementation of CONFIG_RELOCATABLE in BookE is based >> on mapping the page aligned kernel load address to KERNELBASE. This >> approach however is not enough for platforms, where the TLB page size >> is large (e.g, 256M on 44x). So we are renaming the RELOCATABLE used >> currently in BookE to DYNAMIC_MEMSTART to reflect the actual method. Should reword the config help to make it clear what the alignment restriction is, or where to find the information for a particular platform. Someone reading "page aligned" without any context that we're talking about special large pages is going to think 4K -- and on e500, many large page sizes are supported, so the required alignment is found in Linux init code rather than a CPU manual. >> >> The CONFIG_RELOCATABLE for PPC32(BookE) based on processing of the >> dynamic relocations will be introduced in the later in the patch series. >> >> This change would allow the use of the old method of RELOCATABLE for >> platforms which can afford to enforce the page alignment (platforms with >> smaller TLB size). > > I'm OK with the general direction, but this touches a lot of non-4xx > code. I'd prefer it if Ben took this directly on whatever final > solution is done. > >> I haven tested this change only on 440x. I don't have an FSL BookE to verify >> the changes there. >> >> Scott, >> Could you please test this patch on FSL and let me know the results ? > > Scott, did you ever get around to testing this? In my opinion, this > shouldn't go in without a Tested-by: from someone that tried it on an > FSL platform. Booted OK for me on e500v2 with RAM starting at 256M. Tested-by: Scott Wood <scottwood@freescale.com> > We add DYNAMIC_MEMSTART for 32-bit, and we have RELOCATABLE for > 64-bit. Then throughout almost the rest of the patch, all we're doing > is duplicating what RELOCATABLE already did (e.g. if ! either thing). > It works, but it is kind of ugly. > > Instead, could we define a helper config variable that can be used in > place of that construct? Something like: > > config NONSTATIC_KERNEL (or whatever) > bool > default n > > ... > > config DYNAMIC_MEMSTART > <blah> > select NONSTATIC_KERNEL > > ... > > config RELOCATABLE > <blah> > select NONSTATIC_KERNEL I agree. -Scott
On Mon, Nov 28, 2011 at 5:59 PM, Scott Wood <scottwood@freescale.com> wrote: > On 11/23/2011 10:47 AM, Josh Boyer wrote: >> On Mon, Nov 14, 2011 at 12:41 AM, Suzuki K. Poulose <suzuki@in.ibm.com> wrote: >>> The current implementation of CONFIG_RELOCATABLE in BookE is based >>> on mapping the page aligned kernel load address to KERNELBASE. This >>> approach however is not enough for platforms, where the TLB page size >>> is large (e.g, 256M on 44x). So we are renaming the RELOCATABLE used >>> currently in BookE to DYNAMIC_MEMSTART to reflect the actual method. > > Should reword the config help to make it clear what the alignment > restriction is, or where to find the information for a particular > platform. Someone reading "page aligned" without any context that we're > talking about special large pages is going to think 4K -- and on e500, > many large page sizes are supported, so the required alignment is found > in Linux init code rather than a CPU manual. > >>> >>> The CONFIG_RELOCATABLE for PPC32(BookE) based on processing of the >>> dynamic relocations will be introduced in the later in the patch series. >>> >>> This change would allow the use of the old method of RELOCATABLE for >>> platforms which can afford to enforce the page alignment (platforms with >>> smaller TLB size). >> >> I'm OK with the general direction, but this touches a lot of non-4xx >> code. I'd prefer it if Ben took this directly on whatever final >> solution is done. >> >>> I haven tested this change only on 440x. I don't have an FSL BookE to verify >>> the changes there. >>> >>> Scott, >>> Could you please test this patch on FSL and let me know the results ? >> >> Scott, did you ever get around to testing this? In my opinion, this >> shouldn't go in without a Tested-by: from someone that tried it on an >> FSL platform. > > Booted OK for me on e500v2 with RAM starting at 256M. > > Tested-by: Scott Wood <scottwood@freescale.com> > >> We add DYNAMIC_MEMSTART for 32-bit, and we have RELOCATABLE for >> 64-bit. Then throughout almost the rest of the patch, all we're doing >> is duplicating what RELOCATABLE already did (e.g. if ! either thing). >> It works, but it is kind of ugly. >> >> Instead, could we define a helper config variable that can be used in >> place of that construct? Something like: >> >> config NONSTATIC_KERNEL (or whatever) >> bool >> default n >> >> ... >> >> config DYNAMIC_MEMSTART >> <blah> >> select NONSTATIC_KERNEL >> >> ... >> >> config RELOCATABLE >> <blah> >> select NONSTATIC_KERNEL > > I agree. Suzie do you think you could respin this patch with the suggested changes and include Scott's Tested-by? The rest of the series looks fine and I'd like to get it included in my next branch. josh
On 11/30/11 20:11, Josh Boyer wrote: > On Mon, Nov 28, 2011 at 5:59 PM, Scott Wood<scottwood@freescale.com> wrote: >> On 11/23/2011 10:47 AM, Josh Boyer wrote: >>> On Mon, Nov 14, 2011 at 12:41 AM, Suzuki K. Poulose<suzuki@in.ibm.com> wrote: >>>> The current implementation of CONFIG_RELOCATABLE in BookE is based >>>> on mapping the page aligned kernel load address to KERNELBASE. This >>>> approach however is not enough for platforms, where the TLB page size >>>> is large (e.g, 256M on 44x). So we are renaming the RELOCATABLE used >>>> currently in BookE to DYNAMIC_MEMSTART to reflect the actual method. >> >> Should reword the config help to make it clear what the alignment >> restriction is, or where to find the information for a particular >> platform. Someone reading "page aligned" without any context that we're >> talking about special large pages is going to think 4K -- and on e500, >> many large page sizes are supported, so the required alignment is found >> in Linux init code rather than a CPU manual. >> >>>> >>>> The CONFIG_RELOCATABLE for PPC32(BookE) based on processing of the >>>> dynamic relocations will be introduced in the later in the patch series. >>>> >>>> This change would allow the use of the old method of RELOCATABLE for >>>> platforms which can afford to enforce the page alignment (platforms with >>>> smaller TLB size). >>> >>> I'm OK with the general direction, but this touches a lot of non-4xx >>> code. I'd prefer it if Ben took this directly on whatever final >>> solution is done. >>> >>>> I haven tested this change only on 440x. I don't have an FSL BookE to verify >>>> the changes there. >>>> >>>> Scott, >>>> Could you please test this patch on FSL and let me know the results ? >>> >>> Scott, did you ever get around to testing this? In my opinion, this >>> shouldn't go in without a Tested-by: from someone that tried it on an >>> FSL platform. >> >> Booted OK for me on e500v2 with RAM starting at 256M. >> >> Tested-by: Scott Wood<scottwood@freescale.com> >> >>> We add DYNAMIC_MEMSTART for 32-bit, and we have RELOCATABLE for >>> 64-bit. Then throughout almost the rest of the patch, all we're doing >>> is duplicating what RELOCATABLE already did (e.g. if ! either thing). >>> It works, but it is kind of ugly. >>> >>> Instead, could we define a helper config variable that can be used in >>> place of that construct? Something like: >>> >>> config NONSTATIC_KERNEL (or whatever) >>> bool >>> default n >>> >>> ... >>> >>> config DYNAMIC_MEMSTART >>> <blah> >>> select NONSTATIC_KERNEL >>> >>> ... >>> >>> config RELOCATABLE >>> <blah> >>> select NONSTATIC_KERNEL >> >> I agree. > > Suzie do you think you could respin this patch with the suggested > changes and include Scott's Tested-by? The rest of the series looks > fine and I'd like to get it included in my next branch. > Josh, I rebased my patches to 3.2.0-rc3 and was able to verify it on my QEMU setup. However I am facing problems getting the my boards booted with the network cards (even without the patches). Here is what I see : Creating 2 MTD partitions on "1ff800000.large-flash": 0x000000000000-0x000000380000 : "fs" 0x000000380000-0x000000400000 : "firmware" PPC 4xx OCP EMAC driver, version 3.54 mal0: failed to map interrupts ! ZMII /plb/opb/emac-zmii@40000780 initialized /plb/opb/ethernet@40000800: Timeout waiting for dependent devices /plb/opb/ethernet@40000900: Timeout waiting for dependent devices TCP cubic registered NET: Registered protocol family 17 Root-NFS: no NFS server address VFS: Unable to mount root fs via NFS, trying floppy. VFS: Cannot open root device "(null)" or unknown-block(2,0) Please append a correct "root=" boot option; here are the available partitions: 1f00 512 mtdblock0 (driver?) 1f01 3584 mtdblock1 (driver?) 1f02 512 mtdblock2 (driver?) Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(2,0) Have you come across this message ? Thanks Suzuki
On Wed, Dec 7, 2011 at 7:40 AM, Suzuki Poulose <suzuki@in.ibm.com> wrote: > Josh, > > I rebased my patches to 3.2.0-rc3 and was able to verify it on my QEMU > setup. > However I am facing problems getting the my boards booted with the network > cards > (even without the patches). Here is what I see : > > > Creating 2 MTD partitions on "1ff800000.large-flash": > 0x000000000000-0x000000380000 : "fs" > 0x000000380000-0x000000400000 : "firmware" > PPC 4xx OCP EMAC driver, version 3.54 > mal0: failed to map interrupts ! That's the problem. There was a bogus commit that was added to the generic OF code that prevented the normal mapping that the MAL nodes do from working. It was later reverted after Benh told Linus it was bogus. I don't remember which -rc that wound up in, but if you move to 3.2-rc4 that should help. josh
diff --git a/arch/powerpc/Kconfig b/arch/powerpc/Kconfig index d7c2d1a..8d4f789 100644 --- a/arch/powerpc/Kconfig +++ b/arch/powerpc/Kconfig @@ -363,7 +363,8 @@ config KEXEC config CRASH_DUMP bool "Build a kdump crash kernel" depends on PPC64 || 6xx || FSL_BOOKE - select RELOCATABLE if PPC64 || FSL_BOOKE + select RELOCATABLE if PPC64 + select DYNAMIC_MEMSTART if FSL_BOOKE help Build a kernel suitable for use as a kdump capture kernel. The same kernel binary can be used as production kernel and dump @@ -841,23 +842,36 @@ config LOWMEM_CAM_NUM int "Number of CAMs to use to map low memory" if LOWMEM_CAM_NUM_BOOL default 3 -config RELOCATABLE - bool "Build a relocatable kernel (EXPERIMENTAL)" +config DYNAMIC_MEMSTART + bool "Enable page aligned dynamic load address for kernel (EXPERIMENTAL)" depends on EXPERIMENTAL && ADVANCED_OPTIONS && FLATMEM && (FSL_BOOKE || PPC_47x) help - This builds a kernel image that is capable of running at the - location the kernel is loaded at (some alignment restrictions may - exist). - - One use is for the kexec on panic case where the recovery kernel - must live at a different physical address than the primary - kernel. - - Note: If CONFIG_RELOCATABLE=y, then the kernel runs from the address - it has been loaded at and the compile time physical addresses - CONFIG_PHYSICAL_START is ignored. However CONFIG_PHYSICAL_START - setting can still be useful to bootwrappers that need to know the - load location of the kernel (eg. u-boot/mkimage). + This option enables the kernel to be loaded at any page aligned + physical address. The kernel creates a mapping from KERNELBASE to + the address where the kernel is loaded. + + DYNAMIC_MEMSTART is an easy way of implementing pseudo-RELOCATABLE + kernel image, where the only restriction is the page aligned kernel + load address. When this option is enabled, the compile time physical + address CONFIG_PHYSICAL_START is ignored. + +# Mapping based RELOCATABLE is moved to DYNAMIC_MEMSTART +# config RELOCATABLE +# bool "Build a relocatable kernel (EXPERIMENTAL)" +# depends on EXPERIMENTAL && ADVANCED_OPTIONS && FLATMEM && (FSL_BOOKE || PPC_47x) +# help +# This builds a kernel image that is capable of running at the +# location the kernel is loaded at, without any alignment restrictions. +# +# One use is for the kexec on panic case where the recovery kernel +# must live at a different physical address than the primary +# kernel. +# +# Note: If CONFIG_RELOCATABLE=y, then the kernel runs from the address +# it has been loaded at and the compile time physical addresses +# CONFIG_PHYSICAL_START is ignored. However CONFIG_PHYSICAL_START +# setting can still be useful to bootwrappers that need to know the +# load location of the kernel (eg. u-boot/mkimage). config PAGE_OFFSET_BOOL bool "Set custom page offset address" @@ -887,7 +901,7 @@ config KERNEL_START_BOOL config KERNEL_START hex "Virtual address of kernel base" if KERNEL_START_BOOL default PAGE_OFFSET if PAGE_OFFSET_BOOL - default "0xc2000000" if CRASH_DUMP && !RELOCATABLE + default "0xc2000000" if CRASH_DUMP && !(RELOCATABLE || DYNAMIC_MEMSTART) default "0xc0000000" config PHYSICAL_START_BOOL @@ -900,7 +914,7 @@ config PHYSICAL_START_BOOL config PHYSICAL_START hex "Physical address where the kernel is loaded" if PHYSICAL_START_BOOL - default "0x02000000" if PPC_STD_MMU && CRASH_DUMP && !RELOCATABLE + default "0x02000000" if PPC_STD_MMU && CRASH_DUMP && !(RELOCATABLE || DYNAMIC_MEMSTART) default "0x00000000" config PHYSICAL_ALIGN diff --git a/arch/powerpc/configs/44x/iss476-smp_defconfig b/arch/powerpc/configs/44x/iss476-smp_defconfig index a6eb6ad..122043e 100644 --- a/arch/powerpc/configs/44x/iss476-smp_defconfig +++ b/arch/powerpc/configs/44x/iss476-smp_defconfig @@ -25,7 +25,7 @@ CONFIG_CMDLINE_BOOL=y CONFIG_CMDLINE="root=/dev/issblk0" # CONFIG_PCI is not set CONFIG_ADVANCED_OPTIONS=y -CONFIG_RELOCATABLE=y +CONFIG_DYNAMIC_MEMSTART=y CONFIG_NET=y CONFIG_PACKET=y CONFIG_UNIX=y diff --git a/arch/powerpc/include/asm/kdump.h b/arch/powerpc/include/asm/kdump.h index bffd062..5d052e5 100644 --- a/arch/powerpc/include/asm/kdump.h +++ b/arch/powerpc/include/asm/kdump.h @@ -32,11 +32,12 @@ #ifndef __ASSEMBLY__ -#if defined(CONFIG_CRASH_DUMP) && !defined(CONFIG_RELOCATABLE) +#if defined(CONFIG_CRASH_DUMP) && !(defined(CONFIG_RELOCATABLE) || \ + defined(CONFIG_DYNAMIC_MEMSTART)) extern void reserve_kdump_trampoline(void); extern void setup_kdump_trampoline(void); #else -/* !CRASH_DUMP || RELOCATABLE */ +/* !CRASH_DUMP || RELOCATABLE || DYNAMIC_MEMSTART */ static inline void reserve_kdump_trampoline(void) { ; } static inline void setup_kdump_trampoline(void) { ; } #endif diff --git a/arch/powerpc/include/asm/page.h b/arch/powerpc/include/asm/page.h index dd9c4fd..97cfe86 100644 --- a/arch/powerpc/include/asm/page.h +++ b/arch/powerpc/include/asm/page.h @@ -92,7 +92,7 @@ extern unsigned int HPAGE_SHIFT; #define PAGE_OFFSET ASM_CONST(CONFIG_PAGE_OFFSET) #define LOAD_OFFSET ASM_CONST((CONFIG_KERNEL_START-CONFIG_PHYSICAL_START)) -#if defined(CONFIG_RELOCATABLE) +#if defined(CONFIG_RELOCATABLE) || defined(CONFIG_DYNAMIC_MEMSTART) #ifndef __ASSEMBLY__ extern phys_addr_t memstart_addr; @@ -105,7 +105,7 @@ extern phys_addr_t kernstart_addr; #ifdef CONFIG_PPC64 #define MEMORY_START 0UL -#elif defined(CONFIG_RELOCATABLE) +#elif defined(CONFIG_RELOCATABLE) || defined(CONFIG_DYNAMIC_MEMSTART) #define MEMORY_START memstart_addr #else #define MEMORY_START (PHYSICAL_START + PAGE_OFFSET - KERNELBASE) diff --git a/arch/powerpc/kernel/crash_dump.c b/arch/powerpc/kernel/crash_dump.c index 424afb6..d9696ae 100644 --- a/arch/powerpc/kernel/crash_dump.c +++ b/arch/powerpc/kernel/crash_dump.c @@ -28,7 +28,7 @@ #define DBG(fmt...) #endif -#ifndef CONFIG_RELOCATABLE +#if !defined(CONFIG_RELOCATABLE) && !defined(CONFIG_DYNAMIC_MEMSTART) void __init reserve_kdump_trampoline(void) { memblock_reserve(0, KDUMP_RESERVE_LIMIT); @@ -67,7 +67,7 @@ void __init setup_kdump_trampoline(void) DBG(" <- setup_kdump_trampoline()\n"); } -#endif /* CONFIG_RELOCATABLE */ +#endif /* !CONFIG_RELOCATABLE && !CONFIG_DYNAMIC_MEMSTART */ static int __init parse_savemaxmem(char *p) { diff --git a/arch/powerpc/kernel/head_44x.S b/arch/powerpc/kernel/head_44x.S index b725dab..d5f787d 100644 --- a/arch/powerpc/kernel/head_44x.S +++ b/arch/powerpc/kernel/head_44x.S @@ -86,8 +86,10 @@ _ENTRY(_start); bl early_init -#ifdef CONFIG_RELOCATABLE +#ifdef CONFIG_DYNAMIC_MEMSTART /* + * Mapping based, page aligned dyanmic kernel loading. + * * r25 will contain RPN/ERPN for the start address of memory * * Add the difference between KERNELBASE and PAGE_OFFSET to the diff --git a/arch/powerpc/kernel/head_fsl_booke.S b/arch/powerpc/kernel/head_fsl_booke.S index e1c699f..713284c 100644 --- a/arch/powerpc/kernel/head_fsl_booke.S +++ b/arch/powerpc/kernel/head_fsl_booke.S @@ -197,7 +197,7 @@ _ENTRY(__early_start) bl early_init -#ifdef CONFIG_RELOCATABLE +#ifdef CONFIG_DYNAMIC_MEMSTART lis r3,kernstart_addr@ha la r3,kernstart_addr@l(r3) #ifdef CONFIG_PHYS_64BIT diff --git a/arch/powerpc/kernel/machine_kexec.c b/arch/powerpc/kernel/machine_kexec.c index 9ce1672..a4a4c9e 100644 --- a/arch/powerpc/kernel/machine_kexec.c +++ b/arch/powerpc/kernel/machine_kexec.c @@ -128,7 +128,7 @@ void __init reserve_crashkernel(void) crash_size = resource_size(&crashk_res); -#ifndef CONFIG_RELOCATABLE +#if !defined(CONFIG_RELOCATABLE) && !defined(CONFIG_DYNAMIC_MEMSTART) if (crashk_res.start != KDUMP_KERNELBASE) printk("Crash kernel location must be 0x%x\n", KDUMP_KERNELBASE); diff --git a/arch/powerpc/kernel/prom_init.c b/arch/powerpc/kernel/prom_init.c index b4fa661..a2a0479 100644 --- a/arch/powerpc/kernel/prom_init.c +++ b/arch/powerpc/kernel/prom_init.c @@ -2846,7 +2846,7 @@ unsigned long __init prom_init(unsigned long r3, unsigned long r4, RELOC(of_platform) = prom_find_machine_type(); prom_printf("Detected machine type: %x\n", RELOC(of_platform)); -#ifndef CONFIG_RELOCATABLE +#if !defined(CONFIG_RELOCATABLE) && !defined(CONFIG_DYNAMIC_MEMSTART) /* Bail if this is a kdump kernel. */ if (PHYSICAL_START > 0) prom_panic("Error: You can't boot a kdump kernel from OF!\n"); diff --git a/arch/powerpc/mm/44x_mmu.c b/arch/powerpc/mm/44x_mmu.c index f60e006..ae6ac7a 100644 --- a/arch/powerpc/mm/44x_mmu.c +++ b/arch/powerpc/mm/44x_mmu.c @@ -221,7 +221,7 @@ void setup_initial_memory_limit(phys_addr_t first_memblock_base, { u64 size; -#ifndef CONFIG_RELOCATABLE +#if !defined(CONFIG_RELOCATABLE) && !defined(CONFIG_DYNAMIC_MEMSTART) /* We don't currently support the first MEMBLOCK not mapping 0 * physical on those processors */
The current implementation of CONFIG_RELOCATABLE in BookE is based on mapping the page aligned kernel load address to KERNELBASE. This approach however is not enough for platforms, where the TLB page size is large (e.g, 256M on 44x). So we are renaming the RELOCATABLE used currently in BookE to DYNAMIC_MEMSTART to reflect the actual method. The CONFIG_RELOCATABLE for PPC32(BookE) based on processing of the dynamic relocations will be introduced in the later in the patch series. This change would allow the use of the old method of RELOCATABLE for platforms which can afford to enforce the page alignment (platforms with smaller TLB size). I haven tested this change only on 440x. I don't have an FSL BookE to verify the changes there. Scott, Could you please test this patch on FSL and let me know the results ? Suggested-by: Scott Wood <scottwood@freescale.com> Signed-off-by: Suzuki K. Poulose <suzuki@in.ibm.com> Cc: Scott Wood <scottwood@freescale.com> Cc: Kumar Gala <galak@kernel.crashing.org> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org> Cc: linux ppc dev <linuxppc-dev@lists.ozlabs.org> --- arch/powerpc/Kconfig | 50 ++++++++++++++++--------- arch/powerpc/configs/44x/iss476-smp_defconfig | 2 + arch/powerpc/include/asm/kdump.h | 5 ++- arch/powerpc/include/asm/page.h | 4 +- arch/powerpc/kernel/crash_dump.c | 4 +- arch/powerpc/kernel/head_44x.S | 4 ++ arch/powerpc/kernel/head_fsl_booke.S | 2 + arch/powerpc/kernel/machine_kexec.c | 2 + arch/powerpc/kernel/prom_init.c | 2 + arch/powerpc/mm/44x_mmu.c | 2 + 10 files changed, 47 insertions(+), 30 deletions(-)