Message ID | 20220908085735.437808-1-kshitiz.varshney@nxp.com |
---|---|
State | Changes Requested |
Delegated to: | Stefano Babic |
Headers | show |
Series | [v1] 1: Adding rngb entry in imx6ull device tree | expand |
On 9/8/22 10:57, Kshitiz Varshney wrote: > From: Kshitiz <kshitiz.varshney@nxp.com> If you use format-patch HEAD~3, it will add numbers to the patches as expected: [PATCH 1/3]. For patch series we typically generate a cover-letter. > > Added entry for rngb in imx6ull device tree which is required for > Random number generation in u-boot. > > Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com> > Reviewed-by: Ye Li <ye.li@nxp.com> > --- > arch/arm/dts/imx6ull.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi > index 46e7ad6bab..c5d5a5ab7b 100644 > --- a/arch/arm/dts/imx6ull.dtsi > +++ b/arch/arm/dts/imx6ull.dtsi > @@ -66,6 +66,12 @@ > clocks = <&clks IMX6ULL_CLK_DCP_CLK>; > clock-names = "dcp"; > }; > + rngb: rng@2284000 { > + compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb"; > + reg = <0x02284000 0x4000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6UL_CLK_DUMMY>; > + }; This seems to match Linux' arch/arm/boot/dts/imx6ull.dtsi and Documentation/devicetree/bindings/rng/imx-rng.yaml. Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > iomuxc_snvs: iomuxc-snvs@2290000 { > compatible = "fsl,imx6ull-iomuxc-snvs";
On 9/8/2022 4:57 PM, Kshitiz Varshney wrote: > From: Kshitiz <kshitiz.varshney@nxp.com> > > Added entry for rngb in imx6ull device tree which is required for > Random number generation in u-boot. Please sync with linux dts, not directly add a node to dtsi Regards, Peng. > > Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com> > Reviewed-by: Ye Li <ye.li@nxp.com> > --- > arch/arm/dts/imx6ull.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi > index 46e7ad6bab..c5d5a5ab7b 100644 > --- a/arch/arm/dts/imx6ull.dtsi > +++ b/arch/arm/dts/imx6ull.dtsi > @@ -66,6 +66,12 @@ > clocks = <&clks IMX6ULL_CLK_DCP_CLK>; > clock-names = "dcp"; > }; > + rngb: rng@2284000 { > + compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb"; > + reg = <0x02284000 0x4000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6UL_CLK_DUMMY>; > + }; > > iomuxc_snvs: iomuxc-snvs@2290000 { > compatible = "fsl,imx6ull-iomuxc-snvs";
-----Original Message----- From: Heinrich Schuchardt <xypron.glpk@gmx.de> Sent: Friday, September 9, 2022 1:10 AM To: Kshitiz Varshney <kshitiz.varshney@nxp.com> Cc: Stefano Babic <sbabic@denx.de>; Fabio Estevam <festevam@gmail.com>; Peng Fan <peng.fan@nxp.com>; Sughosh Ganu <sughosh.ganu@linaro.org>; u-boot@lists.denx.de; Ye Li <ye.li@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Horia Geanta <horia.geanta@nxp.com> Subject: [EXT] Re: [PATCH v1] 1: Adding rngb entry in imx6ull device tree Caution: EXT Email On 9/8/22 10:57, Kshitiz Varshney wrote: > From: Kshitiz <kshitiz.varshney@nxp.com> If you use format-patch HEAD~3, it will add numbers to the patches as expected: [PATCH 1/3]. For patch series we typically generate a cover-letter. Will take care in next patch set. > > Added entry for rngb in imx6ull device tree which is required for > Random number generation in u-boot. > > Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com> > Reviewed-by: Ye Li <ye.li@nxp.com> > --- > arch/arm/dts/imx6ull.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi > index 46e7ad6bab..c5d5a5ab7b 100644 > --- a/arch/arm/dts/imx6ull.dtsi > +++ b/arch/arm/dts/imx6ull.dtsi > @@ -66,6 +66,12 @@ > clocks = <&clks IMX6ULL_CLK_DCP_CLK>; > clock-names = "dcp"; > }; > + rngb: rng@2284000 { > + compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb"; > + reg = <0x02284000 0x4000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6UL_CLK_DUMMY>; > + }; This seems to match Linux' arch/arm/boot/dts/imx6ull.dtsi and Documentation/devicetree/bindings/rng/imx-rng.yaml. As, this node entry is already present in upstream uboot. Hence, removed this patch from new patchset. Acked-by: Heinrich Schuchardt <xypron.glpk@gmx.de> > > iomuxc_snvs: iomuxc-snvs@2290000 { > compatible = "fsl,imx6ull-iomuxc-snvs";
-----Original Message----- From: Peng Fan (OSS) <peng.fan@oss.nxp.com> Sent: Monday, September 12, 2022 1:01 PM To: Kshitiz Varshney <kshitiz.varshney@nxp.com>; u-boot@lists.denx.de; Horia Geanta <horia.geanta@nxp.com>; Pankaj Gupta <pankaj.gupta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Rahul Kumar Yadav <rahulkumar.yadav@nxp.com>; Vabhav Sharma <vabhav.sharma@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>; Ye Li <ye.li@nxp.com>; Heinrich Schuchardt <xypron.glpk@gmx.de> Cc: Stefano Babic <sbabic@denx.de>; Fabio Estevam <festevam@gmail.com>; Peng Fan <peng.fan@nxp.com> Subject: Re: [PATCH v1] 1: Adding rngb entry in imx6ull device tree On 9/8/2022 4:57 PM, Kshitiz Varshney wrote: > From: Kshitiz <kshitiz.varshney@nxp.com> > > Added entry for rngb in imx6ull device tree which is required for > Random number generation in u-boot. Please sync with linux dts, not directly add a node to dtsi Regards, Peng. I have removed this patch from new version of patches as this entry was already present in upstream u-boot. > > Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com> > Reviewed-by: Ye Li <ye.li@nxp.com> > --- > arch/arm/dts/imx6ull.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi > index 46e7ad6bab..c5d5a5ab7b 100644 > --- a/arch/arm/dts/imx6ull.dtsi > +++ b/arch/arm/dts/imx6ull.dtsi > @@ -66,6 +66,12 @@ > clocks = <&clks IMX6ULL_CLK_DCP_CLK>; > clock-names = "dcp"; > }; > + rngb: rng@2284000 { > + compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb"; > + reg = <0x02284000 0x4000>; > + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&clks IMX6UL_CLK_DUMMY>; > + }; > > iomuxc_snvs: iomuxc-snvs@2290000 { > compatible = "fsl,imx6ull-iomuxc-snvs";
diff --git a/arch/arm/dts/imx6ull.dtsi b/arch/arm/dts/imx6ull.dtsi index 46e7ad6bab..c5d5a5ab7b 100644 --- a/arch/arm/dts/imx6ull.dtsi +++ b/arch/arm/dts/imx6ull.dtsi @@ -66,6 +66,12 @@ clocks = <&clks IMX6ULL_CLK_DCP_CLK>; clock-names = "dcp"; }; + rngb: rng@2284000 { + compatible = "fsl,imx6ull-rngb", "fsl,imx25-rngb"; + reg = <0x02284000 0x4000>; + interrupts = <GIC_SPI 6 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&clks IMX6UL_CLK_DUMMY>; + }; iomuxc_snvs: iomuxc-snvs@2290000 { compatible = "fsl,imx6ull-iomuxc-snvs";