| Message ID | 1663208146-5239-1-git-send-email-liaohj.jy@fujitsu.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | syscalls/fork02: Remove it | expand |
Hello, Liao Huangjie <liaohj.jy@fujitsu.com> writes: > From: Huangjie Liao <liaohj.jy@fujitsu.com> > > This test case has been covered in fork01,so remove it Not exactly because of wait. However I'll accept this on the basis that the original test doesn't ensure the child actually ran. Anything it does test will be covered by a lot of other stuff. > > Signed-off-by: Huangjie Liao <liaohj.jy@fujitsu.com> > --- > testcases/kernel/syscalls/fork/fork02.c | 99 ------------------------- > 1 file changed, 99 deletions(-) > delete mode 100644 testcases/kernel/syscalls/fork/fork02.c > > diff --git a/testcases/kernel/syscalls/fork/fork02.c b/testcases/kernel/syscalls/fork/fork02.c > deleted file mode 100644 > index 6fe66f823..000000000 > --- a/testcases/kernel/syscalls/fork/fork02.c > +++ /dev/null > @@ -1,99 +0,0 @@ > -/* > - * > - * Copyright (c) International Business Machines Corp., 2001 > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by > - * the Free Software Foundation; either version 2 of the License, or > - * (at your option) any later version. > - * > - * This program is distributed in the hope that it will be useful, > - * but WITHOUT ANY WARRANTY; without even the implied warranty of > - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See > - * the GNU General Public License for more details. > - * > - * You should have received a copy of the GNU General Public License > - * along with this program; if not, write to the Free Software > - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA > - */ > - > -/* > - * NAME > - * fork02.c > - * > - * DESCRIPTION > - * Test correct operation of fork: > - * pid == 0 in child; > - * pid > 0 in parent from wait; > - * > - * ALGORITHM > - * Fork one process, check for pid == 0 in child. > - * Check for pid > 0 in parent after wait. > - * > - * USAGE > - * fork02 > - * > - * HISTORY > - * 07/2001 Ported by Wayne Boyer > - * > - * RESTRICTIONS > - * None > - */ > - > -#include <sys/types.h> > -#include <sys/wait.h> > -#include <stdio.h> > -#include <unistd.h> > -#include "test.h" > - > -static void setup(void); > -static void cleanup(void); > - > -char *TCID = "fork02"; > -int TST_TOTAL = 1; > - > -int main(int ac, char **av) > -{ > - int pid1, pid2, status; > - > - int lc; > - > - tst_parse_opts(ac, av, NULL, NULL); > - > - setup(); > - > - for (lc = 0; TEST_LOOPING(lc); lc++) { > - tst_count = 0; > - > - pid1 = fork(); > - if (pid1 == -1) > - tst_brkm(TBROK, cleanup, "fork() failed"); > - > - if (pid1 == 0) { > - tst_resm(TINFO, "Inside child"); > - _exit(0); > - } else { > - tst_resm(TINFO, "Inside parent"); > - pid2 = wait(&status); > - tst_resm(TINFO, "exit status of wait %d", status); > - > - if (pid1 == pid2) > - tst_resm(TPASS, "test 1 PASSED"); > - else > - tst_resm(TFAIL, "test 1 FAILED"); > - } > - } > - > - cleanup(); > - tst_exit(); > -} > - > -static void setup(void) > -{ > - tst_sig(FORK, DEF_HANDLER, cleanup); > - TEST_PAUSE; > -} > - > -static void cleanup(void) > -{ > -} > -- > 2.27.0
Hi Liao, Richie, > > --- > > testcases/kernel/syscalls/fork/fork02.c | 99 ------------------------- > > 1 file changed, 99 deletions(-) > > delete mode 100644 testcases/kernel/syscalls/fork/fork02.c fork02 entry was left in runtest/syscalls and testcases/kernel/syscalls/fork/.gitignore. Not a big deal, I fixed it in 747cd665d. FYI you can use this checklist (not just reviewers, but also patch authors): https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist Kind regards, Petr
Hello, Petr Vorel <pvorel@suse.cz> writes: > Hi Liao, Richie, > >> > --- >> > testcases/kernel/syscalls/fork/fork02.c | 99 ------------------------- >> > 1 file changed, 99 deletions(-) >> > delete mode 100644 testcases/kernel/syscalls/fork/fork02.c > > fork02 entry was left in runtest/syscalls and > testcases/kernel/syscalls/fork/.gitignore. > > Not a big deal, I fixed it in 747cd665d. FYI you can use this checklist > (not just reviewers, but also patch authors): > https://github.com/linux-test-project/ltp/wiki/Maintainer-Patch-Review-Checklist Sorry, my mistake, thanks for fixing it. > > Kind regards, > Petr
diff --git a/testcases/kernel/syscalls/fork/fork02.c b/testcases/kernel/syscalls/fork/fork02.c deleted file mode 100644 index 6fe66f823..000000000 --- a/testcases/kernel/syscalls/fork/fork02.c +++ /dev/null @@ -1,99 +0,0 @@ -/* - * - * Copyright (c) International Business Machines Corp., 2001 - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See - * the GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA - */ - -/* - * NAME - * fork02.c - * - * DESCRIPTION - * Test correct operation of fork: - * pid == 0 in child; - * pid > 0 in parent from wait; - * - * ALGORITHM - * Fork one process, check for pid == 0 in child. - * Check for pid > 0 in parent after wait. - * - * USAGE - * fork02 - * - * HISTORY - * 07/2001 Ported by Wayne Boyer - * - * RESTRICTIONS - * None - */ - -#include <sys/types.h> -#include <sys/wait.h> -#include <stdio.h> -#include <unistd.h> -#include "test.h" - -static void setup(void); -static void cleanup(void); - -char *TCID = "fork02"; -int TST_TOTAL = 1; - -int main(int ac, char **av) -{ - int pid1, pid2, status; - - int lc; - - tst_parse_opts(ac, av, NULL, NULL); - - setup(); - - for (lc = 0; TEST_LOOPING(lc); lc++) { - tst_count = 0; - - pid1 = fork(); - if (pid1 == -1) - tst_brkm(TBROK, cleanup, "fork() failed"); - - if (pid1 == 0) { - tst_resm(TINFO, "Inside child"); - _exit(0); - } else { - tst_resm(TINFO, "Inside parent"); - pid2 = wait(&status); - tst_resm(TINFO, "exit status of wait %d", status); - - if (pid1 == pid2) - tst_resm(TPASS, "test 1 PASSED"); - else - tst_resm(TFAIL, "test 1 FAILED"); - } - } - - cleanup(); - tst_exit(); -} - -static void setup(void) -{ - tst_sig(FORK, DEF_HANDLER, cleanup); - TEST_PAUSE; -} - -static void cleanup(void) -{ -}