diff mbox series

stat03: cleanup, use TST_EXP_FAIL macro

Message ID 20220816074449.30861-2-akumar@suse.de
State Accepted
Headers show
Series stat03: cleanup, use TST_EXP_FAIL macro | expand

Commit Message

Avinesh Kumar Aug. 16, 2022, 7:44 a.m. UTC 
- update copyright
- turn comment into docparse format
- remove redundant headers
- make check fix: change to static
- use TST_EXP_FAIL with expected errno code

Signed-off-by: Avinesh Kumar <akumar@suse.de>
---
 testcases/kernel/syscalls/stat/stat03.c | 25 +++++++------------------
 1 file changed, 7 insertions(+), 18 deletions(-)

Comments

Richard Palethorpe Oct. 11, 2022, 12:38 p.m. UTC | #1 
Hello,

Merged!
diff mbox series

Patch

diff --git a/testcases/kernel/syscalls/stat/stat03.c b/testcases/kernel/syscalls/stat/stat03.c
index 20d4c772f..369e6d79f 100644
--- a/testcases/kernel/syscalls/stat/stat03.c
+++ b/testcases/kernel/syscalls/stat/stat03.c
@@ -2,15 +2,16 @@ 
 /* Copyright (c) International Business Machines  Corp., 2001
  *	07/2001 John George
  *		-Ported
+ * Copyright (c) Linux Test Project, 2002-2022
+ */
+
+/*\
+ * [Description]
  *
  * check stat() with various error conditions that should produce
  * EACCES, EFAULT, ENAMETOOLONG,  ENOENT, ENOTDIR, ELOOP
  */
 
-#include <fcntl.h>
-#include <errno.h>
-#include <sys/types.h>
-#include <sys/stat.h>
 #include <pwd.h>
 #include "tst_test.h"
 
@@ -23,7 +24,7 @@ 
 #define MODE_RW	        0666
 #define DIR_MODE        0755
 
-struct passwd *ltpuser;
+static struct passwd *ltpuser;
 
 static char long_dir[PATH_MAX + 2] = {[0 ... PATH_MAX + 1] = 'a'};
 static char loop_dir[PATH_MAX] = ".";
@@ -45,19 +46,7 @@  static void verify_stat(unsigned int n)
 	struct tcase *tc = TC + n;
 	struct stat stat_buf;
 
-	TEST(stat(tc->pathname, &stat_buf));
-	if (TST_RET != -1) {
-		tst_res(TFAIL, "stat() succeeded unexpectedly");
-		return;
-	}
-
-	if (TST_ERR == tc->exp_errno) {
-		tst_res(TPASS | TTERRNO, "stat() failed as expected");
-	} else {
-		tst_res(TFAIL | TTERRNO,
-			"stat() failed unexpectedly; expected: %d - %s",
-			tc->exp_errno, tst_strerrno(tc->exp_errno));
-	}
+	TST_EXP_FAIL(stat(tc->pathname, &stat_buf), tc->exp_errno);
 }
 
 static void setup(void)