| Message ID | 1322140150-15801-1-git-send-email-holger.brunck@keymile.com |
|---|---|
| State | Accepted |
| Delegated to: | Albert ARIBAUD |
| Headers | show |
> commit f31a911fe (arm, post: add missing post_time_ms for arm) > enables get_ticks and get_tbclk for all arm based boards, > but kirkwood has currently no implementation for this. So > undefine this for kirkwood boards. So this means the kirkwood timer doesn't conform to current timer api? Why work it around and not fix it then? M
> -----Original Message----- > From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] > On Behalf Of Marek Vasut > Sent: 25 November 2011 14:22 > To: u-boot@lists.denx.de > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > kirkwood > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > enables get_ticks and get_tbclk for all arm based boards, > > but kirkwood has currently no implementation for this. So > > undefine this for kirkwood boards. > > So this means the kirkwood timer doesn't conform to current timer api? Why > work > it around and not fix it then? I think this is better approach Regards.. Prafulla . . .
> > -----Original Message----- > > From: u-boot-bounces@lists.denx.de [mailto:u-boot-bounces@lists.denx.de] > > On Behalf Of Marek Vasut > > Sent: 25 November 2011 14:22 > > To: u-boot@lists.denx.de > > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > > kirkwood > > > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > > enables get_ticks and get_tbclk for all arm based boards, > > > but kirkwood has currently no implementation for this. So > > > undefine this for kirkwood boards. > > > > So this means the kirkwood timer doesn't conform to current timer api? > > Why work > > it around and not fix it then? > > I think this is better approach > Right? :) So now the question is ... who's gonna do it ? ;-)
> -----Original Message----- > From: Marek Vasut [mailto:marek.vasut@gmail.com] > Sent: 25 November 2011 14:52 > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > Schocher; Holger Brunck > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > kirkwood > > > > -----Original Message----- > > > From: u-boot-bounces@lists.denx.de [mailto:u-boot- > bounces@lists.denx.de] > > > On Behalf Of Marek Vasut > > > Sent: 25 November 2011 14:22 > > > To: u-boot@lists.denx.de > > > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests > on > > > kirkwood > > > > > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > > > enables get_ticks and get_tbclk for all arm based boards, > > > > but kirkwood has currently no implementation for this. So > > > > undefine this for kirkwood boards. > > > > > > So this means the kirkwood timer doesn't conform to current timer api? > > > Why work > > > it around and not fix it then? > > > > I think this is better approach > > > Right? :) So now the question is ... who's gonna do it ? ;-) Patch from any one is welcomed. :-D Regards.. Prafulla . . .
> > -----Original Message----- > > From: Marek Vasut [mailto:marek.vasut@gmail.com] > > Sent: 25 November 2011 14:52 > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > > Schocher; Holger Brunck > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > > kirkwood > > > > > > -----Original Message----- > > > > From: u-boot-bounces@lists.denx.de [mailto:u-boot- > > > > bounces@lists.denx.de] > > > > > > On Behalf Of Marek Vasut > > > > Sent: 25 November 2011 14:22 > > > > To: u-boot@lists.denx.de > > > > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger Brunck > > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests > > > > on > > > > > > kirkwood > > > > > > > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > > > > enables get_ticks and get_tbclk for all arm based boards, > > > > > but kirkwood has currently no implementation for this. So > > > > > undefine this for kirkwood boards. > > > > > > > > So this means the kirkwood timer doesn't conform to current timer > > > > api? Why work > > > > it around and not fix it then? > > > > > > I think this is better approach > > > > Right? :) So now the question is ... who's gonna do it ? ;-) > > Patch from any one is welcomed. :-D Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D M
> -----Original Message----- > From: Marek Vasut [mailto:marek.vasut@gmail.com] > Sent: 26 November 2011 17:15 > To: Prafulla Wadaskar > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > Schocher; Holger Brunck > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > kirkwood > > > > -----Original Message----- > > > From: Marek Vasut [mailto:marek.vasut@gmail.com] > > > Sent: 25 November 2011 14:52 > > > To: Prafulla Wadaskar > > > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > > > Schocher; Holger Brunck > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests > on > > > kirkwood > > > > > > > > -----Original Message----- > > > > > From: u-boot-bounces@lists.denx.de [mailto:u-boot- > > > > > > bounces@lists.denx.de] > > > > > > > > On Behalf Of Marek Vasut > > > > > Sent: 25 November 2011 14:22 > > > > > To: u-boot@lists.denx.de > > > > > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger > Brunck > > > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post > tests > > > > > > on > > > > > > > > kirkwood > > > > > > > > > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > > > > > enables get_ticks and get_tbclk for all arm based boards, > > > > > > but kirkwood has currently no implementation for this. So > > > > > > undefine this for kirkwood boards. > > > > > > > > > > So this means the kirkwood timer doesn't conform to current timer > > > > > api? Why work > > > > > it around and not fix it then? > > > > > > > > I think this is better approach > > > > > > Right? :) So now the question is ... who's gonna do it ? ;-) > > > > Patch from any one is welcomed. :-D > > Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D I would have loved to do it, but I am very busy with some other very important assignment. May be I will post a patch in feb2012 Regards.. Prafulla . .
> > -----Original Message----- > > From: Marek Vasut [mailto:marek.vasut@gmail.com] > > Sent: 26 November 2011 17:15 > > To: Prafulla Wadaskar > > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > > Schocher; Holger Brunck > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests on > > kirkwood > > > > > > -----Original Message----- > > > > From: Marek Vasut [mailto:marek.vasut@gmail.com] > > > > Sent: 25 November 2011 14:52 > > > > To: Prafulla Wadaskar > > > > Cc: u-boot@lists.denx.de; Valentin@theia.denx.de; Longchamp; Heiko > > > > Schocher; Holger Brunck > > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post tests > > > > on > > > > > > kirkwood > > > > > > > > > > -----Original Message----- > > > > > > From: u-boot-bounces@lists.denx.de [mailto:u-boot- > > > > > > > > bounces@lists.denx.de] > > > > > > > > > > On Behalf Of Marek Vasut > > > > > > Sent: 25 November 2011 14:22 > > > > > > To: u-boot@lists.denx.de > > > > > > Cc: Valentin@theia.denx.de; Longchamp; Heiko Schocher; Holger > > > > Brunck > > > > > > > > Subject: Re: [U-Boot] [PATCH] post: fix compile issue for post > > > > tests > > > > > > on > > > > > > > > > > kirkwood > > > > > > > > > > > > > commit f31a911fe (arm, post: add missing post_time_ms for arm) > > > > > > > enables get_ticks and get_tbclk for all arm based boards, > > > > > > > but kirkwood has currently no implementation for this. So > > > > > > > undefine this for kirkwood boards. > > > > > > > > > > > > So this means the kirkwood timer doesn't conform to current timer > > > > > > api? Why work > > > > > > it around and not fix it then? > > > > > > > > > > I think this is better approach > > > > > > > > Right? :) So now the question is ... who's gonna do it ? ;-) > > > > > > Patch from any one is welcomed. :-D > > > > Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D > > I would have loved to do it, but I am very busy with some other very > important assignment. May be I will post a patch in feb2012 > I'll keep an eye on this ;-)
Hi, On 11/27/2011 08:07 AM, Marek Vasut wrote: >>>>>>> >>>>>>>> commit f31a911fe (arm, post: add missing post_time_ms for arm) >>>>>>>> enables get_ticks and get_tbclk for all arm based boards, >>>>>>>> but kirkwood has currently no implementation for this. So >>>>>>>> undefine this for kirkwood boards. >>>>>>> >>>>>>> So this means the kirkwood timer doesn't conform to current timer >>>>>>> api? Why work >>>>>>> it around and not fix it then? >>>>>> >>>>>> I think this is better approach >>>>> >>>>> Right? :) So now the question is ... who's gonna do it ? ;-) >>>> >>>> Patch from any one is welcomed. :-D >>> >>> Anyone, eh? Anyone ... anyone like the maintainer maybe ? >:-D >> >> I would have loved to do it, but I am very busy with some other very >> important assignment. May be I will post a patch in feb2012 >> > > I'll keep an eye on this ;-) I do also agree that implementing the functions would be better then adding an #ifdef as my patch does. But I currently got also no time to do this. So could someone please pick this patch up that the keymile ARM boards are compilable again? Best regards Holger
diff --git a/post/post.c b/post/post.c index 0e67ad7..422a819 100644 --- a/post/post.c +++ b/post/post.c @@ -494,7 +494,7 @@ void post_reloc(void) */ unsigned long post_time_ms(unsigned long base) { -#if defined(CONFIG_PPC) || defined(CONFIG_ARM) +#if defined(CONFIG_PPC) || defined(CONFIG_ARM) && !defined(CONFIG_KIRKWOOD) return (unsigned long)(get_ticks() / (get_tbclk() / CONFIG_SYS_HZ)) - base; #else
commit f31a911fe (arm, post: add missing post_time_ms for arm) enables get_ticks and get_tbclk for all arm based boards, but kirkwood has currently no implementation for this. So undefine this for kirkwood boards. Signed-off-by: Holger Brunck <holger.brunck@keymile.com> cc: Heiko Schocher <hs@denx.de> cc: Prafulla Wadaskar <prafulla@marvell.com> cc: Valentin Longchamp <valentin.longchamp@keymile.com> --- post/post.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)