Message ID | 1322077682-12838-1-git-send-email-galak@kernel.crashing.org |
---|---|
State | Accepted |
Commit | 068f158fdf1937de45fc0e0bb2c3c9063c2cc8f6 |
Headers | show |
Acked-by: Mike Frysinger <vapier@gentoo.org>
-mike
Hi Kumar, Sorry for that one. On 11/23/11 21:48, Kumar Gala wrote: > cmd_nvedit.c: In function 'do_env_grep': > cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> Acked-by: Igor Grinberg <grinberg@compulab.co.il> > --- > common/cmd_nvedit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c > index 7409a36..5995354 100644 > --- a/common/cmd_nvedit.c > +++ b/common/cmd_nvedit.c > @@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag, > > while (arg <= argc) { > idx = 0; > - while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) { > + while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) { > if (!(matched[idx / 8] & (1 << (idx & 7)))) { > puts(match->key); > puts("=");
Dear Kumar Gala, In message <1322077682-12838-1-git-send-email-galak@kernel.crashing.org> you wrote: > cmd_nvedit.c: In function 'do_env_grep': > cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value > > Signed-off-by: Kumar Gala <galak@kernel.crashing.org> > --- > common/cmd_nvedit.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/common/cmd_nvedit.c b/common/cmd_nvedit.c index 7409a36..5995354 100644 --- a/common/cmd_nvedit.c +++ b/common/cmd_nvedit.c @@ -179,7 +179,7 @@ static int do_env_grep(cmd_tbl_t *cmdtp, int flag, while (arg <= argc) { idx = 0; - while (idx = hstrstr_r(argv[arg], idx, &match, &env_htab)) { + while ((idx = hstrstr_r(argv[arg], idx, &match, &env_htab))) { if (!(matched[idx / 8] & (1 << (idx & 7)))) { puts(match->key); puts("=");
cmd_nvedit.c: In function 'do_env_grep': cmd_nvedit.c:182:3: warning: suggest parentheses around assignment used as truth value Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- common/cmd_nvedit.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)