| Message ID | 20220722120501.28670-8-andrea.cervesato@suse.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Refactor mqns testing suite | expand |
Hi Andrea, > Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> > --- > testcases/kernel/containers/mqns/{common.h => mqns.h} | 0 could you please also fix this checkpatch error (preferably as a separate patch): mqns.h:37: ERROR: "foo* bar" should be "foo *bar" mqns.h:96: WARNING: __func__ should be used instead of gcc specific __FUNCTION__ Checkpatch also reports wrong comment style, but I'd ignore it (complains for *.h, it's ok for *.c): mqns.h:1: WARNING: Improper SPDX comment style for 'mqns.h', please use '/*' instead @Richie: not sure I might have asked before: it'd be great to have make target also for header files, so that they are checked with make check. Now we have to run checkpatch manually to check them. Kind regards, Petr > testcases/kernel/containers/mqns/mqns_01.c | 2 +- > testcases/kernel/containers/mqns/mqns_02.c | 2 +- > testcases/kernel/containers/mqns/mqns_03.c | 2 +- > testcases/kernel/containers/mqns/mqns_04.c | 2 +- > 5 files changed, 4 insertions(+), 4 deletions(-) > rename testcases/kernel/containers/mqns/{common.h => mqns.h} (100%) ... Patch itself it's obviously correct. Reviewed-by: Petr Vorel <pvorel@suse.cz> Kind regards, Petr
diff --git a/testcases/kernel/containers/mqns/common.h b/testcases/kernel/containers/mqns/mqns.h similarity index 100% rename from testcases/kernel/containers/mqns/common.h rename to testcases/kernel/containers/mqns/mqns.h diff --git a/testcases/kernel/containers/mqns/mqns_01.c b/testcases/kernel/containers/mqns/mqns_01.c index a34dc4f66..7e62ab3d6 100644 --- a/testcases/kernel/containers/mqns/mqns_01.c +++ b/testcases/kernel/containers/mqns/mqns_01.c @@ -12,7 +12,7 @@ * the isolated/forked child namespace. */ -#include "common.h" +#include "mqns.h" #define MQNAME "/MQ1" diff --git a/testcases/kernel/containers/mqns/mqns_02.c b/testcases/kernel/containers/mqns/mqns_02.c index 4383fef73..59d483be7 100644 --- a/testcases/kernel/containers/mqns/mqns_02.c +++ b/testcases/kernel/containers/mqns/mqns_02.c @@ -12,7 +12,7 @@ * then check namespace isolation. */ -#include "common.h" +#include "mqns.h" #define MQNAME "/MQ1" diff --git a/testcases/kernel/containers/mqns/mqns_03.c b/testcases/kernel/containers/mqns/mqns_03.c index 5914a2a9b..54ba54304 100644 --- a/testcases/kernel/containers/mqns/mqns_03.c +++ b/testcases/kernel/containers/mqns/mqns_03.c @@ -25,7 +25,7 @@ #define _GNU_SOURCE #include <stdio.h> -#include "common.h" +#include "mqns.h" #include "tst_safe_stdio.h" #define MQNAME1 "/MQ1" diff --git a/testcases/kernel/containers/mqns/mqns_04.c b/testcases/kernel/containers/mqns/mqns_04.c index 95ff18ef2..b3f538592 100644 --- a/testcases/kernel/containers/mqns/mqns_04.c +++ b/testcases/kernel/containers/mqns/mqns_04.c @@ -24,7 +24,7 @@ #define _GNU_SOURCE #include <stdio.h> -#include "common.h" +#include "mqns.h" #include "tst_safe_stdio.h" #define CHECK_MQ_OPEN_RET(x) ((x) >= 0 || ((x) == -1 && errno != EMFILE))
Signed-off-by: Andrea Cervesato <andrea.cervesato@suse.com> --- testcases/kernel/containers/mqns/{common.h => mqns.h} | 0 testcases/kernel/containers/mqns/mqns_01.c | 2 +- testcases/kernel/containers/mqns/mqns_02.c | 2 +- testcases/kernel/containers/mqns/mqns_03.c | 2 +- testcases/kernel/containers/mqns/mqns_04.c | 2 +- 5 files changed, 4 insertions(+), 4 deletions(-) rename testcases/kernel/containers/mqns/{common.h => mqns.h} (100%)