| Message ID | 558f3ff3d373b1cdcbebebe842816b3c91438728.1321384662.git.david.decotigny@google.com |
|---|---|
| State | Deferred, archived |
| Delegated to: | David Miller |
| Headers | show |
On Tue, 15 Nov 2011 11:25:37 -0800 David Decotigny <david.decotigny@google.com> wrote: > +module_param(optimization_mode, int, S_IRUGO); > MODULE_PARM_DESC(optimization_mode, "In throughput mode (0), every tx & rx packet will generate an interrupt. In CPU mode (1), interrupts are controlled by a timer. In dynamic mode (2), the mode toggles between throughput and CPU mode based on network load."); Probably the original developer (or marketing data sheet), thought this was some unique feature of the hardware. But most devices have this already. This driver should just implement proper control irq coalescing control via ethtool and get rid of the silly module parameter. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Tue, 15 Nov 2011 11:25:37 -0800 David Decotigny <david.decotigny@google.com> wrote: > +module_param(msi, int, S_IRUGO); > MODULE_PARM_DESC(msi, "MSI interrupts are enabled by setting to 1 and disabled by setting to 0."); > -module_param(msix, int, 0); > +module_param(msix, int, S_IRUGO); > MODULE_PARM_DESC(msix, "MSIX interrupts are enabled by setting to 1 and disabled by setting to 0."); > -module_param(dma_64bit, int, 0); > +module_param(dma_64bit, int, S_IRUGO); Once again these attributes are visible through other means (/proc/interrupts for MSI) and the 64bit dma is NETIF_F_HIGHDMA. They shouldn't be module parameters. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c index 9b917ff..ee8cce5 100644 --- a/drivers/net/ethernet/nvidia/forcedeth.c +++ b/drivers/net/ethernet/nvidia/forcedeth.c @@ -6153,23 +6153,23 @@ static void __exit exit_nic(void) pci_unregister_driver(&driver); } -module_param(max_interrupt_work, int, 0); +module_param(max_interrupt_work, int, S_IRUGO); MODULE_PARM_DESC(max_interrupt_work, "forcedeth maximum events handled per interrupt"); -module_param(optimization_mode, int, 0); +module_param(optimization_mode, int, S_IRUGO); MODULE_PARM_DESC(optimization_mode, "In throughput mode (0), every tx & rx packet will generate an interrupt. In CPU mode (1), interrupts are controlled by a timer. In dynamic mode (2), the mode toggles between throughput and CPU mode based on network load."); -module_param(poll_interval, int, 0); +module_param(poll_interval, int, S_IRUGO); MODULE_PARM_DESC(poll_interval, "Interval determines how frequent timer interrupt is generated by [(time_in_micro_secs * 100) / (2^10)]. Min is 0 and Max is 65535."); -module_param(msi, int, 0); +module_param(msi, int, S_IRUGO); MODULE_PARM_DESC(msi, "MSI interrupts are enabled by setting to 1 and disabled by setting to 0."); -module_param(msix, int, 0); +module_param(msix, int, S_IRUGO); MODULE_PARM_DESC(msix, "MSIX interrupts are enabled by setting to 1 and disabled by setting to 0."); -module_param(dma_64bit, int, 0); +module_param(dma_64bit, int, S_IRUGO); MODULE_PARM_DESC(dma_64bit, "High DMA is enabled by setting to 1 and disabled by setting to 0."); -module_param(phy_cross, int, 0); +module_param(phy_cross, int, S_IRUGO); MODULE_PARM_DESC(phy_cross, "Phy crossover detection for Realtek 8201 phy is enabled by setting to 1 and disabled by setting to 0."); -module_param(phy_power_down, int, 0); +module_param(phy_power_down, int, S_IRUGO); MODULE_PARM_DESC(phy_power_down, "Power down phy and disable link when interface is down (1), or leave phy powered up (0)."); -module_param(debug_tx_timeout, bool, 0); +module_param(debug_tx_timeout, bool, S_IRUGO|S_IWUSR); MODULE_PARM_DESC(debug_tx_timeout, "Dump tx related registers and ring when tx_timeout happens");
In particular, debug_tx_timeout can be updated at runtime. Signed-off-by: David Decotigny <david.decotigny@google.com> --- drivers/net/ethernet/nvidia/forcedeth.c | 18 +++++++++--------- 1 files changed, 9 insertions(+), 9 deletions(-)