diff mbox series

[v1] mc_opts/mc_verify_opts.c: Initialize local variable

Message ID 20220216092553.32091-1-blezhepekov@suse.de
State Accepted
Headers show
Series [v1] mc_opts/mc_verify_opts.c: Initialize local variable | expand

Commit Message

Bogdan Lezhepekov Feb. 16, 2022, 9:25 a.m. UTC
In some cases uninitialized array was used
when comparing strings in main().

Signed-off-by: Bogdan Lezhepekov <blezhepekov@suse.de>
---
 testcases/network/multicast/mc_opts/mc_verify_opts.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Petr Vorel June 9, 2022, 11:58 a.m. UTC | #1
Hi Bogdan,

> In some cases uninitialized array was used
> when comparing strings in main().

Good catch, indeed in case of error on getsockopt() on IP_MULTICAST_IF
gintf is really undefined.

Merged, thanks!

Kind regards,
Petr
diff mbox series

Patch

diff --git a/testcases/network/multicast/mc_opts/mc_verify_opts.c b/testcases/network/multicast/mc_opts/mc_verify_opts.c
index 679b81777..8946324bd 100644
--- a/testcases/network/multicast/mc_opts/mc_verify_opts.c
+++ b/testcases/network/multicast/mc_opts/mc_verify_opts.c
@@ -22,7 +22,7 @@  int main(int argc, char *argv[])
 	unsigned i1, i2, i3, i4;
 	struct hostent *hp, *gethostbyname();
 
-	char sintf[20], gintf[20];
+	char sintf[20], gintf[20] = {0};
 	unsigned char ttl;
 	char loop = 0;
 	unsigned int len = 0;