diff mbox

If P2P device expires while GO nego is in progress, indicate GO Nego failure.

Message ID 0BED5F74AB839C4796CA2BFC2BC311B4103EF007B9@SJEXCHCCR01.corp.ad.broadcom.com
State Superseded, archived
Headers show

Commit Message

Jithu Jance Nov. 7, 2011, 4:44 p.m. UTC 
Sorry to resend the patch again. Kindly let me know, if the patch is not proper or doesn't address the below mentioned scenario as intended.

This patch addresses a corner case in GO-Negotiation case. Consider the scenario where two devices A and B are in discovery stage and Device B vanishes [moves out of range] when a connect is issued on the Device A. Then Device A keeps on retrying the GO Nego req till the retry limit is reached. On reaching retry limit, the pending group interface is removed. But suppose if the peer entry in the device list expires before the retry limit is reached, then pending group interface is not removed. This patch will indicate go nego failure and will remove any pending group interfaces. 


Signed-hostap: Jithu Jance <jithu@broadcom.com>

---
 src/p2p/p2p.c |    6 +++++-
 1 files changed, 5 insertions(+), 1 deletions(-)

--
1.7.4.1


-- Jithu Jance.

Comments

Johannes Berg Nov. 7, 2011, 5:52 p.m. UTC | #1 
On Mon, 2011-11-07 at 08:44 -0800, Jithu Jance wrote:
> Sorry to resend the patch again.

You really shouldn't be doing that. According to
http://patchwork.ozlabs.org/project/hostap/list/, your patch is now
pending *three* times.

johannes
Jithu Jance Nov. 8, 2011, 5:52 a.m. UTC | #2 
Hi Johannes,

Thanks for pointing that out. I didn't know that the patches are being tracked that way and was worried that the mails went un-noticed. :(

Now, is there a way to remove my duplicate entries in the http://patchwork.ozlabs.org/project/hostap/list/ ?


-- Jithu Jance.

-----Original Message-----
From: Johannes Berg [mailto:johannes@sipsolutions.net] 
Sent: Monday, November 07, 2011 11:22 PM
To: Jithu Jance
Cc: hostap@lists.shmoo.com
Subject: Re: [PATCH] If P2P device expires while GO nego is in progress, indicate GO Nego failure.

On Mon, 2011-11-07 at 08:44 -0800, Jithu Jance wrote:
> Sorry to resend the patch again.

You really shouldn't be doing that. According to
http://patchwork.ozlabs.org/project/hostap/list/, your patch is now
pending *three* times.

johannes
Johannes Berg Nov. 8, 2011, 8:03 a.m. UTC | #3 
On Mon, 2011-11-07 at 21:52 -0800, Jithu Jance wrote:
> Hi Johannes,
> 
> Thanks for pointing that out. I didn't know that the patches are being tracked that way and was worried that the mails went un-noticed. :(
> 
> Now, is there a way to remove my duplicate entries in the http://patchwork.ozlabs.org/project/hostap/list/ ?

You can mark them as superseded & archived yourself after creating an
account and linking it to the email address you used to send the
patches.

johannes
diff mbox

Patch

diff --git a/src/p2p/p2p.c b/src/p2p/p2p.c
index 404b2cd..5a7aee2 100644
--- a/src/p2p/p2p.c
+++ b/src/p2p/p2p.c
@@ -625,8 +625,12 @@  static void p2p_device_free(struct p2p_data *p2p, struct p2p_device *dev)
 {
        int i;

-       if (p2p->go_neg_peer == dev)
+       if (p2p->go_neg_peer == dev) {
+               /* If GO Negotiation is in progress, report that
+                * it has failed. */
+               p2p_go_neg_failed(p2p, dev, -1);
                p2p->go_neg_peer = NULL;
+       }
        if (p2p->invite_peer == dev)
                p2p->invite_peer = NULL;
        if (p2p->sd_peer == dev)