| Message ID | 1320055655-19842-1-git-send-email-valentin.longchamp@keymile.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Valentin, On 10/31/11 12:07, Valentin Longchamp wrote: > As this is a mandatory CONFIG for ARM boards now. > > Signed-off-by: Valentin Longchamp <valentin.longchamp@keymile.com> > Signed-off-by: Holger Brunck <holger.brunck@keymile.com> > --- > include/configs/km/km_arm.h | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h > index eaf6017..f30088d 100644 > --- a/include/configs/km/km_arm.h > +++ b/include/configs/km/km_arm.h > @@ -48,6 +48,8 @@ > #define CONFIG_KW88F6281 /* SOC Name */ > #define CONFIG_MACH_KM_KIRKWOOD /* Machine type */ > > +#define CONFIG_MACH_TYPE MACH_TYPE_KM_KIRKWOOD > + Probably, you also want to remove the gd->bd->bi_arch_number assignment from board files using this mach id?
> -----Original Message----- > From: u-boot-bounces@lists.denx.de [mailto:u-boot- > bounces@lists.denx.de] On Behalf Of Igor Grinberg > Sent: Monday, October 31, 2011 4:18 PM > To: Valentin Longchamp > Cc: u-boot@lists.denx.de; Holger Brunck > Subject: Re: [U-Boot] [PATCH] ARM: define CONFIG_MACH_TYPE for > all keymile boards > > Hi Valentin, > > On 10/31/11 12:07, Valentin Longchamp wrote: > > As this is a mandatory CONFIG for ARM boards now. > > > > Signed-off-by: Valentin Longchamp > <valentin.longchamp@keymile.com> > > Signed-off-by: Holger Brunck <holger.brunck@keymile.com> > > --- > > include/configs/km/km_arm.h | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/include/configs/km/km_arm.h > b/include/configs/km/km_arm.h > > index eaf6017..f30088d 100644 > > --- a/include/configs/km/km_arm.h > > +++ b/include/configs/km/km_arm.h > > @@ -48,6 +48,8 @@ > > #define CONFIG_KW88F6281 /* SOC Name */ > > #define CONFIG_MACH_KM_KIRKWOOD /* Machine type */ > > > > +#define CONFIG_MACH_TYPE MACH_TYPE_KM_KIRKWOOD > > + > > Probably, you also want to remove the gd->bd->bi_arch_number > assignment from board files using this mach id? Hi Valentin Please post one patch for all this (including above, MACH_TYPE_KM_KIRKDOOD definition and CONFIG_MACH_TYPE definition) Regards... Prafulla . . .
On Monday 31 October 2011 06:48:06 Igor Grinberg wrote: > On 10/31/11 12:07, Valentin Longchamp wrote: > > --- a/include/configs/km/km_arm.h > > +++ b/include/configs/km/km_arm.h > > @@ -48,6 +48,8 @@ > > > > #define CONFIG_KW88F6281 /* SOC Name */ > > #define CONFIG_MACH_KM_KIRKWOOD /* Machine type */ > > > > +#define CONFIG_MACH_TYPE MACH_TYPE_KM_KIRKWOOD > > + > > Probably, you also want to remove the gd->bd->bi_arch_number > assignment from board files using this mach id? if possible, i'd like to punt bi_arch_number from everyone ... -mike
On 10/31/11 20:28, Mike Frysinger wrote: > On Monday 31 October 2011 06:48:06 Igor Grinberg wrote: >> On 10/31/11 12:07, Valentin Longchamp wrote: >>> --- a/include/configs/km/km_arm.h >>> +++ b/include/configs/km/km_arm.h >>> @@ -48,6 +48,8 @@ >>> >>> #define CONFIG_KW88F6281 /* SOC Name */ >>> #define CONFIG_MACH_KM_KIRKWOOD /* Machine type */ >>> >>> +#define CONFIG_MACH_TYPE MACH_TYPE_KM_KIRKWOOD >>> + >> >> Probably, you also want to remove the gd->bd->bi_arch_number >> assignment from board files using this mach id? > > if possible, i'd like to punt bi_arch_number from everyone ... Apart from those who have the mach id runtime discoverable, it would be great idea, but we cannot request this from someone who fixes his/her boards. Patches are welcome ;)
diff --git a/include/configs/km/km_arm.h b/include/configs/km/km_arm.h index eaf6017..f30088d 100644 --- a/include/configs/km/km_arm.h +++ b/include/configs/km/km_arm.h @@ -48,6 +48,8 @@ #define CONFIG_KW88F6281 /* SOC Name */ #define CONFIG_MACH_KM_KIRKWOOD /* Machine type */ +#define CONFIG_MACH_TYPE MACH_TYPE_KM_KIRKWOOD + /* include common defines/options for all Keymile boards */ #include "keymile-common.h"