| Message ID | 1319318452-27036-6-git-send-email-galak@kernel.crashing.org (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Commit | a45edbf9dc8cd7c7bfe2876b0efc2aee7bd6eb59 |
| Headers | show |
On 10/22/2011 04:20 PM, Kumar Gala wrote: > All eTSEC2 controllers support waking on magic packet so fixup device > tree to report that. If they *all* support it, we can make the driver rely on the compatible instead. -Scott
On Oct 25, 2011, at 5:19 PM, Scott Wood wrote: > On 10/22/2011 04:20 PM, Kumar Gala wrote: >> All eTSEC2 controllers support waking on magic packet so fixup device >> tree to report that. > > If they *all* support it, we can make the driver rely on the compatible > instead. > > -Scott I think this might have originated on eTSEC v1, in which all controllers don't support it. I'm not against removing it & just using compatible but don't know enough about these nodes to comment. - k
On 10/25/2011 10:35 PM, Kumar Gala wrote: > > On Oct 25, 2011, at 5:19 PM, Scott Wood wrote: > >> On 10/22/2011 04:20 PM, Kumar Gala wrote: >>> All eTSEC2 controllers support waking on magic packet so fixup device >>> tree to report that. >> >> If they *all* support it, we can make the driver rely on the compatible >> instead. >> >> -Scott > > I think this might have originated on eTSEC v1, in which all controllers don't support it. Sure, I was just talking about nodes with fsl,etsec2 -- especially if we have device trees already out there that are missing the property. Easier to change the driver. -Scott
diff --git a/arch/powerpc/boot/dts/p1020si.dtsi b/arch/powerpc/boot/dts/p1020si.dtsi index 5514e1d..14dff69 100644 --- a/arch/powerpc/boot/dts/p1020si.dtsi +++ b/arch/powerpc/boot/dts/p1020si.dtsi @@ -200,6 +200,7 @@ compatible = "fsl,etsec2"; fsl,num_rx_queues = <0x8>; fsl,num_tx_queues = <0x8>; + fsl,magic-packet; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>; @@ -226,6 +227,7 @@ compatible = "fsl,etsec2"; fsl,num_rx_queues = <0x8>; fsl,num_tx_queues = <0x8>; + fsl,magic-packet; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>; @@ -252,6 +254,7 @@ compatible = "fsl,etsec2"; fsl,num_rx_queues = <0x8>; fsl,num_tx_queues = <0x8>; + fsl,magic-packet; local-mac-address = [ 00 00 00 00 00 00 ]; interrupt-parent = <&mpic>;
All eTSEC2 controllers support waking on magic packet so fixup device tree to report that. Signed-off-by: Kumar Gala <galak@kernel.crashing.org> --- arch/powerpc/boot/dts/p1020si.dtsi | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)