diff mbox series

[PATCH/next,v3,1/1] package/font-awesome: make it compatible with fontconfig

Message ID 20200226090939.1810498-1-fontaine.fabrice@gmail.com
State Accepted
Headers show
Series [PATCH/next,v3,1/1] package/font-awesome: make it compatible with fontconfig | expand

Commit Message

Fabrice Fontaine Feb. 26, 2020, 9:09 a.m. UTC 
This commit installs font-awesome in the standard fonts directory
making it available systemwide.

Thanks to baruch for his technical critique.
Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
Changes v2 -> v3 (after review of Baruch Siach):
 - Create a symlink to avoid duplication

Changes v1 -> v2 (after review of Arnout Vandecappelle):
 - Keep only install of otf file and don't remove install of other files

 package/font-awesome/font-awesome.mk | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Dec. 30, 2021, 2:20 p.m. UTC | #1 
On Wed, 26 Feb 2020 10:09:39 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> This commit installs font-awesome in the standard fonts directory
> making it available systemwide.
> 
> Thanks to baruch for his technical critique.
> Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v2 -> v3 (after review of Baruch Siach):
>  - Create a symlink to avoid duplication

I have applied with a reworked commit log. That being said, I am not
sure it was really the "best" solution. It probably would be nicer to
install the fonts usable by fontconfig directly in /usr/share/fonts/,
keeping the rest in /usr/share/font-awesome/.

Best regards,

Thomas
Peter Korsgaard Jan. 26, 2022, 12:26 p.m. UTC | #2 
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Wed, 26 Feb 2020 10:09:39 +0100
 > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

 >> This commit installs font-awesome in the standard fonts directory
 >> making it available systemwide.
 >> 
 >> Thanks to baruch for his technical critique.
 >> Signed-off-by: Benjamin Calderon <benj.calderon@gmail.com>
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> Changes v2 -> v3 (after review of Baruch Siach):
 >> - Create a symlink to avoid duplication

 > I have applied with a reworked commit log. That being said, I am not
 > sure it was really the "best" solution. It probably would be nicer to
 > install the fonts usable by fontconfig directly in /usr/share/fonts/,
 > keeping the rest in /usr/share/font-awesome/.

Committed to 2021.02.x and 2021.11.x, thanks.
diff mbox series

Patch

diff --git a/package/font-awesome/font-awesome.mk b/package/font-awesome/font-awesome.mk
index 666346be0e..5211ac22a5 100644
--- a/package/font-awesome/font-awesome.mk
+++ b/package/font-awesome/font-awesome.mk
@@ -13,6 +13,8 @@  define FONT_AWESOME_INSTALL_TARGET_CMDS
 	mkdir -p $(TARGET_DIR)/usr/share/font-awesome/
 	$(foreach d,$(FONT_AWESOME_DIRECTORIES_LIST),\
 		cp -dpfr $(@D)/$(d) $(TARGET_DIR)/usr/share/font-awesome$(sep))
+	mkdir -p $(TARGET_DIR)/usr/share/fonts/
+	ln -sf ../font-awesome $(TARGET_DIR)/usr/share/fonts/font-awesome
 endef
 
 $(eval $(generic-package))