libiberty: fix psignal parameter type

When libiberty defines psignal, it doesn't use the canonical signature.
This came up as a problem in a configuration where libiberty wants to
define psignal itself, but the build environment's <signal.h> declares
it too.  

This was a --with-newlib configuration using the newlib trunk, where newlib
does define psignal (and strsignal, among other things), but libiberty's
configure thinks it knows exactly what newlib does and doesn't define
without checking.  This hard-coding seems unwise to me, exactly because of
the potential for cases like this, where newlib's set of available
functions changes over time.

I think the fragility of that hard-coding ought to be addressed somehow.
But regardless, this change alleviates the immediate problem, and is
otherwise harmless.


Thanks,
Roland


libiberty/
2011-10-18  Roland McGrath  <mcgrathr@google.com>

	* strsignal.c (psignal): Use const second in parameter type.
	* functions.texi: Updated.

On Tue, Oct 18, 2011 at 9:49 AM, Roland McGrath <mcgrathr@google.com> wrote:
> When libiberty defines psignal, it doesn't use the canonical signature.
> This came up as a problem in a configuration where libiberty wants to
> define psignal itself, but the build environment's <signal.h> declares
> it too.
>
> This was a --with-newlib configuration using the newlib trunk, where newlib
> does define psignal (and strsignal, among other things), but libiberty's
> configure thinks it knows exactly what newlib does and doesn't define
> without checking.  This hard-coding seems unwise to me, exactly because of
> the potential for cases like this, where newlib's set of available
> functions changes over time.

libiberty is no longer compiled for the target so this should never
happen really.

Thanks,
Andrew Pinski

On Tue, Oct 18, 2011 at 9:50 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> libiberty is no longer compiled for the target so this should never
> happen really.

I see.  I was indeed using an older source base, and just noticed that all
the offending configure logic was still the same.  Perhaps all the
--with-newlib logic in libiberty's configure should be removed now?

Regardless, the psignal change is an appropriate cleanup in its own right.


Thanks,
Roland

On Tue, Oct 18, 2011 at 9:49 AM, Roland McGrath <mcgrathr@google.com> wrote:
>
> libiberty/
> 2011-10-18  Roland McGrath  <mcgrathr@google.com>
>
>        * strsignal.c (psignal): Use const second in parameter type.
>        * functions.texi: Updated.

This is OK.

Thanks.

Ian

On Tue, Oct 18, 2011 at 10:18 AM, Ian Lance Taylor <iant@google.com> wrote:
> On Tue, Oct 18, 2011 at 9:49 AM, Roland McGrath <mcgrathr@google.com> wrote:
>>
>> libiberty/
>> 2011-10-18  Roland McGrath  <mcgrathr@google.com>
>>
>>        * strsignal.c (psignal): Use const second in parameter type.
>>        * functions.texi: Updated.
>
> This is OK.

Thanks.  But last I checked, I'm not a GCC committer.
So somebody has to do it for me.


Thanks,
Roland