| Message ID | 20211116074130.107554-9-yoshihiro.shimoda.uh@renesas.com |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | treewide: Initial support for R-Car S4-8 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success | |
| robh/checkpatch | success | |
| robh/dt-meta-schema | success | |
| robh/dtbs-check | success |
Hi Shimoda-san, On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> wrote: > R-Car S4-8 (R8A779F0) SoC has the R-Car Gen4 compatible SCIF ports, > so document the SoC specific bindings. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> Thanks for your patch! > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml > @@ -64,6 +64,12 @@ properties: > - const: renesas,rcar-gen3-scif # R-Car Gen3 and RZ/G2 > - const: renesas,scif # generic SCIF compatible UART > > + - items: > + - enum: > + - renesas,scif-r8a779f0 # R-Car S4-8 > + - const: renesas,rcar-gen4-scif # R-Car Gen4 > + - const: renesas,scif # generic SCIF compatible UART > + OK. > - items: > - enum: > - renesas,scif-r9a07g044 # RZ/G2{L,LC} Please add "renesas,rcar-gen4-scif" to the block that requires resets. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Geert-san, Thank you for your review! > From: Geert Uytterhoeven, Sent: Friday, November 19, 2021 3:56 AM > > Hi Shimoda-san, > > On Tue, Nov 16, 2021 at 8:42 AM Yoshihiro Shimoda > <yoshihiro.shimoda.uh@renesas.com> wrote: > > R-Car S4-8 (R8A779F0) SoC has the R-Car Gen4 compatible SCIF ports, > > so document the SoC specific bindings. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> > > Thanks for your patch! > > > --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml > > +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml <snip> > > - items: > > - enum: > > - renesas,scif-r9a07g044 # RZ/G2{L,LC} > > Please add "renesas,rcar-gen4-scif" to the block that requires resets. Oops. I got it. I'll add it in v2. Best regards, Yoshihiro Shimoda
diff --git a/Documentation/devicetree/bindings/serial/renesas,scif.yaml b/Documentation/devicetree/bindings/serial/renesas,scif.yaml index 6b8731f7f2fb..14602b720cc0 100644 --- a/Documentation/devicetree/bindings/serial/renesas,scif.yaml +++ b/Documentation/devicetree/bindings/serial/renesas,scif.yaml @@ -64,6 +64,12 @@ properties: - const: renesas,rcar-gen3-scif # R-Car Gen3 and RZ/G2 - const: renesas,scif # generic SCIF compatible UART + - items: + - enum: + - renesas,scif-r8a779f0 # R-Car S4-8 + - const: renesas,rcar-gen4-scif # R-Car Gen4 + - const: renesas,scif # generic SCIF compatible UART + - items: - enum: - renesas,scif-r9a07g044 # RZ/G2{L,LC}
R-Car S4-8 (R8A779F0) SoC has the R-Car Gen4 compatible SCIF ports, so document the SoC specific bindings. Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com> --- Documentation/devicetree/bindings/serial/renesas,scif.yaml | 6 ++++++ 1 file changed, 6 insertions(+)