Message ID | 20211102140558.32460-8-sinthu.raja@ti.com |
---|---|
State | Changes Requested |
Delegated to: | Tom Rini |
Headers | show |
Series | Add support for J721E SK | expand |
On Tue, Nov 02, 2021 at 07:35:48PM +0530, Sinthu Raja wrote: > From: Sinthu Raja <sinthu.raja@ti.com> > > j721e-sk doesn't have any daughter cards, so disable daughter > card probing inside board_late_init() and spl_board_init() for > j721e-sk. > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > --- > > Changes in V2: > * J721E EAIK board name is changed to J721E SK, rename all occurrences of eaik > to sk. > > board/ti/j721e/evm.c | 9 ++++++--- > 1 file changed, 6 insertions(+), 3 deletions(-) > > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c > index 9d4609cfe9..cb491ad950 100644 > --- a/board/ti/j721e/evm.c > +++ b/board/ti/j721e/evm.c > @@ -434,7 +434,8 @@ int board_late_init(void) > setup_serial(); > > /* Check for and probe any plugged-in daughtercards */ > - probe_daughtercards(); > + if (!board_is_j721e_sk()) > + probe_daughtercards(); This should be a positive check for the board(s) which can even have daughtercards.
Hi Tom, On Mon, Nov 8, 2021 at 9:22 PM Tom Rini <trini@konsulko.com> wrote: > > On Tue, Nov 02, 2021 at 07:35:48PM +0530, Sinthu Raja wrote: > > From: Sinthu Raja <sinthu.raja@ti.com> > > > > j721e-sk doesn't have any daughter cards, so disable daughter > > card probing inside board_late_init() and spl_board_init() for > > j721e-sk. > > > > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com> > > --- > > > > Changes in V2: > > * J721E EAIK board name is changed to J721E SK, rename all occurrences of eaik > > to sk. > > > > board/ti/j721e/evm.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c > > index 9d4609cfe9..cb491ad950 100644 > > --- a/board/ti/j721e/evm.c > > +++ b/board/ti/j721e/evm.c > > @@ -434,7 +434,8 @@ int board_late_init(void) > > setup_serial(); > > > > /* Check for and probe any plugged-in daughtercards */ > > - probe_daughtercards(); > > + if (!board_is_j721e_sk()) > > + probe_daughtercards(); > > This should be a positive check for the board(s) which can even have > daughtercards. Agreed, will update as positive check. Regards Sinthu Raja > > -- > Tom
diff --git a/board/ti/j721e/evm.c b/board/ti/j721e/evm.c index 9d4609cfe9..cb491ad950 100644 --- a/board/ti/j721e/evm.c +++ b/board/ti/j721e/evm.c @@ -434,7 +434,8 @@ int board_late_init(void) setup_serial(); /* Check for and probe any plugged-in daughtercards */ - probe_daughtercards(); + if (!board_is_j721e_sk()) + probe_daughtercards(); } if (board_is_j7200_som()) @@ -453,8 +454,10 @@ void spl_board_init(void) if ((IS_ENABLED(CONFIG_TARGET_J721E_A72_EVM) || IS_ENABLED(CONFIG_TARGET_J7200_A72_EVM)) && - IS_ENABLED(CONFIG_TI_I2C_BOARD_DETECT)) - probe_daughtercards(); + IS_ENABLED(CONFIG_TI_I2C_BOARD_DETECT)) { + if (!board_is_j721e_sk()) + probe_daughtercards(); + } #ifdef CONFIG_ESM_K3 if (board_ti_k3_is("J721EX-PM2-SOM")) {