Message ID | 201110131603.34443.bzolnier@gmail.com |
---|---|
State | Not Applicable |
Delegated to: | David Miller |
Headers | show |
On Thu, 13 Oct 2011 16:03:34 +0200 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > Subject: [PATCH] pata_oldpiix: enable parallel scan > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> Have you tested this. When I talked with Intel people about parallel scanning nobody in Intel I could find could answer whether it was safe on the ancient PIIX versions. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan Cox wrote: > On Thu, 13 Oct 2011 16:03:34 +0200 > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Subject: [PATCH] pata_oldpiix: enable parallel scan > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > Have you tested this. When I talked with Intel people about parallel > scanning nobody in Intel I could find could answer whether it was safe on > the ancient PIIX versions. No, it wasn't tested on the real hardware. I think it should be in libata-dev or -mm/-next for rather long time.. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 13 Oct 2011 18:06:08 +0200 Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > Alan Cox wrote: > > > On Thu, 13 Oct 2011 16:03:34 +0200 > > Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> wrote: > > > > > From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > > Subject: [PATCH] pata_oldpiix: enable parallel scan > > > > > > Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com> > > > > Have you tested this. When I talked with Intel people about parallel > > scanning nobody in Intel I could find could answer whether it was safe on > > the ancient PIIX versions. > > No, it wasn't tested on the real hardware. > > I think it should be in libata-dev or -mm/-next for rather long time.. I don't see it's worth adding, its near impossible to test and its for old hardware that doesn't fast boot anyway. Really it's the netbook generation devices where this matters. -- To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Index: b/drivers/ata/pata_oldpiix.c =================================================================== --- a/drivers/ata/pata_oldpiix.c +++ b/drivers/ata/pata_oldpiix.c @@ -258,7 +258,8 @@ static int oldpiix_init_one (struct pci_ ata_print_version_once(&pdev->dev, DRV_VERSION); - return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, 0); + return ata_pci_bmdma_init_one(pdev, ppi, &oldpiix_sht, NULL, + ATA_HOST_PARALLEL_SCAN); } static const struct pci_device_id oldpiix_pci_tbl[] = {