| Message ID | 201109231514.02174.hartleys@visionengravers.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Sep 23, 2011 at 03:14:01PM -0700, H Hartley Sweeten wrote: > The function declaration in ext4.h is already marked extern. The function > definition should not have the tag. > > This quiets the sparse noise: > > warning: function 'ext4_flush_completed_IO' with external linkage has definition > > Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> > Cc: "Theodore Ts'o" <tytso@mit.edu> > Cc: Andreas Dilger <adilger.kernel@dilger.ca> Thanks, applied. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/fs/ext4/fsync.c b/fs/ext4/fsync.c index 036f78f..c942924 100644 --- a/fs/ext4/fsync.c +++ b/fs/ext4/fsync.c @@ -75,7 +75,7 @@ static void dump_completed_IO(struct inode * inode) * to written. * The function return the number of pending IOs on success. */ -extern int ext4_flush_completed_IO(struct inode *inode) +int ext4_flush_completed_IO(struct inode *inode) { ext4_io_end_t *io; struct ext4_inode_info *ei = EXT4_I(inode);
The function declaration in ext4.h is already marked extern. The function definition should not have the tag. This quiets the sparse noise: warning: function 'ext4_flush_completed_IO' with external linkage has definition Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com> Cc: "Theodore Ts'o" <tytso@mit.edu> Cc: Andreas Dilger <adilger.kernel@dilger.ca> --- -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html