Message ID | 1316782071-8988-1-git-send-email-holger.brunck@keymile.com |
---|---|
State | Accepted |
Headers | show |
On 09/23/2011 08:47 AM, Holger Brunck wrote: > This prevents u-boot to display during bootime: > Out: serial > Err: serial > Net: UEC3Warning: failed to set MAC address > > Now corrected and it will display: > Out: serial > Err: serial > Net: UEC3 > Warning: failed to set MAC address > > Signed-off-by: Holger Brunck<holger.brunck@keymile.com> Acked-by: Philip Balister <philip@opensdr.com> But, when i submitted the same patch, I was told this is not the right way to solve the problem. I would still like to see this patch go in until someone has time to rewrite the problem section of code. Philip > --- > net/eth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/eth.c b/net/eth.c > index 02baa37..1c0c780 100644 > --- a/net/eth.c > +++ b/net/eth.c > @@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis) > puts("\nWarning: eth device name has a space!\n"); > > if (eth_write_hwaddr(dev, "eth", eth_number)) > - puts("Warning: failed to set MAC address\n"); > + puts("\nWarning: failed to set MAC address\n"); > > eth_number++; > dev = dev->next;
On Monday, September 26, 2011 10:24:54 Philip Balister wrote: > On 09/23/2011 08:47 AM, Holger Brunck wrote: > > This prevents u-boot to display during bootime: > > Out: serial > > Err: serial > > Net: UEC3Warning: failed to set MAC address > > > > Now corrected and it will display: > > Out: serial > > Err: serial > > Net: UEC3 > > Warning: failed to set MAC address > > > > Signed-off-by: Holger Brunck<holger.brunck@keymile.com> > > Acked-by: Philip Balister <philip@opensdr.com> > > But, when i submitted the same patch, I was told this is not the right > way to solve the problem. I would still like to see this patch go in > until someone has time to rewrite the problem section of code. i don't think it is the right way long term, but short term, i think it's correct wrt the surrounding code. -mike
On 09/26/2011 06:07 PM, Mike Frysinger wrote: > On Monday, September 26, 2011 10:24:54 Philip Balister wrote: >> On 09/23/2011 08:47 AM, Holger Brunck wrote: >>> This prevents u-boot to display during bootime: >>> Out: serial >>> Err: serial >>> Net: UEC3Warning: failed to set MAC address >>> >>> Now corrected and it will display: >>> Out: serial >>> Err: serial >>> Net: UEC3 >>> Warning: failed to set MAC address >>> >>> Signed-off-by: Holger Brunck<holger.brunck@keymile.com> >> >> Acked-by: Philip Balister <philip@opensdr.com> >> >> But, when i submitted the same patch, I was told this is not the right >> way to solve the problem. I would still like to see this patch go in >> until someone has time to rewrite the problem section of code. > > i don't think it is the right way long term, but short term, i think it's > correct wrt the surrounding code. Yes I agree. It never meant to be more than a bootlog improvement. The root cause should be fixed in the long term. Regards Holger
Dear Holger Brunck, In message <1316782071-8988-1-git-send-email-holger.brunck@keymile.com> you wrote: > This prevents u-boot to display during bootime: > Out: serial > Err: serial > Net: UEC3Warning: failed to set MAC address > > Now corrected and it will display: > Out: serial > Err: serial > Net: UEC3 > Warning: failed to set MAC address > > Signed-off-by: Holger Brunck <holger.brunck@keymile.com> > --- > net/eth.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) Applied, thanks. Best regards, Wolfgang Denk
diff --git a/net/eth.c b/net/eth.c index 02baa37..1c0c780 100644 --- a/net/eth.c +++ b/net/eth.c @@ -302,7 +302,7 @@ int eth_initialize(bd_t *bis) puts("\nWarning: eth device name has a space!\n"); if (eth_write_hwaddr(dev, "eth", eth_number)) - puts("Warning: failed to set MAC address\n"); + puts("\nWarning: failed to set MAC address\n"); eth_number++; dev = dev->next;
This prevents u-boot to display during bootime: Out: serial Err: serial Net: UEC3Warning: failed to set MAC address Now corrected and it will display: Out: serial Err: serial Net: UEC3 Warning: failed to set MAC address Signed-off-by: Holger Brunck <holger.brunck@keymile.com> --- net/eth.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)