| Message ID | 1316206180-6375-10-git-send-email-sandeen@redhat.com |
|---|---|
| State | Accepted, archived |
| Headers | show |
On Fri, Sep 16, 2011 at 03:49:24PM -0500, Eric Sandeen wrote: > Specifying the "-n" option to uuidd would incorrectly > fall through to the "-p" case, and assign that number to > the pidfile_path. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> Applied, thanks. Can you do me a favor and make sure this gets fixed in util-linux-ng as well? - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 9/16/11 5:54 PM, Ted Ts'o wrote: > On Fri, Sep 16, 2011 at 03:49:24PM -0500, Eric Sandeen wrote: >> Specifying the "-n" option to uuidd would incorrectly >> fall through to the "-p" case, and assign that number to >> the pidfile_path. >> >> Signed-off-by: Eric Sandeen <sandeen@redhat.com> > > Applied, thanks. > > Can you do me a favor and make sure this gets fixed in util-linux-ng > as well? sure thing -eric > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-ext4" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/misc/uuidd.c b/misc/uuidd.c index 89bff72..912773a 100644 --- a/misc/uuidd.c +++ b/misc/uuidd.c @@ -472,6 +472,7 @@ int main(int argc, char **argv) fprintf(stderr, _("Bad number: %s\n"), optarg); exit(1); } + break; case 'p': pidfile_path = optarg; drop_privs = 1;
Specifying the "-n" option to uuidd would incorrectly fall through to the "-p" case, and assign that number to the pidfile_path. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- misc/uuidd.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)