| Message ID | 1314283611-22274-1-git-send-email-balajitk@ti.com |
|---|---|
| State | Accepted |
| Commit | ecd9af88ac70dec7f0ea33613da2f889cf19e433 |
| Headers | show |
Isn't high-capacity capability also connected to board capabilities? Is it safe to enable this across all users of this driver? Andy On Thu, Aug 25, 2011 at 9:46 AM, Balaji T K <balajitk@ti.com> wrote: > Enable high capacity to host capability. > Fixes eMMC detection on boot from MMC/SD card. > > Signed-off-by: Balaji T K <balajitk@ti.com> > Signed-off-by: Aneesh V <aneesh@ti.com> > --- > drivers/mmc/omap_hsmmc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index ef12ecd..6627905 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) > return 1; > } > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS; > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS | > + MMC_MODE_HC; > > mmc->f_min = 400000; > mmc->f_max = 52000000; > -- > 1.7.0.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
On Sun, Sep 4, 2011 at 1:49 AM, Andy Fleming <afleming@gmail.com> wrote: > Isn't high-capacity capability also connected to board capabilities? > Is it safe to enable this across all users of this driver? Hi, Host contoller IP supports High capacity. If High capacity card is connected to the board, then this flag is needed for card detection. This patch is tested on OMAP4430 platform. Haven't tested on omap3 but should be safe. > > Andy > > On Thu, Aug 25, 2011 at 9:46 AM, Balaji T K <balajitk@ti.com> wrote: >> Enable high capacity to host capability. >> Fixes eMMC detection on boot from MMC/SD card. >> >> Signed-off-by: Balaji T K <balajitk@ti.com> >> Signed-off-by: Aneesh V <aneesh@ti.com> >> --- >> drivers/mmc/omap_hsmmc.c | 3 ++- >> 1 files changed, 2 insertions(+), 1 deletions(-) >> >> diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c >> index ef12ecd..6627905 100644 >> --- a/drivers/mmc/omap_hsmmc.c >> +++ b/drivers/mmc/omap_hsmmc.c >> @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) >> return 1; >> } >> mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; >> - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS; >> + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS | >> + MMC_MODE_HC; >> >> mmc->f_min = 400000; >> mmc->f_max = 52000000; >> -- >> 1.7.0.4 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> >
On Thu, Aug 25, 2011 at 7:46 AM, Balaji T K <balajitk@ti.com> wrote: > Enable high capacity to host capability. > Fixes eMMC detection on boot from MMC/SD card. > > Signed-off-by: Balaji T K <balajitk@ti.com> > Signed-off-by: Aneesh V <aneesh@ti.com> > --- > drivers/mmc/omap_hsmmc.c | 3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > index ef12ecd..6627905 100644 > --- a/drivers/mmc/omap_hsmmc.c > +++ b/drivers/mmc/omap_hsmmc.c > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) > return 1; > } > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS; > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS | > + MMC_MODE_HC; > > mmc->f_min = 400000; > mmc->f_max = 52000000; > -- I tested a similar patch on a Tegra2 system, so: Acked-by: Simon Glass <sjg@chromium.org> > 1.7.0.4 > > _______________________________________________ > U-Boot mailing list > U-Boot@lists.denx.de > http://lists.denx.de/mailman/listinfo/u-boot >
> > On Thu, Aug 25, 2011 at 7:46 AM, Balaji T K <balajitk@ti.com> wrote: > > Enable high capacity to host capability. > > Fixes eMMC detection on boot from MMC/SD card. > > > > Signed-off-by: Balaji T K <balajitk@ti.com> > > Signed-off-by: Aneesh V <aneesh@ti.com> > > --- > > drivers/mmc/omap_hsmmc.c | 3 ++- > > 1 files changed, 2 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > > index ef12ecd..6627905 100644 > > --- a/drivers/mmc/omap_hsmmc.c > > +++ b/drivers/mmc/omap_hsmmc.c > > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) > > return 1; > > } > > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; > > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | > MMC_MODE_HS; > > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS > | > > + MMC_MODE_HC; > > > > mmc->f_min = 400000; > > mmc->f_max = 52000000; > > -- > > I tested a similar patch on a Tegra2 system, so: > > Acked-by: Simon Glass <sjg@chromium.org> > If it is OK with Andy, I can apply this to u-boot-ti. --Sandeep
On Wed, Sep 14, 2011 at 7:43 PM, Paulraj, Sandeep <s-paulraj@ti.com> wrote: > > >> >> On Thu, Aug 25, 2011 at 7:46 AM, Balaji T K <balajitk@ti.com> wrote: >> > Enable high capacity to host capability. >> > Fixes eMMC detection on boot from MMC/SD card. >> > >> > Signed-off-by: Balaji T K <balajitk@ti.com> >> > Signed-off-by: Aneesh V <aneesh@ti.com> >> > --- >> > drivers/mmc/omap_hsmmc.c | 3 ++- >> > 1 files changed, 2 insertions(+), 1 deletions(-) >> > >> > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c >> > index ef12ecd..6627905 100644 >> > --- a/drivers/mmc/omap_hsmmc.c >> > +++ b/drivers/mmc/omap_hsmmc.c >> > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) >> > return 1; >> > } >> > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; >> > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | >> MMC_MODE_HS; >> > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS >> | >> > + MMC_MODE_HC; >> > >> > mmc->f_min = 400000; >> > mmc->f_max = 52000000; >> > -- >> >> I tested a similar patch on a Tegra2 system, so: >> >> Acked-by: Simon Glass <sjg@chromium.org> >> > > If it is OK with Andy, I can apply this to u-boot-ti. > > --Sandeep > Hi Andy, I tested this on OMAP3 beagle board with 512MB and 4GB card. mmc read and write is OK. Can you pull this patch ?
> > > > > >> > >> On Thu, Aug 25, 2011 at 7:46 AM, Balaji T K <balajitk@ti.com> wrote: > >> > Enable high capacity to host capability. > >> > Fixes eMMC detection on boot from MMC/SD card. > >> > > >> > Signed-off-by: Balaji T K <balajitk@ti.com> > >> > Signed-off-by: Aneesh V <aneesh@ti.com> > >> > --- > >> > drivers/mmc/omap_hsmmc.c | 3 ++- > >> > 1 files changed, 2 insertions(+), 1 deletions(-) > >> > > >> > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > >> > index ef12ecd..6627905 100644 > >> > --- a/drivers/mmc/omap_hsmmc.c > >> > +++ b/drivers/mmc/omap_hsmmc.c > >> > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) > >> > return 1; > >> > } > >> > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | > MMC_VDD_165_195; > >> > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | > >> MMC_MODE_HS; > >> > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | > MMC_MODE_HS > >> | > >> > + MMC_MODE_HC; > >> > > >> > mmc->f_min = 400000; > >> > mmc->f_max = 52000000; > >> > -- > >> > >> I tested a similar patch on a Tegra2 system, so: > >> > >> Acked-by: Simon Glass <sjg@chromium.org> > >> > > > > If it is OK with Andy, I can apply this to u-boot-ti. > > > > --Sandeep > > > Hi Andy, > > I tested this on OMAP3 beagle board with 512MB and 4GB card. > mmc read and write is OK. Can you pull this patch ? Or please give an ACK, so that I can pull it into u-boot-ti. --Sandeep
> > On Wed, Sep 14, 2011 at 7:43 PM, Paulraj, Sandeep <s-paulraj@ti.com> > wrote: > > > > > >> > >> On Thu, Aug 25, 2011 at 7:46 AM, Balaji T K <balajitk@ti.com> wrote: > >> > Enable high capacity to host capability. > >> > Fixes eMMC detection on boot from MMC/SD card. > >> > > >> > Signed-off-by: Balaji T K <balajitk@ti.com> > >> > Signed-off-by: Aneesh V <aneesh@ti.com> > >> > --- > >> > drivers/mmc/omap_hsmmc.c | 3 ++- > >> > 1 files changed, 2 insertions(+), 1 deletions(-) > >> > > >> > diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c > >> > index ef12ecd..6627905 100644 > >> > --- a/drivers/mmc/omap_hsmmc.c > >> > +++ b/drivers/mmc/omap_hsmmc.c > >> > @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) > >> > return 1; > >> > } > >> > mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | > MMC_VDD_165_195; > >> > - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | > >> MMC_MODE_HS; > >> > + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | > MMC_MODE_HS > >> | > >> > + MMC_MODE_HC; > >> > > >> > mmc->f_min = 400000; > >> > mmc->f_max = 52000000; > >> > -- > >> > >> I tested a similar patch on a Tegra2 system, so: > >> > >> Acked-by: Simon Glass <sjg@chromium.org> > >> > > > > If it is OK with Andy, I can apply this to u-boot-ti. > > > > --Sandeep > > > Hi Andy, > > I tested this on OMAP3 beagle board with 512MB and 4GB card. > mmc read and write is OK. Can you pull this patch ? Pushed to u-boot-ti next
diff --git a/drivers/mmc/omap_hsmmc.c b/drivers/mmc/omap_hsmmc.c index ef12ecd..6627905 100644 --- a/drivers/mmc/omap_hsmmc.c +++ b/drivers/mmc/omap_hsmmc.c @@ -461,7 +461,8 @@ int omap_mmc_init(int dev_index) return 1; } mmc->voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195; - mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS; + mmc->host_caps = MMC_MODE_4BIT | MMC_MODE_HS_52MHz | MMC_MODE_HS | + MMC_MODE_HC; mmc->f_min = 400000; mmc->f_max = 52000000;