| Message ID | 65880dfc6b107ab09f566edec65c6d4ccc71377f.1617806959.git.stefan@agner.ch |
|---|---|
| State | Changes Requested, archived |
| Delegated to: | Neil Armstrong |
| Headers | show |
| Series | arm64: dts: meson: odroidc2: readd PHY reset properties | expand |
On 07/04/2021 16:49, Stefan Agner wrote: > The sync of the device tree and dt-bindings from Linux v5.6-rc2 > 11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some > ODROID-C2. The PHY seems to need proper reset timing to be functional > in U-Boot and Linux afterwards. Readd the old PHY reset bindings for > dwmac until we support the new bindings in the PHY node. > > Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2") > Signed-off-by: Stefan Agner <stefan@agner.ch> > --- > arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts > index 70fcfb7b06..8b80bbc90b 100644 > --- a/arch/arm/dts/meson-gxbb-odroidc2.dts > +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts > @@ -188,6 +188,10 @@ > phy-handle = <ð_phy0>; > phy-mode = "rgmii"; > > + snps,reset-gpio = <&gpio GPIOZ_14 0>; > + snps,reset-delays-us = <0 10000 1000000>; > + snps,reset-active-low; > + > amlogic,tx-delay-ns = <2>; > > mdio { > Thanks, it's ok but please add the changes to arch/arm/dts/meson-gxbb-odroidc2-u-boot.dtsi instead, we want to keep the DT files in sync with Linux, local u-boot changes must go into the -u-boot.dtsi files. Neil
diff --git a/arch/arm/dts/meson-gxbb-odroidc2.dts b/arch/arm/dts/meson-gxbb-odroidc2.dts index 70fcfb7b06..8b80bbc90b 100644 --- a/arch/arm/dts/meson-gxbb-odroidc2.dts +++ b/arch/arm/dts/meson-gxbb-odroidc2.dts @@ -188,6 +188,10 @@ phy-handle = <ð_phy0>; phy-mode = "rgmii"; + snps,reset-gpio = <&gpio GPIOZ_14 0>; + snps,reset-delays-us = <0 10000 1000000>; + snps,reset-active-low; + amlogic,tx-delay-ns = <2>; mdio {
The sync of the device tree and dt-bindings from Linux v5.6-rc2 11a48a5a18c6 ("Linux 5.6-rc2") causes Ethernet to break on some ODROID-C2. The PHY seems to need proper reset timing to be functional in U-Boot and Linux afterwards. Readd the old PHY reset bindings for dwmac until we support the new bindings in the PHY node. Fixes: dd5f2351e99a ("arm64: dts: meson: sync dt and bindings from v5.6-rc2") Signed-off-by: Stefan Agner <stefan@agner.ch> --- arch/arm/dts/meson-gxbb-odroidc2.dts | 4 ++++ 1 file changed, 4 insertions(+)