| Message ID | 283210da-b281-2dd7-6ef7-b31e81e72e01@huawei.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | misc: remove useless code in set_inode_xattr() | expand |
ping... On 2021/2/26 9:22, Zhiqiang Liu wrote: > > In set_inode_xattr(), there are two returns as follows, > - > return retval; > return 0; > - > Here, we remove useless 'return 0;' code. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> > --- > misc/create_inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/misc/create_inode.c b/misc/create_inode.c > index 54d8d343..d62e1cb4 100644 > --- a/misc/create_inode.c > +++ b/misc/create_inode.c > @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino, > retval = retval ? retval : close_retval; > } > return retval; > - return 0; > } > #else /* HAVE_LLISTXATTR */ > static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)), >
On 2021/2/26 9:22, Zhiqiang Liu wrote: > > In set_inode_xattr(), there are two returns as follows, > - > return retval; > return 0; > - > Here, we remove useless 'return 0;' code. > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> Reviewed-by: Andreas Dilger <adilger@dilger.ca> > --- > misc/create_inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/misc/create_inode.c b/misc/create_inode.c > index 54d8d343..d62e1cb4 100644 > --- a/misc/create_inode.c > +++ b/misc/create_inode.c > @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino, > retval = retval ? retval : close_retval; > } > return retval; > - return 0; > } > #else /* HAVE_LLISTXATTR */ > static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)), > Cheers, Andreas
On Wed, Mar 03, 2021 at 01:20:33PM -0700, Andreas Dilger wrote: > On 2021/2/26 9:22, Zhiqiang Liu wrote: > > > > In set_inode_xattr(), there are two returns as follows, > > - > > return retval; > > return 0; > > - > > Here, we remove useless 'return 0;' code. > > > > Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> > > Reviewed-by: Andreas Dilger <adilger@dilger.ca> Thanks, applied. - Ted
diff --git a/misc/create_inode.c b/misc/create_inode.c index 54d8d343..d62e1cb4 100644 --- a/misc/create_inode.c +++ b/misc/create_inode.c @@ -234,7 +234,6 @@ static errcode_t set_inode_xattr(ext2_filsys fs, ext2_ino_t ino, retval = retval ? retval : close_retval; } return retval; - return 0; } #else /* HAVE_LLISTXATTR */ static errcode_t set_inode_xattr(ext2_filsys fs EXT2FS_ATTR((unused)),
In set_inode_xattr(), there are two returns as follows, - return retval; return 0; - Here, we remove useless 'return 0;' code. Signed-off-by: Zhiqiang Liu <liuzhiqiang26@huawei.com> --- misc/create_inode.c | 1 - 1 file changed, 1 deletion(-)