| Message ID | 1315599834.2076.27.camel@adamo |
|---|---|
| State | New |
| Headers | show |
On 09/09/2011 01:23 PM, Leann Ogasawara wrote: > Hi All, > > http://bugs.launchpad.net/bugs/818933 > > It's been reported that the Dell Optiplex 790 doesn't reboot unless > using reboot=pci. The following patch resolves this issue and has been > successfully tested by multiple users. Upstream is unfortunately not > accepting any additional quirk patches like this as they would prefer to > migrate to a more systematic approach. > > So with Kernel Freeze looming for Oneiric, the patch being system > specific (ie low risk of regression), precedence for similar quirk > patches already existing, and having received positive test results, I > feel it should be carried as a SAUCE patch until a more systematic > approach can be found which upstream will accept. > > As a side note, I'm starting to accumulate a handful of these reboot > quirks for Dell Optiplex and Latitude systems. I'm just waiting on test > confirmation before submitting the patches here. > > Thanks, > Leann > > From 8444722f96d3b0875a0044683dc1c1cd92c0097a Mon Sep 17 00:00:00 2001 > From: Leann Ogasawara<leann.ogasawara@canonical.com> > Date: Thu, 1 Sep 2011 07:44:30 -0700 > Subject: [PATCH] UBUNTU: SAUCE: x86: reboot: Make Dell Optiplex 790 use reboot=pci > > BugLink: http://bugs.launchpad.net/bugs/818933 > > The Dell Optiplex 790 doesn't reboot unless reboot=pci is set. > > Signed-off-by: Leann Ogasawara<leann.ogasawara@canonical.com> > --- > arch/x86/kernel/reboot.c | 8 ++++++++ > 1 files changed, 8 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c > index 6ac6e12..3906b56 100644 > --- a/arch/x86/kernel/reboot.c > +++ b/arch/x86/kernel/reboot.c > @@ -451,6 +451,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { > DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"), > }, > }, > + { /* Handle problems with rebooting on the OptiPlex 790. */ > + .callback = set_pci_reboot, > + .ident = "Dell OptiPlex 790", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), > + DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 790"), > + }, > + }, > { } > }; >
diff --git a/arch/x86/kernel/reboot.c b/arch/x86/kernel/reboot.c index 6ac6e12..3906b56 100644 --- a/arch/x86/kernel/reboot.c +++ b/arch/x86/kernel/reboot.c @@ -451,6 +451,14 @@ static struct dmi_system_id __initdata pci_reboot_dmi_table[] = { DMI_MATCH(DMI_PRODUCT_NAME, "Latitude E6520"), }, }, + { /* Handle problems with rebooting on the OptiPlex 790. */ + .callback = set_pci_reboot, + .ident = "Dell OptiPlex 790", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."), + DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 790"), + }, + }, { } };