diff mbox

[U-Boot] OMAP3: Overo: Update GPMC timing for ethernet chip.

Message ID 1315396670-22889-2-git-send-email-philip@opensdr.com
State Superseded
Headers show

Commit Message

Philip Balister Sept. 7, 2011, 11:57 a.m. UTC 
The existing timing does not quite meet the minimum requirements
in the LAN9221 datasheet. The timing in this patch solves problems
noticed on some parts.

Signed-off-by: Philip Balister <philip@opensdr.com>
---
 board/overo/overo.h |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Steve Sakoman Sept. 8, 2011, 2:21 p.m. UTC | #1 
On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister <philip@balister.org> wrote:
> The existing timing does not quite meet the minimum requirements
> in the LAN9221 datasheet. The timing in this patch solves problems
> noticed on some parts.
>
> Signed-off-by: Philip Balister <philip@opensdr.com>

Acked-by: Steve Sakoman <steve@sakoman.com>
Tested-by: Steve Sakoman <steve@sakoman.com>

> ---
>  board/overo/overo.h |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/board/overo/overo.h b/board/overo/overo.h
> index 68e1243..617c0c3 100644
> --- a/board/overo/overo.h
> +++ b/board/overo/overo.h
> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>
>  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>  #define NET_LAN9221_GPMC_CONFIG1    0x00001000
> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>  #define NET_LAN9221_GPMC_CONFIG6    0x87030000
>  #define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>
> --
> 1.7.4.4
>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
Enric Balletbo Serra Sept. 8, 2011, 2:45 p.m. UTC | #2 
2011/9/8 Steve Sakoman <sakoman@gmail.com>:
> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister <philip@balister.org> wrote:
>> The existing timing does not quite meet the minimum requirements
>> in the LAN9221 datasheet. The timing in this patch solves problems
>> noticed on some parts.
>>
>> Signed-off-by: Philip Balister <philip@opensdr.com>
>
> Acked-by: Steve Sakoman <steve@sakoman.com>
> Tested-by: Steve Sakoman <steve@sakoman.com>
>
>> ---
>>  board/overo/overo.h |    6 +++---
>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>> index 68e1243..617c0c3 100644
>> --- a/board/overo/overo.h
>> +++ b/board/overo/overo.h
>> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>>
>>  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>  #define NET_LAN9221_GPMC_CONFIG1    0x00001000
>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>>  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
>> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>>  #define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>  #define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>
>> --
>> 1.7.4.4
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>

Other boards like IGEP v2 board uses the same LAN9221 ethernet
controller, so this code is duplicated on overo.h and igep0020.h
files. Maybe could be a good idea move this part to
arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
duplicate the code.
Philip Balister Sept. 8, 2011, 6:50 p.m. UTC | #3 
On 09/08/2011 10:45 AM, Enric Balletbò i Serra wrote:
> 2011/9/8 Steve Sakoman<sakoman@gmail.com>:
>> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister<philip@balister.org>  wrote:
>>> The existing timing does not quite meet the minimum requirements
>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>> noticed on some parts.
>>>
>>> Signed-off-by: Philip Balister<philip@opensdr.com>
>>
>> Acked-by: Steve Sakoman<steve@sakoman.com>
>> Tested-by: Steve Sakoman<steve@sakoman.com>
>>
>>> ---
>>>   board/overo/overo.h |    6 +++---
>>>   1 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>> index 68e1243..617c0c3 100644
>>> --- a/board/overo/overo.h
>>> +++ b/board/overo/overo.h
>>> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>>>
>>>   /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>>   #define NET_LAN9221_GPMC_CONFIG1    0x00001000
>>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>>> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>>>   #define NET_LAN9221_GPMC_CONFIG3    0x00020201
>>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>>> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
>>> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>>>   #define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>>   #define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>>
>>> --
>>> 1.7.4.4
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>
> Other boards like IGEP v2 board uses the same LAN9221 ethernet
> controller, so this code is duplicated on overo.h and igep0020.h
> files. Maybe could be a good idea move this part to
> arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
> duplicate the code.

Is there anyone around with an igep v2 board who could test/ack such a 
patch?

Philip
Enric Balletbo Serra Sept. 8, 2011, 7:48 p.m. UTC | #4 
2011/9/8 Philip Balister <philip@opensdr.com>:
> On 09/08/2011 10:45 AM, Enric Balletbò i Serra wrote:
>>
>> 2011/9/8 Steve Sakoman<sakoman@gmail.com>:
>>>
>>> On Wed, Sep 7, 2011 at 4:57 AM, Philip Balister<philip@balister.org>
>>>  wrote:
>>>>
>>>> The existing timing does not quite meet the minimum requirements
>>>> in the LAN9221 datasheet. The timing in this patch solves problems
>>>> noticed on some parts.
>>>>
>>>> Signed-off-by: Philip Balister<philip@opensdr.com>
>>>
>>> Acked-by: Steve Sakoman<steve@sakoman.com>
>>> Tested-by: Steve Sakoman<steve@sakoman.com>
>>>
>>>> ---
>>>>  board/overo/overo.h |    6 +++---
>>>>  1 files changed, 3 insertions(+), 3 deletions(-)
>>>>
>>>> diff --git a/board/overo/overo.h b/board/overo/overo.h
>>>> index 68e1243..617c0c3 100644
>>>> --- a/board/overo/overo.h
>>>> +++ b/board/overo/overo.h
>>>> @@ -35,10 +35,10 @@ const omap3_sysinfo sysinfo = {
>>>>
>>>>  /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
>>>>  #define NET_LAN9221_GPMC_CONFIG1    0x00001000
>>>> -#define NET_LAN9221_GPMC_CONFIG2    0x00080701
>>>> +#define NET_LAN9221_GPMC_CONFIG2    0x00060700
>>>>  #define NET_LAN9221_GPMC_CONFIG3    0x00020201
>>>> -#define NET_LAN9221_GPMC_CONFIG4    0x08030703
>>>> -#define NET_LAN9221_GPMC_CONFIG5    0x00060908
>>>> +#define NET_LAN9221_GPMC_CONFIG4    0x06000700
>>>> +#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
>>>>  #define NET_LAN9221_GPMC_CONFIG6    0x87030000
>>>>  #define NET_LAN9221_GPMC_CONFIG7    0x00000f6c
>>>>
>>>> --
>>>> 1.7.4.4
>>>>
>>>> _______________________________________________
>>>> U-Boot mailing list
>>>> U-Boot@lists.denx.de
>>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>
>> Other boards like IGEP v2 board uses the same LAN9221 ethernet
>> controller, so this code is duplicated on overo.h and igep0020.h
>> files. Maybe could be a good idea move this part to
>> arch/arm/include/asm/arch-omap3/omap_gpmc.h or another file to not
>> duplicate the code.
>
> Is there anyone around with an igep v2 board who could test/ack such a
> patch?
>
> Philip
>

Yes, I can, I expect test the patch tomorrow ...

  Enric
diff mbox

Patch

diff --git a/board/overo/overo.h b/board/overo/overo.h
index 68e1243..617c0c3 100644
--- a/board/overo/overo.h
+++ b/board/overo/overo.h
@@ -35,10 +35,10 @@  const omap3_sysinfo sysinfo = {
 
 /* GPMC CS 5 connected to an SMSC LAN9221 ethernet controller */
 #define NET_LAN9221_GPMC_CONFIG1    0x00001000
-#define NET_LAN9221_GPMC_CONFIG2    0x00080701
+#define NET_LAN9221_GPMC_CONFIG2    0x00060700
 #define NET_LAN9221_GPMC_CONFIG3    0x00020201
-#define NET_LAN9221_GPMC_CONFIG4    0x08030703
-#define NET_LAN9221_GPMC_CONFIG5    0x00060908
+#define NET_LAN9221_GPMC_CONFIG4    0x06000700
+#define NET_LAN9221_GPMC_CONFIG5    0x0006090A
 #define NET_LAN9221_GPMC_CONFIG6    0x87030000
 #define NET_LAN9221_GPMC_CONFIG7    0x00000f6c