Message ID | CAM=4YEQGUVnF21uCNcHktb4btTiTibUxSPf_m7bED86P1Th6Kw@mail.gmail.com |
---|---|
State | Not Applicable |
Headers | show |
> > This patch added a build warning like this: > > gpio.c: In function 'omap_get_gpio_dataout': > gpio.c:161: warning: assignment discards qualifiers from pointer target > type > > The fix is this: > We will have to co ordinate the best way to move forward on this. Sanjeev submitted a patch set to move to the generic GPIO framework. Regards, Sandeep
I don't remember seeing any errors/warnings after applying my patches... on all boards listed in the cover letter. ...except for SMSC95x - in case of Panda. Infact, once the patches are applied, this function shouldn't even exist. ~sanjeev
On Tue, Sep 6, 2011 at 1:16 PM, Premi, Sanjeev <premi@ti.com> wrote: > I don't remember seeing any errors/warnings after applying my patches... on all boards listed in the cover letter. > ...except for SMSC95x - in case of Panda. > > Infact, once the patches are applied, this function shouldn't even exist. > I didn't follow, why shouldn't the function be required? Is it being replaced with another one? Thanks, Joel
diff --git a/arch/arm/cpu/armv7/omap-common/gpio.c b/arch/arm/cpu/armv7/omap-common/gpio.c index 4749524..c4126fe 100644 --- a/arch/arm/cpu/armv7/omap-common/gpio.c +++ b/arch/arm/cpu/armv7/omap-common/gpio.c @@ -153,7 +153,7 @@ int omap_get_gpio_datain(int gpio) int omap_get_gpio_dataout(int gpio) { - struct gpio_bank *bank; + const struct gpio_bank *bank; void *reg; if (check_gpio(gpio) < 0)