| Message ID | 20210304222323.1954755-2-f4bug@amsat.org |
|---|---|
| State | New |
| Headers | show |
| Series | cpu: Move CPUClass::has_work() to TCGCPUOps | expand |
On 04.03.21 23:23, Philippe Mathieu-Daudé wrote: > Invert the #ifdef'ry to easily restrict tcg_exec_init() declaration > to CONFIG_TCG. > > Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> > --- > include/sysemu/tcg.h | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h > index 00349fb18a7..fddde2b6b9a 100644 > --- a/include/sysemu/tcg.h > +++ b/include/sysemu/tcg.h > @@ -8,13 +8,15 @@ > #ifndef SYSEMU_TCG_H > #define SYSEMU_TCG_H > > +#ifndef CONFIG_TCG > +#define tcg_enabled() 0 > +#else > + > void tcg_exec_init(unsigned long tb_size, int splitwx); > > -#ifdef CONFIG_TCG > extern bool tcg_allowed; > #define tcg_enabled() (tcg_allowed) > -#else > -#define tcg_enabled() 0 > -#endif > + > +#endif /* CONFIG_TCG */ > > #endif > Reviewed-by: David Hildenbrand <david@redhat.com>
On 3/8/21 2:40 PM, David Hildenbrand wrote: > On 04.03.21 23:23, Philippe Mathieu-Daudé wrote: >> Invert the #ifdef'ry to easily restrict tcg_exec_init() declaration >> to CONFIG_TCG. >> >> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> >> --- >> include/sysemu/tcg.h | 10 ++++++---- >> 1 file changed, 6 insertions(+), 4 deletions(-) >> >> diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h >> index 00349fb18a7..fddde2b6b9a 100644 >> --- a/include/sysemu/tcg.h >> +++ b/include/sysemu/tcg.h >> @@ -8,13 +8,15 @@ >> #ifndef SYSEMU_TCG_H >> #define SYSEMU_TCG_H >> >> +#ifndef CONFIG_TCG >> +#define tcg_enabled() 0 >> +#else >> + >> void tcg_exec_init(unsigned long tb_size, int splitwx); >> >> -#ifdef CONFIG_TCG >> extern bool tcg_allowed; >> #define tcg_enabled() (tcg_allowed) >> -#else >> -#define tcg_enabled() 0 >> -#endif >> + >> +#endif /* CONFIG_TCG */ >> >> #endif >> > > Reviewed-by: David Hildenbrand <david@redhat.com> > Reviewed-by: Claudio Fontana <cfontana@suse.de>
diff --git a/include/sysemu/tcg.h b/include/sysemu/tcg.h index 00349fb18a7..fddde2b6b9a 100644 --- a/include/sysemu/tcg.h +++ b/include/sysemu/tcg.h @@ -8,13 +8,15 @@ #ifndef SYSEMU_TCG_H #define SYSEMU_TCG_H +#ifndef CONFIG_TCG +#define tcg_enabled() 0 +#else + void tcg_exec_init(unsigned long tb_size, int splitwx); -#ifdef CONFIG_TCG extern bool tcg_allowed; #define tcg_enabled() (tcg_allowed) -#else -#define tcg_enabled() 0 -#endif + +#endif /* CONFIG_TCG */ #endif
Invert the #ifdef'ry to easily restrict tcg_exec_init() declaration to CONFIG_TCG. Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org> --- include/sysemu/tcg.h | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)