Message ID | 20210302070749.647742-1-bernd.kuhls@t-online.de |
---|---|
Headers | show |
Series | package/kodi: bump version to 19.0-Matrix | expand |
Hello Bernd,
On Tue, 2 Mar 2021 08:06:55 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:
> this series bumps kodi to 19.0-Matrix.
Thanks a lot for this series. I have applied it all to the next branch!
First of all, I have to say that it was really a pleasure to see such
documented commit logs, with the details of why the different packaging
changes are being made. It definitely made the series easier to review,
so thanks a lot for this.
I only encountered a few small issues:
- You forgot the Config.in.legacy entry when dropping
kodi-screensaver-crystalmorph
- For the kodi-pvr-mediaportal-tvserver there were line ending issues
with the patches, but it was not your fault, the line endings get
damaged by patchwork
- For another patch (don't remember which one), you had forgotten to
update the .hash file to take into account the fact that the license
file is now LICENSE.md.
There are two things however that would be nice to improve:
- Be able to drop the significant patches on
kodi-pvr-mediaportal-tvserver, but I see they are already submitted
upstream, so I assume some next release will allow to drop them.
- Be able to drop the manual calls to pkg-config --cflags/--libs egl
that exist in a few packages.
Once again, many thanks for all this work on Kodi!
Best regards,
Thomas
Hi Thomas, Am Sat, 06 Mar 2021 23:03:05 +0100 schrieb Thomas Petazzoni: > There are two things however that would be nice to improve: > [...] > - Be able to drop the manual calls to pkg-config --cflags/--libs egl > that exist in a few packages. I will try to fix the problem, afair this problem only occurs when building without x11, the infamous EGL_NO_X11 define needs to be used. > Once again, many thanks for all this work on Kodi! Just a small note from the runtime perspective: With this bump I was able to get rid of all X.org stuff by using gbm & OpenGLES as render method on my x86_64 system: https://forum.kodi.tv/showthread.php?tid=360658 :) Regards, Bernd